From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: jun qian <hangdianqj@163.com>
Cc: Dirk van der Merwe <dirk.vandermerwe@netronome.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Quentin Monnet <quentin.monnet@netronome.com>,
oss-drivers@netronome.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ethernet:netronome:nfp:move spin_lock_bh to spin_lock in tasklet
Date: Fri, 7 Sep 2018 18:36:36 +0200 [thread overview]
Message-ID: <20180907183636.48a681f4@cakuba> (raw)
In-Reply-To: <20180907162117.47361-1-hangdianqj@163.com>
On Fri, 7 Sep 2018 09:21:17 -0700, jun qian wrote:
> As you are already in a tasklet, it is unnecessary to call spin_lock_bh.
>
> Signed-off-by: jun qian <hangdianqj@163.com>
FWIW you should put spaces after the colons. It's generally a good
practice to look at the prefix previous authors used for a given piece
of code with
git log -- $file_path
This would be a better subject:
nfp: replace spin_lock_bh with spin_lock in tasklet callback
next prev parent reply other threads:[~2018-09-07 16:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 16:21 [PATCH] ethernet:netronome:nfp:move spin_lock_bh to spin_lock in tasklet jun qian
2018-09-07 16:33 ` Jakub Kicinski
2018-09-07 16:36 ` Jakub Kicinski [this message]
2018-09-07 17:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180907183636.48a681f4@cakuba \
--to=jakub.kicinski@netronome.com \
--cc=daniel@iogearbox.net \
--cc=dirk.vandermerwe@netronome.com \
--cc=hangdianqj@163.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=quentin.monnet@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.