From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 0/4] Add support for Arm Framebuffer Compression(AFBC) Date: Sun, 9 Sep 2018 14:03:57 +0200 Message-ID: <20180909120357.GA19774@phenom.ffwll.local> References: <1531228737-5450-1-git-send-email-ayan.halder@arm.com> <0e22e63c-6981-9e5d-ed2d-2ad1dfbccd4f@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x541.google.com (mail-ed1-x541.google.com [IPv6:2a00:1450:4864:20::541]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8594B6E220 for ; Sun, 9 Sep 2018 12:04:06 +0000 (UTC) Received: by mail-ed1-x541.google.com with SMTP id h33-v6so14485426edb.5 for ; Sun, 09 Sep 2018 05:04:06 -0700 (PDT) Content-Disposition: inline In-Reply-To: <0e22e63c-6981-9e5d-ed2d-2ad1dfbccd4f@baylibre.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Neil Armstrong Cc: nd@arm.com, airlied@linux.ie, liviu.dudau@arm.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, malidp@foss.arm.com, Ayan Kumar Halder List-Id: dri-devel@lists.freedesktop.org T24gU2F0LCBTZXAgMDgsIDIwMTggYXQgMDM6NTg6NTNQTSArMDIwMCwgTmVpbCBBcm1zdHJvbmcg d3JvdGU6Cj4gSGkgQXlhbiwKPiAKPiBPbiAxMC8wNy8yMDE4IDE1OjE4LCBBeWFuIEt1bWFyIEhh bGRlciB3cm90ZToKPiA+IEluIHRoZSBjdXJyZW50IHNlcmllcyBvZiBwYXRjaGVzLCB3ZSBhcmUg dHJ5aW5nIHRvIGFkZCBzdXBwb3J0IGZvciBBRkJDCj4gPiBtb2RpZmllcnMgaW4gbWFsaWRwLiBB RkJDIG1vZGlmaWVycyBhZGRzIHNvbWUgY29uc3RyYWludHMgdG8gZnJhbWVidWZmZXIKPiA+IHNp emUsIGFsaWdubWVudCwgcGl0Y2gsIGZvcm1hdHMsIGV0Yy4gSGVyZSB3ZSBhcmUgdHJ5aW5nIHRv IGFkZCBzdXBwb3J0Cj4gPiBmb3Igb25lIGNvbWJpbmF0aW9uIG9mIEFGQkMgbW9kaWZpZXIgaWUg QUZCQ19GT1JNQVRfTU9EX0JMT0NLX1NJWkVfMTZ4MTYgfAo+ID4gQUZCQ19GT1JNQVRfTU9EX1NQ QVJTRSB8IEFGQkNfRk9STUFUX01PRF9ZVFIuCj4gPiBJbiBmdXR1cmUsIHdlIGludGVuZCB0byBh ZGQgc3VwcG9ydCBmb3IgbW9yZSBjb21iaW5hdGlvbiBvZiBBRkJDIG1vZGlmaWVycy4KPiA+IEN1 cnJlbnRseSwgd2UgYXJlIHRyeWluZyB0byBlbmFibGUgYSBiYXNpYyBzdXBwb3J0IG9mIEFGQkMg aW4gbWFsaWRwLgo+IAo+IFRoYW5rcyBmb3IgcHVzaGluZyBBRkJDIHN1cHBvcnQsIHRoaXMgd2ls bCBoZWxwIHN1cHBvcnRpbmcgaXQgb24gb3RoZXIgU29DcyBpbXBsZW1lbnRpbmcgc3VwcG9ydAo+ IGxpa2UgQW1sb2dpYywgUm9ja2NoaXAgb3IgU2Ftc3VuZy4KPiAKPiBJIGhhdmUgb25lIHF1ZXN0 aW9uLCBpcyB0aGVyZSBhIHdheSB0byBnZW5lcmF0ZSBzdWNoIEFGQkMgYnVmZmVycyB3aXRob3V0 IHRoZSBNYWxpIEdQVSA/Cj4gSSBtZWFuLCBpcyB0aGVyZSBhIHdheSB0byBnZW5lcmF0ZSBzb21l IHNhbXBsZSBidWZmZXJzIHdpdGggc29tZSBvZiB0aGUgbW9kaWZpZXIgZmVhdHVyZXMKPiB0byB2 YWxpZGF0ZSBpdCB3aXRob3V0IGhhdmluZyB0aGUgY29tcGxldGUgTWFsaSBHUFUgLT4gRFJNIGNo YWluID8KCkFuIGlndCB3b3VsZCBiZSBwZXJmZWN0LiBXZSd2ZSBkb25lIHRoYXQgZm9yIGk5MTUg Y29tcHJlc3NlZCBidWZmZXJzLiBOb3RlCnRoYXQgaXQganVzdCBuZWVkcyB0byBiZSBhbiBhZmJj IGJ1ZmZlciwgbm90IGFjdHVhbGx5IGNvbXByZXNzZWQuIFNldHRpbmcKYWxsIHRoZSBiaXRzIHRv IGluZGljYXRlICJ1bmNvbXByZXNzZWQiIGZvciBlYWNoIGJsb2NrIGlzIHdoYXQgd2UgZGlkIGZv cgp0aGUgaTkxNSB0ZXN0LiBBcyBsb25nIGFzIHRoZSBpZ3QgdXNlcyBEUklWRVJfR0VORVJJQyBh bmQga21zIGRyaXZlciBjb3VsZAp0aGVuIHVzZSBpdCB0byB2YWxpZGF0ZSB0aGUgYmFzaWNzIG9m IGFmYmMgc3VwcG9ydC4KLURhbmllbAoKPiAKPiBUaGFua3MgaW4gYWR2YW5jZSwKPiBOZWlsCj4g Cj4gPiAKPiA+IENoYW5nZXMgZnJvbSB2MjoKPiA+IC0gQWRkZWQgYWNrIGJ5IE1hYXJ0ZW4gTGFu a2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gPiBmb3IgcGF0Y2gg MS4gSG93ZXZlciwgdGhpcyBoYXMgYmVlbiBrZXB0IGluIHRoaXMgc2VyaWVzIGluIG9yZGVyIHRv IGhlbHAKPiA+IHJldmlld2VycyByZXZpZXcgdGhlIG90aGVyIHBhdGNoZXMgKHdoaWNoIGFyZSBy ZWxhdGVkIHRvIHBhdGNoIDEpCj4gPiAtIEZvciBwYXRjaGVzIDIgYW5kIDQsIHJlcGxhY2VkIERS TV9FUlJPUigpIHdpdGggRFJNX0RFQlVHX0tNUygpCj4gPiAtIEZvciBwYXRjaCAzLCByZXdvcmtl ZCBtYWxpZHBfZGVfc2V0X3BsYW5lX2FmYmMoKSBzbyBhcyB0byBjb25zb2xpZGF0ZQo+ID4gYWxs IGFmYmMgc3BlY2lmaWMgcmVnaXN0ZXIgY29uZmlndXJhdGlvbiBpbiB0aGlzLgo+ID4gCj4gPiBB eWFuIEt1bWFyIEhhbGRlciAoNCk6Cj4gPiAgIGRybS9hcm0vbWFsaWRwOiBBZGQgbW9kaWZpZXIg ZGVmaW5pdGlvbnMgZm9yIGRlc2NyaWJpbmcgQXJtCj4gPiAgICAgRnJhbWVidWZmZXIgQ29tcHJl c3Npb24gKEFGQkMpLgo+ID4gICBkcm0vYXJtL21hbGlkcDogSW1wbGVtZW50ZWQgdGhlIHNpemUg dmFsaWRhdGlvbiBmb3IgQUZCQyBmcmFtZWJ1ZmZlcnMKPiA+ICAgZHJtL2FybS9tYWxpZHA6IFNl dCB0aGUgQUZCQyByZWdpc3RlciBiaXRzIGlmIHRoZSBmcmFtZWJ1ZmZlciBoYXMgQUZCQwo+ID4g ICAgIG1vZGlmaWVyCj4gPiAgIGRybS9hcm0vbWFsaWRwOiBBZGRlZCBzdXBwb3J0IGZvciBBRkJD IG1vZGlmaWVycyBmb3IgYWxsIGxheWVycyBleGNlcHQKPiA+ICAgICBERV9TTUFSVAo+ID4gCj4g PiAgZHJpdmVycy9ncHUvZHJtL2FybS9tYWxpZHBfZHJ2LmMgICAgfCAxMjkgKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKystCj4gPiAgZHJpdmVycy9ncHUvZHJtL2FybS9tYWxpZHBf aHcuYyAgICAgfCAgMjcgKysrKystLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vYXJtL21hbGlkcF9o dy5oICAgICB8ICAgNyArKwo+ID4gIGRyaXZlcnMvZ3B1L2RybS9hcm0vbWFsaWRwX3BsYW5lcy5j IHwgMTI5ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLQo+ID4gIGRyaXZlcnMv Z3B1L2RybS9hcm0vbWFsaWRwX3JlZ3MuaCAgIHwgIDIwICsrKysrKwo+ID4gIGluY2x1ZGUvdWFw aS9kcm0vZHJtX2ZvdXJjYy5oICAgICAgIHwgIDgzICsrKysrKysrKysrKysrKysrKysrKysrCj4g PiAgNiBmaWxlcyBjaGFuZ2VkLCAzNzMgaW5zZXJ0aW9ucygrKSwgMjIgZGVsZXRpb25zKC0pCj4g PiAKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWwKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlv bgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIM_INVALID, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7510DC433F5 for ; Sun, 9 Sep 2018 12:04:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E426A20865 for ; Sun, 9 Sep 2018 12:04:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="TjlgNHiz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E426A20865 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726838AbeIIQxf (ORCPT ); Sun, 9 Sep 2018 12:53:35 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:33175 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726705AbeIIQxe (ORCPT ); Sun, 9 Sep 2018 12:53:34 -0400 Received: by mail-ed1-f65.google.com with SMTP id d8-v6so14528084edv.0 for ; Sun, 09 Sep 2018 05:04:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=PSaPteZOwUWCyaJnmW0KjszXblroNbQ036MRoBRas8w=; b=TjlgNHizsD/4dwrStI5A3qjFrQnfuzkdHaC7bGn/UPtePgOJKWhVpPA4f5LHaLgI+e w+wn3OGaYybRzdgXh52DvS6uHtw0rYPWbA16gOOHcF1TOdVJT5bukIxGA/inTak+dlwB clqlf0xAVF9hrddyXGWVt2BcBIM257xRIh0DI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=PSaPteZOwUWCyaJnmW0KjszXblroNbQ036MRoBRas8w=; b=L8/R6Jec1LuAZVrQ0P7f5uTaCdsO9x5KIBpgJXRkJfHfKpVMgolWC+2aHNy0mMxy3A HQmRTPi+g9c3HlPb2XQ+Dbyh7QwTuKsJHsxuRe1cs/OWlZUfivC7Zw1UNF4v/tZYol+j YDVKzE9sYIEIuh0KEQwjKU/Bh2nU43pajBVHnpAbtey25nrzyU+xJMIFRuafACp4O2XF E/z43BUVjbuJ77sg6how2U8wZQyG8KsAG0TaubqWhjRPneuDElAd9shaAV8RPFoCVXjs 5SDNANpxQ4m/rdhlPggjddIDEs20jeDwmSECvzSXQoSoCPu7WI98gUkU2AZFWLkuFrQN LZ2A== X-Gm-Message-State: APzg51CN2GPoPP+XTkGohA5DTw58NfNyya4+exI+fiV69tDy9YdD/QK3 iBbneNaqK0P6WvEML83Sfj+G6w== X-Google-Smtp-Source: ANB0VdYyWt7zpRhplljUmuu3nfJo9wADUFIRLh+Bar1almy3NXl3P2Ms1PEGOr3fz9/NwTeajgTZbw== X-Received: by 2002:aa7:d707:: with SMTP id t7-v6mr18327156edq.250.1536494645060; Sun, 09 Sep 2018 05:04:05 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id p28-v6sm9351976eda.85.2018.09.09.05.04.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 09 Sep 2018 05:04:03 -0700 (PDT) Date: Sun, 9 Sep 2018 14:03:57 +0200 From: Daniel Vetter To: Neil Armstrong Cc: Ayan Kumar Halder , liviu.dudau@arm.com, brian.starkey@arm.com, malidp@foss.arm.com, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, nd@arm.com Subject: Re: [PATCH v2 0/4] Add support for Arm Framebuffer Compression(AFBC) Message-ID: <20180909120357.GA19774@phenom.ffwll.local> Mail-Followup-To: Neil Armstrong , Ayan Kumar Halder , liviu.dudau@arm.com, brian.starkey@arm.com, malidp@foss.arm.com, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, nd@arm.com References: <1531228737-5450-1-git-send-email-ayan.halder@arm.com> <0e22e63c-6981-9e5d-ed2d-2ad1dfbccd4f@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0e22e63c-6981-9e5d-ed2d-2ad1dfbccd4f@baylibre.com> X-Operating-System: Linux phenom 4.14.0-3-amd64 User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Sep 08, 2018 at 03:58:53PM +0200, Neil Armstrong wrote: > Hi Ayan, > > On 10/07/2018 15:18, Ayan Kumar Halder wrote: > > In the current series of patches, we are trying to add support for AFBC > > modifiers in malidp. AFBC modifiers adds some constraints to framebuffer > > size, alignment, pitch, formats, etc. Here we are trying to add support > > for one combination of AFBC modifier ie AFBC_FORMAT_MOD_BLOCK_SIZE_16x16 | > > AFBC_FORMAT_MOD_SPARSE | AFBC_FORMAT_MOD_YTR. > > In future, we intend to add support for more combination of AFBC modifiers. > > Currently, we are trying to enable a basic support of AFBC in malidp. > > Thanks for pushing AFBC support, this will help supporting it on other SoCs implementing support > like Amlogic, Rockchip or Samsung. > > I have one question, is there a way to generate such AFBC buffers without the Mali GPU ? > I mean, is there a way to generate some sample buffers with some of the modifier features > to validate it without having the complete Mali GPU -> DRM chain ? An igt would be perfect. We've done that for i915 compressed buffers. Note that it just needs to be an afbc buffer, not actually compressed. Setting all the bits to indicate "uncompressed" for each block is what we did for the i915 test. As long as the igt uses DRIVER_GENERIC and kms driver could then use it to validate the basics of afbc support. -Daniel > > Thanks in advance, > Neil > > > > > Changes from v2: > > - Added ack by Maarten Lankhorst > > for patch 1. However, this has been kept in this series in order to help > > reviewers review the other patches (which are related to patch 1) > > - For patches 2 and 4, replaced DRM_ERROR() with DRM_DEBUG_KMS() > > - For patch 3, reworked malidp_de_set_plane_afbc() so as to consolidate > > all afbc specific register configuration in this. > > > > Ayan Kumar Halder (4): > > drm/arm/malidp: Add modifier definitions for describing Arm > > Framebuffer Compression (AFBC). > > drm/arm/malidp: Implemented the size validation for AFBC framebuffers > > drm/arm/malidp: Set the AFBC register bits if the framebuffer has AFBC > > modifier > > drm/arm/malidp: Added support for AFBC modifiers for all layers except > > DE_SMART > > > > drivers/gpu/drm/arm/malidp_drv.c | 129 +++++++++++++++++++++++++++++++++++- > > drivers/gpu/drm/arm/malidp_hw.c | 27 +++++--- > > drivers/gpu/drm/arm/malidp_hw.h | 7 ++ > > drivers/gpu/drm/arm/malidp_planes.c | 129 +++++++++++++++++++++++++++++++++--- > > drivers/gpu/drm/arm/malidp_regs.h | 20 ++++++ > > include/uapi/drm/drm_fourcc.h | 83 +++++++++++++++++++++++ > > 6 files changed, 373 insertions(+), 22 deletions(-) > > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch