From: Borislav Petkov <bp@alien8.de>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel/sched/core.c: Avoid unused variable on non-SMP configs
Date: Sun, 9 Sep 2018 18:06:01 +0200 [thread overview]
Message-ID: <20180909160601.GA3873@zn.tnic> (raw)
In-Reply-To: <CANiq72=RbankDmDSmD+jtvAFArGG-orMSayooGCAEa73_aOAuw@mail.gmail.com>
On Sun, Sep 09, 2018 at 04:48:19PM +0200, Miguel Ojeda wrote:
> Indeed. But note that the attribute needs to be written before the
> variable name so that it applies to both variables (or write it twice)
It warns only about 'steal' - not the other one.
> Also, if we go that route, I would simply remove the #ifdef entirely.
Even better. The less ifdeffery the better.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2018-09-09 16:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-08 19:05 [PATCH] kernel/sched/core.c: Avoid unused variable on non-SMP configs Miguel Ojeda
2018-09-09 9:36 ` Borislav Petkov
2018-09-09 14:48 ` Miguel Ojeda
2018-09-09 16:06 ` Borislav Petkov [this message]
2018-09-09 16:36 ` Miguel Ojeda
2018-09-09 16:45 ` Borislav Petkov
2018-09-09 16:59 ` Miguel Ojeda
2018-09-10 7:00 ` Vincent Guittot
2018-09-10 10:32 ` Miguel Ojeda
2018-09-10 12:34 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180909160601.GA3873@zn.tnic \
--to=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.