From: Ingo Molnar <mingo@kernel.org>
To: Alexey Budankov <alexey.budankov@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Andi Kleen <ak@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8 0/3]: perf: reduce data loss when profiling highly parallel CPU bound workloads
Date: Mon, 10 Sep 2018 11:18:41 +0200 [thread overview]
Message-ID: <20180910091841.GA4664@gmail.com> (raw)
In-Reply-To: <e1144f9d-b231-e42c-d698-4db0e62b71ff@linux.intel.com>
* Alexey Budankov <alexey.budankov@linux.intel.com> wrote:
>
> Currently in record mode the tool implements trace writing serially.
> The algorithm loops over mapped per-cpu data buffers and stores
> ready data chunks into a trace file using write() system call.
>
> At some circumstances the kernel may lack free space in a buffer
> because the other buffer's half is not yet written to disk due to
> some other buffer's data writing by the tool at the moment.
>
> Thus serial trace writing implementation may cause the kernel
> to loose profiling data and that is what observed when profiling
> highly parallel CPU bound workloads on machines with big number
> of cores.
Yay! I saw this frequently on a 120-CPU box (hw is broken now).
> Data loss metrics is the ratio lost_time/elapsed_time where
> lost_time is the sum of time intervals containing PERF_RECORD_LOST
> records and elapsed_time is the elapsed application run time
> under profiling.
>
> Applying asynchronous trace streaming thru Posix AIO API
> (http://man7.org/linux/man-pages/man7/aio.7.html)
> lowers data loss metrics value providing 2x improvement -
> lowering 98% loss to almost 0%.
Hm, instead of AIO why don't we use explicit threads instead? I think Posix AIO will fall back
to threads anyway when there's no kernel AIO support (which there probably isn't for perf
events).
Per-CPU threading the record session would have so many other advantages as well (scalability,
etc.).
Jiri did per-CPU recording patches a couple of months ago, not sure how usable they are at the
moment?
Thanks,
Ingo
next prev parent reply other threads:[~2018-09-10 9:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 7:07 [PATCH v8 0/3]: perf: reduce data loss when profiling highly parallel CPU bound workloads Alexey Budankov
2018-09-07 7:11 ` [PATCH v8 1/3]: perf util: map data buffer for preserving collected data Alexey Budankov
2018-09-07 7:19 ` [PATCH v8 2/3]: perf record: enable asynchronous trace writing Alexey Budankov
2018-09-07 7:39 ` [PATCH v8 3/3]: perf record: extend trace writing to multi AIO Alexey Budankov
2018-09-07 9:34 ` [PATCH v8 0/3]: perf: reduce data loss when profiling highly parallel CPU bound workloads Alexey Budankov
2018-09-10 9:18 ` Ingo Molnar [this message]
2018-09-10 9:59 ` Jiri Olsa
2018-09-10 10:03 ` Ingo Molnar
2018-09-10 10:08 ` Jiri Olsa
2018-09-10 10:13 ` Ingo Molnar
2018-09-10 10:23 ` Jiri Olsa
2018-09-10 10:45 ` Alexey Budankov
2018-09-10 10:40 ` Alexey Budankov
2018-09-10 12:06 ` Ingo Molnar
2018-09-10 13:58 ` Arnaldo Carvalho de Melo
2018-09-10 15:19 ` Alexey Budankov
2018-09-10 14:48 ` Alexey Budankov
2018-09-11 6:35 ` Ingo Molnar
2018-09-11 8:16 ` Alexey Budankov
2018-09-11 8:34 ` Jiri Olsa
2018-09-11 13:42 ` Alexey Budankov
2018-09-13 8:00 ` Jiri Olsa
2018-09-11 14:19 ` Peter Zijlstra
2018-09-12 8:27 ` Alexey Budankov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180910091841.GA4664@gmail.com \
--to=mingo@kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.budankov@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.