From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-5.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id A82A87D57F for ; Mon, 10 Sep 2018 09:49:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727411AbeIJOmw (ORCPT ); Mon, 10 Sep 2018 10:42:52 -0400 Received: from mail.bootlin.com ([62.4.15.54]:60179 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726907AbeIJOmw (ORCPT ); Mon, 10 Sep 2018 10:42:52 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id DAD37208AF; Mon, 10 Sep 2018 11:49:38 +0200 (CEST) Received: from bbrezillon (AAubervilliers-681-1-30-219.w90-88.abo.wanadoo.fr [90.88.15.219]) by mail.bootlin.com (Postfix) with ESMTPSA id 684EF208BE; Mon, 10 Sep 2018 11:49:28 +0200 (CEST) Date: Mon, 10 Sep 2018 11:49:27 +0200 From: Boris Brezillon To: Bartosz Golaszewski Cc: Srinivas Kandagatla , "David S . Miller" , Mauro Carvalho Chehab , Greg Kroah-Hartman , Andrew Morton , Arnd Bergmann , Jonathan Corbet , Sekhar Nori , Kevin Hilman , David Lechner , Andrew Lunn , Alban Bedel , Maxime Ripard , Chen-Yu Tsai , linux-doc , Linux Kernel Mailing List , Linux ARM , Bartosz Golaszewski Subject: Re: [PATCH v2 13/16] nvmem: add support for cell lookups from machine code Message-ID: <20180910114927.083e2de8@bbrezillon> In-Reply-To: References: <20180907100750.14564-1-brgl@bgdev.pl> <20180907100750.14564-14-brgl@bgdev.pl> <484b6ec5-cd8e-e5c5-0c5c-2f11c504ea1c@linaro.org> <20180910102324.52ecd8f7@bbrezillon> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Mon, 10 Sep 2018 11:45:48 +0200 Bartosz Golaszewski wrote: > 2018-09-10 10:55 GMT+02:00 Srinivas Kandagatla : > > > > > > On 10/09/18 09:23, Boris Brezillon wrote: > >> > >> Well, if we get rid of nvmem-machine.h, the cell-lookup stuff > >> should go in nvmem-consumer.h not nvmem-provider.h. On the other hand, > >> everything that is related to cell creation should be placed in > >> nvmem-provider.h. > > > > Yes, this is how it should be! > > > > Any actual reason for not putting these definitions into a separate > 'machine' header? This approach is currently used by gpio, pinctrl, > iio and regulator framework because most systems use either DT or ACPI > and don't need to pull in any stuff aimed at board files. I'm perfectly fine with the separate header file, all I'm saying is, if Srinivas does not want nvmem-machine.h, definitions should be placed in nvmem-provider.h or nvmem-consumer.h depending on who they're meant to be used by (providers or consumers). From mboxrd@z Thu Jan 1 00:00:00 1970 From: boris.brezillon@bootlin.com (Boris Brezillon) Date: Mon, 10 Sep 2018 11:49:27 +0200 Subject: [PATCH v2 13/16] nvmem: add support for cell lookups from machine code In-Reply-To: References: <20180907100750.14564-1-brgl@bgdev.pl> <20180907100750.14564-14-brgl@bgdev.pl> <484b6ec5-cd8e-e5c5-0c5c-2f11c504ea1c@linaro.org> <20180910102324.52ecd8f7@bbrezillon> Message-ID: <20180910114927.083e2de8@bbrezillon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 10 Sep 2018 11:45:48 +0200 Bartosz Golaszewski wrote: > 2018-09-10 10:55 GMT+02:00 Srinivas Kandagatla : > > > > > > On 10/09/18 09:23, Boris Brezillon wrote: > >> > >> Well, if we get rid of nvmem-machine.h, the cell-lookup stuff > >> should go in nvmem-consumer.h not nvmem-provider.h. On the other hand, > >> everything that is related to cell creation should be placed in > >> nvmem-provider.h. > > > > Yes, this is how it should be! > > > > Any actual reason for not putting these definitions into a separate > 'machine' header? This approach is currently used by gpio, pinctrl, > iio and regulator framework because most systems use either DT or ACPI > and don't need to pull in any stuff aimed at board files. I'm perfectly fine with the separate header file, all I'm saying is, if Srinivas does not want nvmem-machine.h, definitions should be placed in nvmem-provider.h or nvmem-consumer.h depending on who they're meant to be used by (providers or consumers).