Re: [PATCH v2 1/2] test/event: fix eth Rx adapter autotest for skeleton PMD

[Jerin Jacob <jerin.jacob@caviumnetworks.com>]

-----Original Message-----
> Date: Wed, 5 Sep 2018 19:21:05 +0530
> From: Nikhil Rao <nikhil.rao@intel.com>
> To: jerin.jacob@caviumnetworks.com
> CC: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>,
>  vipin.varghese@intel.com, stable@dpdk.org
> Subject: [PATCH v2 1/2] test/event: fix eth Rx adapter autotest for
>  skeleton PMD
> X-Mailer: git-send-email 1.8.3.1
> 
> External Email
> 
> skeleton PMD does not support
> RTE_EVENT_ETH_RX_ADAPTER_CAP_MULTI_EVENTQ and
> implicit_release_disable so make the Rx queue_id = -1 and
> initialize the event port configuration to zero.
> 
> Fixes: ec36d881f56d ("eventdev: add implicit release disable capability")
> Fixes: 2a9c83ae3b2e ("test/eventdev: add multi-ports test")
> Cc: vipin.varghese@intel.com
> CC: stable@dpdk.org
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> ---
> 
> v2:
> * add include patch to fix Rx adapter intr autotest as it is
>   dependent on the first patch.
> 
>  test/test/test_event_eth_rx_adapter.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/test/test/test_event_eth_rx_adapter.c b/test/test/test_event_eth_rx_adapter.c
> index 2337e54..29d0ff5 100644
> --- a/test/test/test_event_eth_rx_adapter.c
> +++ b/test/test/test_event_eth_rx_adapter.c
> @@ -317,7 +317,7 @@ struct event_eth_rx_adapter_test_params {
>  {
>         int err;
>         struct rte_event_dev_info dev_info;
> -       struct rte_event_port_conf rx_p_conf;
> +       struct rte_event_port_conf rx_p_conf = {0};

Some old compiler does not support this scheme. Can you do memset to
zero to make more portable.

> 
>         err = rte_event_dev_info_get(TEST_DEV_ID, &dev_info);
>         TEST_ASSERT(err == 0, "Expected 0 got %d", err);
> @@ -503,7 +503,7 @@ struct event_eth_rx_adapter_test_params {
>         port_index = 0;
>         for (; port_index < rte_eth_dev_count_total(); port_index += 1) {
>                 err = rte_event_eth_rx_adapter_queue_add(TEST_INST_ID,
> -                               port_index, 0,
> +                               port_index, -1,
>                                 &queue_config);
>                 TEST_ASSERT(err == 0, "Expected 0 got %d", err);
>         }
> @@ -512,7 +512,7 @@ struct event_eth_rx_adapter_test_params {
>         port_index = 0;
>         for (; port_index < rte_eth_dev_count_total(); port_index += 1) {
>                 err = rte_event_eth_rx_adapter_queue_del(TEST_INST_ID,
> -                               port_index, 0);
> +                               port_index, -1);
>                 TEST_ASSERT(err == 0, "Expected 0 got %d", err);
>         }
> 
> --
> 1.8.3.1
>