From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Angus Ainslie <angus@akkea.ca>
Cc: groeck7@gmail.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [v2] usb: typec: get the vbus source and charge values from the devicetree
Date: Mon, 10 Sep 2018 16:49:54 +0300 [thread overview]
Message-ID: <20180910134954.GA22723@kuha.fi.intel.com> (raw)
Hi Angus,
On Mon, Sep 10, 2018 at 07:11:43AM -0600, Angus Ainslie wrote:
> They are tcpm specific but need to go into the connector sub-node to get
> parsed correctly. Would something like below be better ?
>
> diff --git a/Documentation/devicetree/bindings/usb/typec-tcpci.txt
> b/Documentation/devicetree/bindings/usb/typec-tcpci.txt
> index 0dd1469e7318..ae0a3e97d9b6 100644
> --- a/Documentation/devicetree/bindings/usb/typec-tcpci.txt
> +++ b/Documentation/devicetree/bindings/usb/typec-tcpci.txt
> @@ -15,6 +15,12 @@ Required sub-node:
> of connector node are specified in
> Documentation/devicetree/bindings/connector/usb-connector.txt
>
> +Optional properties for usb-c-connector sub-node:
> +- init-vbus-source: set the initalization value for vbus-source to true.
> + If this property is not present the initial value will be false.
> +- init-vbus-charge: set the initalization value for vbus-charge to true.
> + If this property is not present the initial value will be false.
In that file those are fine.
I would prefer init-vbus-sink over init-vbus-charge, but it's up to
you.
Thanks,
WARNING: multiple messages have this Message-ID (diff)
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Angus Ainslie <angus@akkea.ca>
Cc: groeck7@gmail.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] usb: typec: get the vbus source and charge values from the devicetree
Date: Mon, 10 Sep 2018 16:49:54 +0300 [thread overview]
Message-ID: <20180910134954.GA22723@kuha.fi.intel.com> (raw)
In-Reply-To: <18a1f08b114adb65baf55f202a28d85e@www.akkea.ca>
Hi Angus,
On Mon, Sep 10, 2018 at 07:11:43AM -0600, Angus Ainslie wrote:
> They are tcpm specific but need to go into the connector sub-node to get
> parsed correctly. Would something like below be better ?
>
> diff --git a/Documentation/devicetree/bindings/usb/typec-tcpci.txt
> b/Documentation/devicetree/bindings/usb/typec-tcpci.txt
> index 0dd1469e7318..ae0a3e97d9b6 100644
> --- a/Documentation/devicetree/bindings/usb/typec-tcpci.txt
> +++ b/Documentation/devicetree/bindings/usb/typec-tcpci.txt
> @@ -15,6 +15,12 @@ Required sub-node:
> of connector node are specified in
> Documentation/devicetree/bindings/connector/usb-connector.txt
>
> +Optional properties for usb-c-connector sub-node:
> +- init-vbus-source: set the initalization value for vbus-source to true.
> + If this property is not present the initial value will be false.
> +- init-vbus-charge: set the initalization value for vbus-charge to true.
> + If this property is not present the initial value will be false.
In that file those are fine.
I would prefer init-vbus-sink over init-vbus-charge, but it's up to
you.
Thanks,
--
heikki
next reply other threads:[~2018-09-10 13:49 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 13:49 Heikki Krogerus [this message]
2018-09-10 13:49 ` [PATCH v2] usb: typec: get the vbus source and charge values from the devicetree Heikki Krogerus
-- strict thread matches above, loose matches on Subject: below --
2018-09-14 0:38 [v3] " Jun Li
2018-09-14 0:38 ` [PATCH v3] " Jun Li
2018-09-14 0:25 [v3] " Jun Li
2018-09-14 0:25 ` [PATCH v3] " Jun Li
2018-09-13 17:34 [v3] " Guenter Roeck
2018-09-13 17:34 ` [PATCH v3] " Guenter Roeck
2018-09-13 11:10 [v3] " Angus Ainslie
2018-09-13 11:10 ` [PATCH v3] " Angus Ainslie
2018-09-13 7:27 [v3] " Peter Chen
2018-09-13 7:27 ` [PATCH v3] " Peter Chen
2018-09-12 16:32 [v3] " Guenter Roeck
2018-09-12 16:32 ` [PATCH v3] " Guenter Roeck
2018-09-12 16:08 [v3] " Angus Ainslie
2018-09-12 16:08 ` [PATCH v3] " Angus Ainslie
2018-09-11 15:33 [v3] " Guenter Roeck
2018-09-11 15:33 ` [PATCH v3] " Guenter Roeck
2018-09-11 14:59 [v3] " Angus Ainslie
2018-09-11 14:59 ` [PATCH v3] " Angus Ainslie (Purism)
2018-09-10 14:32 [v2] " Angus Ainslie
2018-09-10 14:32 ` [PATCH v2] " Angus Ainslie
2018-09-10 13:43 [v2] " Guenter Roeck
2018-09-10 13:43 ` [PATCH v2] " Guenter Roeck
2018-09-10 13:11 [v2] " Angus Ainslie
2018-09-10 13:11 ` [PATCH v2] " Angus Ainslie
2018-09-10 7:35 [v2] " Heikki Krogerus
2018-09-10 7:35 ` [PATCH v2] " Heikki Krogerus
2018-09-09 20:09 [v2] " Angus Ainslie
2018-09-09 20:09 ` [PATCH v2] " Angus Ainslie
2018-09-09 19:52 [v2] " Guenter Roeck
2018-09-09 19:52 ` [PATCH v2] " Guenter Roeck
2018-09-09 18:05 [v2] " Angus Ainslie
2018-09-09 18:05 ` [PATCH v2] " Angus Ainslie (Purism)
2018-09-09 14:43 usb: typec: don't disable sink or source on initialization Guenter Roeck
2018-09-09 14:43 ` [PATCH] " Guenter Roeck
2018-09-09 14:36 Angus Ainslie
2018-09-09 14:36 ` [PATCH] " Angus Ainslie
2018-09-09 14:20 Guenter Roeck
2018-09-09 14:20 ` [PATCH] " Guenter Roeck
2018-09-09 14:08 Angus Ainslie
2018-09-09 14:08 ` [PATCH] " Angus Ainslie
2018-09-07 12:55 Guenter Roeck
2018-09-07 12:55 ` [PATCH] " Guenter Roeck
2018-09-07 10:34 Heikki Krogerus
2018-09-07 10:34 ` [PATCH] " Heikki Krogerus
2018-09-07 9:39 Sergei Shtylyov
2018-09-07 9:39 ` [PATCH] " Sergei Shtylyov
2018-09-06 19:26 Angus Ainslie
2018-09-06 19:26 ` [PATCH] " Angus Ainslie (Purism)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180910134954.GA22723@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=angus@akkea.ca \
--cc=gregkh@linuxfoundation.org \
--cc=groeck7@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.