From: "Emilio G. Cota" <cota@braap.org>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Aurelien Jarno <aurelien@aurel32.net>,
Richard Henderson <richard.henderson@linaro.org>,
Laurent Vivier <laurent@vivier.eu>
Subject: Re: [Qemu-devel] [PATCH v2 2/2] tests: add floating point tests
Date: Mon, 10 Sep 2018 10:37:47 -0400 [thread overview]
Message-ID: <20180910143747.GB19941@flamenco> (raw)
In-Reply-To: <87a7opd3br.fsf@linaro.org>
On Mon, Sep 10, 2018 at 12:00:56 +0100, Alex Bennée wrote:
> Emilio G. Cota <cota@braap.org> writes:
> > diff --git a/tests/Makefile.include b/tests/Makefile.include
> > index 87c81d1dcc..363f133101 100644
> > --- a/tests/Makefile.include
> > +++ b/tests/Makefile.include
> > @@ -657,6 +657,9 @@ tests/qht-bench$(EXESUF): tests/qht-bench.o $(test-util-obj-y)
> > tests/test-bufferiszero$(EXESUF): tests/test-bufferiszero.o $(test-util-obj-y)
> > tests/atomic_add-bench$(EXESUF): tests/atomic_add-bench.o $(test-util-obj-y)
> >
> > +tests/fp/%:
> > + $(MAKE) -C $(dir $@) $(notdir $@)
> > +
>
> This isn't enough to cause the build to be included in make check or
> indeed be run. Perhaps that should be included in a new patch in the
> series?
Yes I figured we should fix the reported errors first -- otherwise
we'll knowingly break the integration tests.
Emilio
next prev parent reply other threads:[~2018-09-10 14:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-08 19:17 [Qemu-devel] [PATCH v2 0/2] softfloat tests based on berkeley's testfloat Emilio G. Cota
2018-09-08 19:17 ` [Qemu-devel] [PATCH v2 1/2] gitmodules: add berkeley's softfloat + testfloat version 3 Emilio G. Cota
2018-09-10 9:29 ` Alex Bennée
2018-09-08 19:17 ` [Qemu-devel] [PATCH v2 2/2] tests: add floating point tests Emilio G. Cota
2018-09-10 11:00 ` Alex Bennée
2018-09-10 14:37 ` Emilio G. Cota [this message]
2018-09-10 11:26 ` [Qemu-devel] [PATCH v2 0/2] softfloat tests based on berkeley's testfloat Alex Bennée
2018-09-10 15:14 ` Emilio G. Cota
2018-09-10 15:41 ` Alex Bennée
2018-09-10 16:25 ` Emilio G. Cota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180910143747.GB19941@flamenco \
--to=cota@braap.org \
--cc=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.