From: Greg KH <gregkh@linuxfoundation.org>
To: John Whitmore <johnfwhitmore@gmail.com>
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH 18/20] staging:rtl8192u: Rename FirstSeg - Style
Date: Mon, 10 Sep 2018 17:10:02 +0200 [thread overview]
Message-ID: <20180910151002.GE25530@kroah.com> (raw)
In-Reply-To: <20180831230250.16810-19-johnfwhitmore@gmail.com>
On Sat, Sep 01, 2018 at 12:02:48AM +0100, John Whitmore wrote:
> Rename the member variable 'FirstSeg' to 'first_seg', this change
> clears the checkpatch issue with CamelCase naming.
>
> This is a simple coding style change and as such should not impact
> runtime code execution.
>
> Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
> ---
> drivers/staging/rtl8192u/r8192U.h | 2 +-
> drivers/staging/rtl8192u/r8192U_core.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U.h b/drivers/staging/rtl8192u/r8192U.h
> index 672cbfa688f7..66efa59eabf0 100644
> --- a/drivers/staging/rtl8192u/r8192U.h
> +++ b/drivers/staging/rtl8192u/r8192U.h
> @@ -163,7 +163,7 @@ struct tx_desc_819x_usb {
> u8 reserved0:3;
> u8 cmd_init:1;
> u8 last_seg:1;
> - u8 FirstSeg:1;
> + u8 first_seg:1;
> u8 LINIP:1;
> u8 OWN:1;
>
> diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
> index dfbba1177470..a4d1b55a1117 100644
> --- a/drivers/staging/rtl8192u/r8192U_core.c
> +++ b/drivers/staging/rtl8192u/r8192U_core.c
> @@ -1556,7 +1556,7 @@ short rtl8192_tx(struct net_device *dev, struct sk_buff *skb)
> * all of the descriptors
> */
> /* DWORD 0 */
> - tx_desc->FirstSeg = 1;
> + tx_desc->first_seg = 1;
Same for all of these, I'll let you respin this patch series...
thanks,
greg k-h
next prev parent reply other threads:[~2018-09-10 15:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 23:02 [PATCH 00/20] staging:rtl8192u: r8192U.h cleanup - Style John Whitmore
2018-08-31 23:02 ` [PATCH 01/20] staging:rtl8192u: Remove write_cam() " John Whitmore
2018-08-31 23:02 ` [PATCH 02/20] staging:rtl8192u: Remove read_cam() " John Whitmore
2018-08-31 23:02 ` [PATCH 03/20] staging:rtl8192u: Remove unused functions " John Whitmore
2018-08-31 23:02 ` [PATCH 04/20] staging:rtl8192u: Add SPDX-License-Identifier " John Whitmore
2018-08-31 23:02 ` [PATCH 05/20] staging:rtl8192u: Rename RTL819xU_MODULE_NAME " John Whitmore
2018-08-31 23:02 ` [PATCH 06/20] staging:rtl8192u: Rename Rx_Smooth_Factor " John Whitmore
2018-08-31 23:02 ` [PATCH 07/20] staging:rtl8192u: Refactor RT_TRACE " John Whitmore
2018-08-31 23:02 ` [PATCH 08/20] staging:rtl8192u: Fix space characters " John Whitmore
2018-08-31 23:02 ` [PATCH 09/20] staging:rtl8192u: Remove RT_DEBUG_DATA " John Whitmore
2018-08-31 23:02 ` [PATCH 10/20] staging:rtl8192u: Rename PHY_Beacon_RSSI_SLID_WIN_MAX " John Whitmore
2018-08-31 23:02 ` [PATCH 11/20] staging:rtl8192u: Rename OFDM_Table_Length " John Whitmore
2018-08-31 23:02 ` [PATCH 12/20] staging:rtl8192u: Rename CCK_Table_length " John Whitmore
2018-08-31 23:02 ` [PATCH 13/20] staging:rtl8192u: Rename PktSize Style John Whitmore
2018-08-31 23:02 ` [PATCH 14/20] staging:rtl8192u: Rename Offset - Style John Whitmore
2018-08-31 23:02 ` [PATCH 15/20] staging:rtl8192u: Rename Reserved... structure members " John Whitmore
2018-08-31 23:02 ` [PATCH 16/20] staging:rtl8192u: Rename CmdInit " John Whitmore
2018-08-31 23:02 ` [PATCH 17/20] staging:rtl8192u: Rename LastSeg " John Whitmore
2018-08-31 23:02 ` [PATCH 18/20] staging:rtl8192u: Rename FirstSeg " John Whitmore
2018-09-10 15:10 ` Greg KH [this message]
2018-08-31 23:02 ` [PATCH 19/20] staging:rtl8192u: Rename LINIP " John Whitmore
2018-09-10 15:09 ` Greg KH
2018-08-31 23:02 ` [PATCH 20/20] staging:rtl8192u: Rename OWN " John Whitmore
2018-09-10 15:09 ` Greg KH
2018-09-11 21:49 ` John Whitmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180910151002.GE25530@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=johnfwhitmore@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.