All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
	David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	Marek Vasut <marek.vasut@gmail.com>,
	linux-mtd@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH] mtd: rawnand: marvell: prevent harmless warnings
Date: Mon, 10 Sep 2018 15:15:23 +0200	[thread overview]
Message-ID: <20180910151523.38a59b68@xps13> (raw)
In-Reply-To: <20180910145744.4a73b068@bbrezillon>

Hi Boris,

Boris Brezillon <boris.brezillon@bootlin.com> wrote on Mon, 10 Sep 2018
14:57:44 +0200:

> On Fri,  7 Sep 2018 16:29:54 +0200
> Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> 
> > Since the addition of WARN_ON() in nand_subop_get_data/addr_len()
> > helpers, this driver will produce harmless warnings (mostly at probe)
> > just because it always called the *_data_len() helper in the parsing  
> 
> 			 ^calls
> 
> > function (even on non-data instructions, where this value is
> > meaningless and unneeded.  
> 
> 			  ^ missing ')'
> 
> > 
> > Fix these warnings by deriving the length only when it is relevant.
> > 
> > Fixes: 760c435e0f85 ("mtd: rawnand: make subop helpers return unsigned values")
> > Cc: stable@vger.kernel.org  
> 
> You can drop the above line this 760c435e0f85 was merged in 4.19-rc1.
> 
> If you're okay with these changes, no need to send a new version, I'll
> fix it when applying.

Sure, you can apply, thanks for fixing it.

Thanks,
Miquèl

  reply	other threads:[~2018-09-10 13:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-07 14:29 [PATCH] mtd: rawnand: marvell: prevent harmless warnings Miquel Raynal
2018-09-10 12:57 ` Boris Brezillon
2018-09-10 13:15   ` Miquel Raynal [this message]
2018-09-17 12:32     ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180910151523.38a59b68@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=boris.brezillon@bootlin.com \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=richard@nod.at \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.