From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [02/31] usb: usbssp: Added some decoding functions. From: Greg Kroah-Hartman Message-Id: <20180910181856.GB6019@kroah.com> Date: Mon, 10 Sep 2018 20:18:56 +0200 To: Pawel Laszczak Cc: linux-usb@vger.kernel.org, Felipe Balbi , linux-kernel@vger.kernel.org, ltyrala@cadence.com, adouglas@cadence.com List-ID: T24gVGh1LCBKdWwgMTksIDIwMTggYXQgMDY6NTc6MzVQTSArMDEwMCwgUGF3ZWwgTGFzemN6YWsg d3JvdGU6Cj4gVGhpcyBwYXRjaCBhZGQgYWRkaXRpb25hbCBmdW5jdGlvbnMgdGhhdCBjb252ZXJ0 cyBzb21lIGZpZWxkcyB0byBzdHJpbmcuCj4gCj4gRm9yIGV4YW1wbGUgZnVuY3Rpb24gdXNic3Nw X3RyYl9jb21wX2NvZGVfc3RyaW5nIHRha2UgY29tcGxldGlvbgo+IGNvZGUgdmFsdWUgYW5kIHJl dHVybiBzdHJpbmcgZGVzY3JpYmluZyBjb21wbGV0aW9uIGNvZGUuCj4gCj4gU2lnbmVkLW9mZi1i eTogUGF3ZWwgTGFzemN6YWsgPHBhd2VsbEBjYWRlbmNlLmNvbT4KPiAtLS0KPiAgZHJpdmVycy91 c2IvdXNic3NwL2dhZGdldC5oIHwgNTgwICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKwo+ICAxIGZpbGUgY2hhbmdlZCwgNTgwIGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy91c2IvdXNic3NwL2dhZGdldC5oIGIvZHJpdmVycy91c2IvdXNic3NwL2dhZGdl dC5oCj4gaW5kZXggNDllNzI3MTE4N2NjLi5iNWMxNzYwM2FmNzggMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy91c2IvdXNic3NwL2dhZGdldC5oCj4gKysrIGIvZHJpdmVycy91c2IvdXNic3NwL2dhZGdl dC5oCj4gQEAgLTkzMCw2ICs5MzAsNzMgQEAgc3RydWN0IHVzYnNzcF90cmFuc2Zlcl9ldmVudCB7 Cj4gICNkZWZpbmUgQ09NUF9VTkRFRklORURfRVJST1IJCQkzMwo+ICAjZGVmaW5lIENPTVBfSU5W QUxJRF9TVFJFQU1fSURfRVJST1IJCTM0Cj4gIAo+ICtzdGF0aWMgaW5saW5lIGNvbnN0IGNoYXIg KnVzYnNzcF90cmJfY29tcF9jb2RlX3N0cmluZyh1OCBzdGF0dXMpCgo8c25pcD4KCgpZb3UgaGF2 ZSBfZ2lhbnRfIGlubGluZSBmdW5jdGlvbnMgaGVyZSwgd2h5PwoKUGxlYXNlIGp1c3QgcHV0IHRo aXMgYWxsIGluIGEgLmMgZmlsZSBhbmQgbGV0IHRoZSBsaW5rZXIgcHJvcGVybHkgaGFuZGxlCnRo aW5ncy4gIFlvdSBkbyBub3Qgd2FudCB0byBkdXBsaWNhdGUgYWxsIG9mIHRoZXNlIGNyYXp5IHN0 cmluZ3MgYWxsCm92ZXIgdGhlIHBsYWNlIHdoZXJlIGV2ZXIgeW91IGNhbGwgdGhlc2UgZnVuY3Rp b25zLgoKQW5kIEkgYW0gZ3Vlc3NpbmcgdGhpcyBpcyBvbmx5IGZvciBzb21lIHNvcnQgb2YgImRl YnVnZ2luZyIgbW9kZT8gIElmCnNvLCBzaG91bGRuJ3QgdGhlcmUgYmUgYSB3YXkgdG8gbm90IGV2 ZW4gYnVpbGQgdGhpcyBpbj8gIFNvbWUgc3lzdGVtcwphcmUgdmVyeSBzcGFjZSBjb25zdHJhaW5l ZC4uLgoKdGhhbmtzLAoKZ3JlZyBrLWgK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92647C433F5 for ; Mon, 10 Sep 2018 18:19:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4CDDE20854 for ; Mon, 10 Sep 2018 18:19:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4CDDE20854 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728430AbeIJXOU (ORCPT ); Mon, 10 Sep 2018 19:14:20 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:43778 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726657AbeIJXOT (ORCPT ); Mon, 10 Sep 2018 19:14:19 -0400 Received: from localhost (ip-213-127-74-90.ip.prioritytelecom.net [213.127.74.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 37C66C93; Mon, 10 Sep 2018 18:18:59 +0000 (UTC) Date: Mon, 10 Sep 2018 20:18:56 +0200 From: Greg Kroah-Hartman To: Pawel Laszczak Cc: linux-usb@vger.kernel.org, Felipe Balbi , linux-kernel@vger.kernel.org, ltyrala@cadence.com, adouglas@cadence.com Subject: Re: [PATCH 02/31] usb: usbssp: Added some decoding functions. Message-ID: <20180910181856.GB6019@kroah.com> References: <1532023084-28083-1-git-send-email-pawell@cadence.com> <1532023084-28083-3-git-send-email-pawell@cadence.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1532023084-28083-3-git-send-email-pawell@cadence.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 19, 2018 at 06:57:35PM +0100, Pawel Laszczak wrote: > This patch add additional functions that converts some fields to string. > > For example function usbssp_trb_comp_code_string take completion > code value and return string describing completion code. > > Signed-off-by: Pawel Laszczak > --- > drivers/usb/usbssp/gadget.h | 580 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 580 insertions(+) > > diff --git a/drivers/usb/usbssp/gadget.h b/drivers/usb/usbssp/gadget.h > index 49e7271187cc..b5c17603af78 100644 > --- a/drivers/usb/usbssp/gadget.h > +++ b/drivers/usb/usbssp/gadget.h > @@ -930,6 +930,73 @@ struct usbssp_transfer_event { > #define COMP_UNDEFINED_ERROR 33 > #define COMP_INVALID_STREAM_ID_ERROR 34 > > +static inline const char *usbssp_trb_comp_code_string(u8 status) You have _giant_ inline functions here, why? Please just put this all in a .c file and let the linker properly handle things. You do not want to duplicate all of these crazy strings all over the place where ever you call these functions. And I am guessing this is only for some sort of "debugging" mode? If so, shouldn't there be a way to not even build this in? Some systems are very space constrained... thanks, greg k-h