From: Rob Herring <robh@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: lee.jones@linaro.org, broonie@kernel.org, mark.rutland@arm.com,
lgirdwood@gmail.com, bgoswami@codeaurora.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
vkoul@kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH v3 10/13] ASoC: dt-bindings: Add WCD9335 MBHC specific properties
Date: Mon, 10 Sep 2018 15:06:53 -0500 [thread overview]
Message-ID: <20180910200652.GA20896@bogus> (raw)
In-Reply-To: <20180904102500.30318-11-srinivas.kandagatla@linaro.org>
On Tue, Sep 04, 2018 at 11:24:57AM +0100, Srinivas Kandagatla wrote:
> This patch add new bindings required to support MBHC
> (Multi Button Headset Control) block in the codec.
> This block is used for jack insert/removal detection,
> headset type detection and 8 button press/release events.
>
> All these properties are very much specific to board.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> .../bindings/sound/qcom,wcd9335.txt | 20 +++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt b/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt
> index 5d6ea66a863f..4d56c3ca9fa8 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt
> +++ b/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt
> @@ -55,6 +55,26 @@ Required properties with SLIMbus Interface:
> Value type: <string>
> Definition: Must contain "mclk", "mclk2" and "slimbus" strings.
>
> +- qcom,mbhc-vthreshold:
Needs unit suffix.
> + Usage: Optional, only required if headset button support required.
> + Value type: <u32 array>
> + Definition: Must contain an array of 8 threshold voltages in mV for
> + 8 buttons detection on headset.
> +
> +- qcom,hphl-jack-type-normally-open:
> + Usage: Optional, only required if headset button support required.
It's not required if the pin is NC, right?
> + Value type: <boolean>
> + Definition: present if hphl pin on jack is a NO (Normally Open).
> + If not specified, then its assumed that hphl pin on jack
> + is NC (Normally Closed).
Is the not specified case the more common case? If not, it should be.
> +
> +- qcom,gnd-jack-type-normally-open:
> + Usage: Optional, only required if headset button support required.
Same here.
> + Value type: <boolean>
> + Definition: present if gnd pin on jack is NO (Normally Open).
> + If not specified, then its assumed that gnd pin on
> + jack is NC (Normally Closed).
> +
> - vdd-buck-supply:
> Usage: required
> Value type: <phandle>
> --
> 2.18.0
>
next prev parent reply other threads:[~2018-09-10 20:06 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-04 10:24 [PATCH v3 00/13] ASoC: Add support to WCD9335 Audio Codec Srinivas Kandagatla
2018-09-04 10:24 ` [PATCH v3 01/13] ASoC: dt-bindings: update wcd9335 bindings Srinivas Kandagatla
2018-09-04 10:24 ` Srinivas Kandagatla
2018-09-10 20:02 ` Rob Herring
2018-09-10 20:02 ` Rob Herring
2018-09-04 10:24 ` [PATCH v3 02/13] mfd: wcd9335: add support to wcd9335 core Srinivas Kandagatla
2018-09-11 15:33 ` Lee Jones
2018-09-12 7:23 ` Srinivas Kandagatla
2018-09-12 8:58 ` Lee Jones
2018-09-12 9:32 ` Srinivas Kandagatla
2018-09-12 10:59 ` Lee Jones
2018-09-12 11:11 ` Srinivas Kandagatla
2018-09-12 11:46 ` Lee Jones
2018-09-12 12:43 ` Srinivas Kandagatla
2018-09-17 1:08 ` Lee Jones
2018-09-04 10:24 ` [PATCH v3 03/13] mfd: wcd9335: add wcd irq support Srinivas Kandagatla
2018-09-04 10:24 ` Srinivas Kandagatla
2018-09-11 15:35 ` Lee Jones
2018-09-11 15:35 ` Lee Jones
2018-09-04 10:24 ` [PATCH v3 04/13] ASoC: wcd9335: add support to wcd9335 codec Srinivas Kandagatla
2018-09-04 10:24 ` Srinivas Kandagatla
2018-09-04 10:24 ` [PATCH v3 05/13] ASoC: wcd9335: add CLASS-H Controller support Srinivas Kandagatla
2018-09-04 10:24 ` Srinivas Kandagatla
2018-09-04 10:24 ` [PATCH v3 06/13] ASoC: wcd9335: add basic controls Srinivas Kandagatla
2018-09-04 10:24 ` [PATCH v3 07/13] ASoC: wcd9335: add playback dapm widgets Srinivas Kandagatla
2018-09-04 10:24 ` [PATCH v3 08/13] ASoC: wcd9335: add capture " Srinivas Kandagatla
2018-09-04 10:24 ` [PATCH v3 09/13] ASoC: wcd9335: add audio routings Srinivas Kandagatla
2018-09-04 10:24 ` [PATCH v3 10/13] ASoC: dt-bindings: Add WCD9335 MBHC specific properties Srinivas Kandagatla
2018-09-10 20:06 ` Rob Herring [this message]
2018-09-12 7:44 ` Srinivas Kandagatla
2018-09-04 10:24 ` [PATCH v3 11/13] ASoC: wcd9335: add mbhc support Srinivas Kandagatla
2018-09-04 10:24 ` [PATCH v3 12/13] ASoC: apq8096: add slim support Srinivas Kandagatla
2018-09-10 8:24 ` kbuild test robot
2018-09-10 8:24 ` kbuild test robot
2018-09-04 10:25 ` [PATCH v3 13/13] ASoC: apq8096: add headset JACK support Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180910200652.GA20896@bogus \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.