All of lore.kernel.org
 help / color / mirror / Atom feed
* usb: core: fix compile warning
@ 2018-09-11  7:54 ` Gustavo A. R. Silva
  0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2018-09-11  7:54 UTC (permalink / raw)
  To: Sebastian Andrzej Siewior, Greg Kroah-Hartman
  Cc: linux-usb, linux-kernel, Gustavo A. R. Silva

Fix the following compile warning:

warning: unused variable ‘flags’ [-Wunused-variable]
  unsigned long flags;

Fixes: ed194d136769 ("usb: core: remove local_irq_save() around ->complete() handler")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 drivers/usb/core/hcd.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index f985d23..487025d 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -1738,7 +1738,6 @@ static void __usb_hcd_giveback_urb(struct urb *urb)
 	struct usb_hcd *hcd = bus_to_hcd(urb->dev->bus);
 	struct usb_anchor *anchor = urb->anchor;
 	int status = urb->unlinked;
-	unsigned long flags;
 
 	urb->hcpriv = NULL;
 	if (unlikely((urb->transfer_flags & URB_SHORT_NOT_OK) &&

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] usb: core: fix compile warning
@ 2018-09-11  7:54 ` Gustavo A. R. Silva
  0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2018-09-11  7:54 UTC (permalink / raw)
  To: Sebastian Andrzej Siewior, Greg Kroah-Hartman
  Cc: linux-usb, linux-kernel, Gustavo A. R. Silva

Fix the following compile warning:

warning: unused variable ‘flags’ [-Wunused-variable]
  unsigned long flags;

Fixes: ed194d136769 ("usb: core: remove local_irq_save() around ->complete() handler")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 drivers/usb/core/hcd.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index f985d23..487025d 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -1738,7 +1738,6 @@ static void __usb_hcd_giveback_urb(struct urb *urb)
 	struct usb_hcd *hcd = bus_to_hcd(urb->dev->bus);
 	struct usb_anchor *anchor = urb->anchor;
 	int status = urb->unlinked;
-	unsigned long flags;
 
 	urb->hcpriv = NULL;
 	if (unlikely((urb->transfer_flags & URB_SHORT_NOT_OK) &&
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] usb: core: fix compile warning
  2018-09-11  7:54 ` [PATCH] " Gustavo A. R. Silva
  (?)
@ 2018-09-11  8:06 ` Greg Kroah-Hartman
  -1 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2018-09-11  8:06 UTC (permalink / raw)
  To: Gustavo A. R. Silva; +Cc: Sebastian Andrzej Siewior, linux-usb, linux-kernel

On Tue, Sep 11, 2018 at 02:54:13AM -0500, Gustavo A. R. Silva wrote:
> Fix the following compile warning:
> 
> warning: unused variable ‘flags’ [-Wunused-variable]
>   unsigned long flags;
> 
> Fixes: ed194d136769 ("usb: core: remove local_irq_save() around ->complete() handler")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
>  drivers/usb/core/hcd.c | 1 -
>  1 file changed, 1 deletion(-)

I can't believe I missed this :(

Someone else sent this right before you, I'll add your s-o-b to that
patch as well.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-09-11  8:06 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-11  7:54 usb: core: fix compile warning Gustavo A. R. Silva
2018-09-11  7:54 ` [PATCH] " Gustavo A. R. Silva
2018-09-11  8:06 ` Greg Kroah-Hartman

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.