All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] python-numpy: fix make legal-info failure
Date: Tue, 11 Sep 2018 08:44:57 +0200	[thread overview]
Message-ID: <20180911084457.4a6b467b@windsurf> (raw)
In-Reply-To: <20180910222744.82143-3-giulio.benetti@micronovasrl.com>

Hello,

On Tue, 11 Sep 2018 00:27:44 +0200, Giulio Benetti wrote:
> Release 1.15.1 tarball doesn't contain all sublibraries license files
> listed in the base LICENSE.txt file.
> This makes python-numpy-legal-info incomplete.
> 
> Add patch to add missing sublibraries license files:
> - numpy/linalg/lapack_lite/LICENSE.txt
> - tools/npy_tempita/license.txt
> and therefore their sha256 into hash file.
> Update also PYTHON_NUMPY_LICENSE adding:
> BSD-2-Clause PSF Apache-2.0 MIT Zlib
> 
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>

Why is this change titled "fix make legal-info failure" ? PATCH 1/2
does fix a legal-info failure, this one adds more detailed legal
information.


> diff --git a/package/python-numpy/python-numpy.hash b/package/python-numpy/python-numpy.hash
> index 7c7f446118..9df9f63f06 100644
> --- a/package/python-numpy/python-numpy.hash
> +++ b/package/python-numpy/python-numpy.hash
> @@ -2,3 +2,7 @@
>  sha256	3c1ccce5d935ef8df16ae0595b459ef08a5cdb05aee195ebc04b9d89a72be7fa	numpy-1.15.1.tar.gz
>  # License files, locally calculated
>  sha256	9e85ee1c3f11444243c9b7667721592a01f1cd90cb28ad937ac99f6241d6b685	LICENSE.txt
> +sha256	426a5a484480f57a295db48c2c04f47bb3274752dd82a7fd6541dfa2cb90f641	doc/sphinxext/LICENSE.txt

What about:

  doc/scipy-sphinx-theme/LICENSE.txt

In fact, the main LICENSE.txt itself, has a bug. Look:

"""
Name: Numpydoc
Files: doc/sphinxext/numpydoc/*
License: 2-clause BSD
  For details, see doc/sphinxext/LICENSE.txt

Name: scipy-sphinx-theme
Files: doc/scipy-sphinx-theme/*
License: 3-clause BSD, PSF and Apache 2.0
  For details, see doc/sphinxext/LICENSE.txt
"""

See how the path for the "scipy-spinx-theme" license file is wrong ?

> +PYTHON_NUMPY_LICENSE = BSD-3-Clause BSD-2-Clause PSF Apache-2.0 MIT Zlib

It should be comma-separated.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-09-11  6:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-10 22:27 [Buildroot] [PATCH 0/2] python-numpy: update package licensing Giulio Benetti
2018-09-10 22:27 ` [Buildroot] [PATCH 1/2] python-numpy: correct LICENSE.txt hash value Giulio Benetti
2018-09-10 22:27 ` [Buildroot] [PATCH 2/2] python-numpy: fix make legal-info failure Giulio Benetti
2018-09-11  6:44   ` Thomas Petazzoni [this message]
2018-09-11 12:45     ` Giulio Benetti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180911084457.4a6b467b@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.