From: Stephen Hemminger <stephen@networkplumber.org>
To: Igor Russkikh <igor.russkikh@aquantia.com>
Cc: dev@dpdk.org, pavel.belous@aquantia.com,
Nadezhda.Krupnina@aquantia.com, Simon.Edelhaus@aquantia.com,
Corey Melton <comelton@cisco.com>,
Ashish Kumar <ashishk2@cisco.com>
Subject: Re: [PATCH 04/21] net/atlantic: hw_atl register declarations
Date: Tue, 11 Sep 2018 10:04:01 -0700 [thread overview]
Message-ID: <20180911100402.581bdba9@xeon-e3> (raw)
In-Reply-To: <1536333719-32155-5-git-send-email-igor.russkikh@aquantia.com>
On Fri, 7 Sep 2018 18:21:42 +0300
Igor Russkikh <igor.russkikh@aquantia.com> wrote:
> +/* register address for bitfield imr_rx{r}_en */
> + static u32 itr_imr_rxren_adr[32] = {
> + 0x00002100U, 0x00002100U, 0x00002104U, 0x00002104U,
> + 0x00002108U, 0x00002108U, 0x0000210CU, 0x0000210CU,
> + 0x00002110U, 0x00002110U, 0x00002114U, 0x00002114U,
> + 0x00002118U, 0x00002118U, 0x0000211CU, 0x0000211CU,
> + 0x00002120U, 0x00002120U, 0x00002124U, 0x00002124U,
> + 0x00002128U, 0x00002128U, 0x0000212CU, 0x0000212CU,
> + 0x00002130U, 0x00002130U, 0x00002134U, 0x00002134U,
> + 0x00002138U, 0x00002138U, 0x0000213CU, 0x0000213CU
> + };
> +
Don't you want to make these data tables const?
next prev parent reply other threads:[~2018-09-11 17:04 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 15:21 [PATCH 00/21] net/atlantic: Aquantia aQtion 10G NIC Family DPDK PMD driver Igor Russkikh
2018-09-07 15:21 ` [PATCH 01/21] net/atlantic: atlantic PMD driver skeleton Igor Russkikh
2018-09-11 17:02 ` Stephen Hemminger
2018-09-12 11:49 ` Igor Russkikh
2018-09-07 15:21 ` [PATCH 02/21] net/atlantic: documentation and rel notes Igor Russkikh
2018-09-07 15:21 ` [PATCH 03/21] net/atlantic: logging macroes and some typedefs Igor Russkikh
2018-09-07 15:21 ` [PATCH 04/21] net/atlantic: hw_atl register declarations Igor Russkikh
2018-09-11 17:04 ` Stephen Hemminger [this message]
2018-09-07 15:21 ` [PATCH 05/21] net/atlantic: b0 hardware layer main logic Igor Russkikh
2018-09-11 17:04 ` Stephen Hemminger
2018-09-11 17:05 ` Stephen Hemminger
2018-09-07 15:21 ` [PATCH 06/21] net/atlantic: firmware operations layer Igor Russkikh
2018-09-07 15:21 ` [PATCH 07/21] net/atlantic: hardware register access routines Igor Russkikh
2018-09-24 6:29 ` Hemant
2018-09-24 9:00 ` Igor Russkikh
2018-09-07 15:21 ` [PATCH 08/21] net/atlantic: rte device start, stop, initial configuration Igor Russkikh
2018-09-07 15:21 ` [PATCH 09/21] net/atlantic: link status and interrupt management Igor Russkikh
2018-09-07 15:21 ` [PATCH 10/21] net/atlantic: add hw adapter structures and defines Igor Russkikh
2018-09-07 15:21 ` [PATCH 11/21] net/atlantic: RSS and RETA manipulation API Igor Russkikh
2018-09-07 15:21 ` [PATCH 12/21] net/atlantic: flow control configuration Igor Russkikh
2018-09-07 15:21 ` [PATCH 13/21] net/atlantic: MAC address manipulations Igor Russkikh
2018-09-07 15:21 ` [PATCH 14/21] net/atlantic: eeprom and register manipulation routines Igor Russkikh
2018-09-07 15:21 ` [PATCH 15/21] net/atlantic: LED control DPDK and private APIs Igor Russkikh
2018-09-07 15:21 ` [PATCH 16/21] net/atlantic: promisc and allmulti configuration Igor Russkikh
2018-09-07 15:21 ` [PATCH 17/21] net/atlantic: device statistics, xstats Igor Russkikh
2018-09-11 17:06 ` Stephen Hemminger
2018-09-07 15:21 ` [PATCH 18/21] net/atlantic: VLAN filters and offloads Igor Russkikh
2018-09-07 15:21 ` [PATCH 19/21] net/atlantic: device MTU and statuses Igor Russkikh
2018-09-07 15:21 ` [PATCH 20/21] net/atlantic: RX side structures and implementation Igor Russkikh
2018-09-07 15:21 ` [PATCH 21/21] net/atlantic: TX " Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180911100402.581bdba9@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=Nadezhda.Krupnina@aquantia.com \
--cc=Simon.Edelhaus@aquantia.com \
--cc=ashishk2@cisco.com \
--cc=comelton@cisco.com \
--cc=dev@dpdk.org \
--cc=igor.russkikh@aquantia.com \
--cc=pavel.belous@aquantia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.