From: Segher Boessenkool <segher@kernel.crashing.org>
To: Joel Stanley <joel@jms.id.au>
Cc: linuxppc-dev@lists.ozlabs.org, Anton Blanchard <anton@ozlabs.org>
Subject: Re: [PATCH 1/2] powerpc/boot: Fix crt0.S syntax for clang
Date: Tue, 11 Sep 2018 06:32:28 -0500 [thread overview]
Message-ID: <20180911113228.GF23155@gate.crashing.org> (raw)
In-Reply-To: <20180910085714.4834-2-joel@jms.id.au>
On Mon, Sep 10, 2018 at 06:57:13PM +1000, Joel Stanley wrote:
> Clang's assembler does not like the syntax of the cmpdi:
>
> arch/powerpc/boot/crt0.S:168:22: error: unexpected modifier on variable reference
> cmpdi 12,RELACOUNT@l
> ^
> arch/powerpc/boot/crt0.S:168:11: error: unknown operand
> cmpdi 12,RELACOUNT@l
> ^
> Enclosing RELACOUNT in () makes it is happy. Tested with GCC 8 and Clang
> 8 (trunk).
Is clang going to fix this? You also might want to add a comment that
this is a workaround for that broken assembler.
Segher
next prev parent reply other threads:[~2018-09-11 11:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 8:57 [PATCH 0/2] powerpc: Clang build fixes Joel Stanley
2018-09-10 8:57 ` [PATCH 1/2] powerpc/boot: Fix crt0.S syntax for clang Joel Stanley
2018-09-11 11:32 ` Segher Boessenkool [this message]
2018-09-14 2:55 ` Joel Stanley
2018-09-10 8:57 ` [PATCH 2/2] powerpc/boot: Ensure _zimage_start is a weak symbol Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180911113228.GF23155@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=anton@ozlabs.org \
--cc=joel@jms.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.