From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/fail2ban: new package
Date: Tue, 11 Sep 2018 11:52:22 +0200 [thread overview]
Message-ID: <20180911115222.1d19d460@windsurf> (raw)
In-Reply-To: <CAGm1_kvvnnveBE1Ccpj7X6TmBW-coe7xgtCYLAXtjhEsPv4ikQ@mail.gmail.com>
Hello,
On Tue, 11 Sep 2018 11:47:36 +0200, Yegor Yefremov wrote:
> > and ditto for the staging installation, of course. Yegor, do you see
> > any drawback with doing this change in pkg-python.mk ? To me, it seems
> > like the right thing to do, and would avoid the need to have a special
> > case in fail2ban.mk.
>
> I've applied this hack:
Why do you say "hack" ? It should be the right thing, compared to what
we're doing today.
> diff --git a/package/pkg-python.mk b/package/pkg-python.mk
> index f57e486dad..fcb7309ef9 100644
> --- a/package/pkg-python.mk
> +++ b/package/pkg-python.mk
> @@ -66,10 +66,10 @@ PKG_PYTHON_SETUPTOOLS_ENV = \
> _python_exec_prefix=/usr
>
> PKG_PYTHON_SETUPTOOLS_INSTALL_TARGET_OPTS = \
> - --prefix=$(TARGET_DIR)/usr \
> + --prefix=/usr \
> --executable=/usr/bin/python \
> --single-version-externally-managed \
> - --root=/
> + --root=$(TARGET_DIR)
>
> PKG_PYTHON_SETUPTOOLS_INSTALL_STAGING_OPTS = \
> --prefix=$(STAGING_DIR)/usr \
It should also be fixed in the staging installation commands, which
have the same problem.
> And performed some tests with following packages (both via python
> "console" and using packe own scripts like watchmedo or miniterm.py):
>
> python-serial, python-watchdog, python-cryptography, python-pytablewriter
>
> So far I haven't experienced any issues.
Great, thanks for doing this test! I think it would be a nice thing to
fix.
Angelo: just curious, for fail2ban, what made you realize you had to
override the --prefix and --root values ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-09-11 9:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 13:41 [Buildroot] [PATCH v2] package/fail2ban: new package Angelo Compagnucci
2018-09-10 22:05 ` Thomas Petazzoni
2018-09-11 9:47 ` Yegor Yefremov
2018-09-11 9:52 ` Thomas Petazzoni [this message]
2018-09-11 9:58 ` Angelo Compagnucci
2018-11-24 23:27 ` Angelo Compagnucci
2018-11-30 8:54 ` Yegor Yefremov
2018-11-30 9:14 ` Angelo Compagnucci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180911115222.1d19d460@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.