From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 02/18] perl-dbd-mysql: new package
Date: Tue, 11 Sep 2018 15:42:42 +0200 [thread overview]
Message-ID: <20180911154242.6d46b475@windsurf> (raw)
In-Reply-To: <20180820115519.24046-3-chrismcc@gmail.com>
Hello,
On Mon, 20 Aug 2018 04:55:03 -0700, Christopher McCrory wrote:
> Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
> ---
> DEVELOPERS | 1 +
> package/Config.in | 1 +
> package/perl-dbd-mysql/Config.in | 12 ++++++++++++
> package/perl-dbd-mysql/perl-dbd-mysql.hash | 6 ++++++
> package/perl-dbd-mysql/perl-dbd-mysql.mk | 15 +++++++++++++++
> 5 files changed, 35 insertions(+)
> create mode 100644 package/perl-dbd-mysql/Config.in
> create mode 100644 package/perl-dbd-mysql/perl-dbd-mysql.hash
> create mode 100644 package/perl-dbd-mysql/perl-dbd-mysql.mk
I've applied, but there was a mistake in the patch, see below.
> diff --git a/package/perl-dbd-mysql/Config.in b/package/perl-dbd-mysql/Config.in
> new file mode 100644
> index 0000000000..49e7ff99d6
> --- /dev/null
> +++ b/package/perl-dbd-mysql/Config.in
> @@ -0,0 +1,12 @@
> +config BR2_PACKAGE_PERL_DBD_MYSQL
> + bool "perl-dbd-mysql"
> + depends on !BR2_STATIC_LIBS
> + select BR2_PACKAGE_PERL_DBI
> + select BR2_PACKAGE_MYSQL
You select BR2_PACKAGE_MYSQL without replicating its dependencies:
BR2_USE_MMU, BR2_TOOLCHAIN_HAS_THREADS and BR2_INSTALL_LIBSTDCPP. While
BR2_USE_MMU is guaranteed to be true because perl itself cannot be
enabled if !BR2_USE_MMU, there is nothing that guarantees
BR2_INSTALL_LIBSTDCPP and BR2_TOOLCHAIN_HAS_THREADS are true.
I fixed that by adding the appropriate dependencies, and adjusting the
Config.in comment accordingly.
> +PERL_DBD_MYSQL_VERSION = 4.046
> +PERL_DBD_MYSQL_SOURCE = DBD-mysql-$(PERL_DBD_MYSQL_VERSION).tar.gz
> +PERL_DBD_MYSQL_SITE = $(BR2_CPAN_MIRROR)/authors/id/C/CA/CAPTTOFU
> +PERL_DBD_MYSQL_DEPENDENCIES = host-perl-dbi perl-dbi mysql
> +PERL_DBD_MYSQL_CONF_OPTS += --mysql_config=$(STAGING_DIR)/usr/bin/mysql_config
Minor nit: the += here isn't really needed, a = was sufficient.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-09-11 13:42 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-20 11:55 [Buildroot] [PATCH 00/13] perl modules again Christopher McCrory
2018-08-20 11:55 ` [Buildroot] [PATCH 01/18] perl-dbi: add host package Christopher McCrory
2018-08-21 13:16 ` François Perrad
2018-09-11 13:40 ` Thomas Petazzoni
2018-08-20 11:55 ` [Buildroot] [PATCH 02/18] perl-dbd-mysql: new package Christopher McCrory
2018-08-21 13:16 ` François Perrad
2018-09-11 13:42 ` Thomas Petazzoni [this message]
2018-08-20 11:55 ` [Buildroot] [PATCH 03/18] perl-data-dump: " Christopher McCrory
2018-08-21 6:19 ` François Perrad
2018-09-12 19:43 ` Thomas Petazzoni
2018-08-20 11:55 ` [Buildroot] [PATCH 04/18] perl-time-parsedate: " Christopher McCrory
2018-08-20 11:59 ` Thomas Petazzoni
2018-08-20 12:12 ` Christopher McCrory
2018-08-20 12:27 ` Thomas Petazzoni
2018-08-20 12:41 ` Christopher McCrory
2018-09-12 20:26 ` Thomas Petazzoni
2018-08-20 11:55 ` [Buildroot] [PATCH 05/18] perl-x10: " Christopher McCrory
2018-08-21 6:23 ` François Perrad
2018-09-12 20:44 ` Thomas Petazzoni
2018-08-20 11:55 ` [Buildroot] [PATCH 06/18] perl-sys-cpu: " Christopher McCrory
2018-08-21 6:35 ` François Perrad
2018-09-12 20:53 ` Thomas Petazzoni
2018-08-20 11:55 ` [Buildroot] [PATCH 07/18] perl-dist-checkconflicts: " Christopher McCrory
2018-08-21 6:40 ` François Perrad
2018-09-12 20:55 ` Thomas Petazzoni
2018-08-20 11:55 ` [Buildroot] [PATCH 08/18] perl-package-stash: " Christopher McCrory
2018-08-21 6:42 ` François Perrad
2018-09-12 21:02 ` Thomas Petazzoni
2018-08-20 11:55 ` [Buildroot] [PATCH 09/18] perl-class-load: " Christopher McCrory
2018-08-21 6:43 ` François Perrad
2018-09-12 21:06 ` Thomas Petazzoni
2018-08-20 11:55 ` [Buildroot] [PATCH 10/18] perl-template-toolkit: " Christopher McCrory
2018-08-20 11:55 ` [Buildroot] [PATCH 11/18] perl-xml-parser: " Christopher McCrory
2018-08-20 11:55 ` [Buildroot] [PATCH 12/18] perl-soap-wsdl: " Christopher McCrory
2018-09-12 21:35 ` Thomas Petazzoni
2018-08-20 11:55 ` [Buildroot] [PATCH 13/18] perl-time-parsedate: add license Christopher McCrory
2018-08-20 11:55 ` [Buildroot] [PATCH 14/18] perl-termreadkey: new package Christopher McCrory
2018-08-22 17:00 ` Christopher McCrory
2018-08-20 11:55 ` [Buildroot] [PATCH 15/18] pkg-utils.mk: patch_sub_makefile Christopher McCrory
2018-09-12 21:15 ` Thomas Petazzoni
2018-09-12 21:33 ` Thomas Petazzoni
2018-08-20 11:55 ` [Buildroot] [PATCH 16/18] perl-template-toolkit: use new patch_sub_makefile Christopher McCrory
2018-08-20 11:55 ` [Buildroot] [PATCH 17/18] perl-xml-parser: " Christopher McCrory
2018-08-20 11:55 ` [Buildroot] [PATCH 18/18] perl-soap-wsdl: add dependancy on perl-termreadkey Christopher McCrory
2018-08-22 17:01 ` Christopher McCrory
2018-08-20 12:10 ` [Buildroot] [PATCH 00/13] perl modules again Thomas Petazzoni
2018-08-20 12:15 ` Christopher McCrory
2018-08-20 12:28 ` Thomas Petazzoni
2018-08-20 12:47 ` Christopher McCrory
2018-09-12 21:42 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180911154242.6d46b475@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.