From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH] net: dsa: mv88e6xxx: Add MV88E6352 DT compatible Date: Wed, 12 Sep 2018 02:46:02 +0200 Message-ID: <20180912004602.GA14588@lunn.ch> References: <20180911221536.12993-1-marex@denx.de> <20180911231246.GB11474@lunn.ch> <20180911233251.GE11474@lunn.ch> <30900c22-1717-c907-7129-f2dcb90bbc6c@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org To: Marek Vasut Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:59702 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727735AbeILFr4 (ORCPT ); Wed, 12 Sep 2018 01:47:56 -0400 Content-Disposition: inline In-Reply-To: <30900c22-1717-c907-7129-f2dcb90bbc6c@denx.de> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Sep 12, 2018 at 02:04:54AM +0200, Marek Vasut wrote: > On 09/12/2018 01:32 AM, Andrew Lunn wrote: > >> compatible = "marvell,mv88e6352", "marvell,mv88e6085"; > > > > Just "marvell,mv88e6085"; > > > > Please take a look at all the other DT files using the Marvell > > chips. You will only ever find "marvell,mv88e6085" or > > "marvell,mv88e6190", because everything is compatible to one of these > > two. > > Well, until you find a difference between those chips which you cannot > discern based solely on the ID register content. Then it's better to > have a compatible to match on which matches the actual chip. Hi Marek We have been around this loop before. The problem with putting in a more specific compatible is that nothing is validating it. So it is going to be wrong, simple because people cut/paste, and don't necessary change it. So when we do need to look at it, we cannot look at it, because it is wrong. I would only add a more specific compatible if and when we need it, it is actually used, and we can verify it is correct. Andrew