From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: netdev@vger.kernel.org, jaswinder.singh@linaro.org,
ard.biesheuvel@linaro.org, masami.hiramatsu@linaro.org,
arnd@arndb.de, mykyta.iziumtsev@linaro.org,
bjorn.topel@intel.com, magnus.karlsson@intel.com,
daniel@iogearbox.net, ast@kernel.org
Subject: Re: [net-next, PATCH 2/2, v2] net: socionext: add XDP support
Date: Wed, 12 Sep 2018 12:29:15 +0300 [thread overview]
Message-ID: <20180912092915.GA31978@apalos> (raw)
In-Reply-To: <20180912112524.34250d1c@redhat.com>
On Wed, Sep 12, 2018 at 11:25:24AM +0200, Jesper Dangaard Brouer wrote:
> On Wed, 12 Sep 2018 12:02:38 +0300
> Ilias Apalodimas <ilias.apalodimas@linaro.org> wrote:
>
> > static const struct net_device_ops netsec_netdev_ops = {
> > .ndo_init = netsec_netdev_init,
> > .ndo_uninit = netsec_netdev_uninit,
> > @@ -1430,6 +1627,7 @@ static const struct net_device_ops netsec_netdev_ops = {
> > .ndo_set_mac_address = eth_mac_addr,
> > .ndo_validate_addr = eth_validate_addr,
> > .ndo_do_ioctl = netsec_netdev_ioctl,
> > + .ndo_bpf = netsec_xdp,
> > };
> >
>
> You have not implemented ndo_xdp_xmit.
>
> Thus, you have "only" implemented the RX side of XDP_REDIRECT. Which
> allows you to do, cpumap and AF_XDP redirects, but not allowing other
> drivers to XDP send out this device.
Correct, that was the planning, is ndo_xdp_xmit() needed for the patch or
is the patch message just misleading and i should change that ?
Thanks
/Ilias
next prev parent reply other threads:[~2018-09-12 14:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 9:02 [net-next, PATCH 0/2, v2] net: socionext: add XDP support Ilias Apalodimas
2018-09-12 9:02 ` [net-next, PATCH 1/2, v2] net: socionext: different approach on DMA Ilias Apalodimas
2018-09-12 9:02 ` [net-next, PATCH 2/2, v2] net: socionext: add XDP support Ilias Apalodimas
2018-09-12 9:14 ` Jesper Dangaard Brouer
2018-09-12 9:20 ` Ilias Apalodimas
2018-09-12 9:28 ` Björn Töpel
2018-09-12 9:25 ` Jesper Dangaard Brouer
2018-09-12 9:29 ` Ilias Apalodimas [this message]
2018-09-13 14:32 ` Jesper Dangaard Brouer
2018-09-13 15:36 ` Ilias Apalodimas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180912092915.GA31978@apalos \
--to=ilias.apalodimas@linaro.org \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=ast@kernel.org \
--cc=bjorn.topel@intel.com \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=jaswinder.singh@linaro.org \
--cc=magnus.karlsson@intel.com \
--cc=masami.hiramatsu@linaro.org \
--cc=mykyta.iziumtsev@linaro.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.