From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] syscalls/statx05: Fix test on ppc64le
Date: Wed, 12 Sep 2018 11:52:47 +0200 [thread overview]
Message-ID: <20180912095247.GA29460@rei> (raw)
In-Reply-To: <831588265.47297951.1536741222106.JavaMail.zimbra@redhat.com>
Hi!
> It's not easy to guess what role library plays, when only needs_device is
> used, but you set also dev_fs_type and mntpoint. If you dropped both,
> then all needed would be to MKDIR/RMDIR(mntpoint), correct?
I also use the tst_device->fs_type instead of doing #define FSTYPE
"ext4".
And in a case that some other filesystem gains encryption support we
will need a way how generate the mkfs options dynamically based on the
filesystem type anyway, so I suppose that the extra opts in tst_test
will end up being a callback that will generate the data just before we
do mkfs. However I wanted to make minimal amount of changes to fix the
test for now as we are approaching the release. I can redesign the mkfs
options later on.
> Anyway, ACK to both patches.
Both pushed, thanks.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2018-09-12 9:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-11 15:30 [LTP] [PATCH 1/2] lib: tst_mkfs: Allow passing more extra options Cyril Hrubis
2018-09-11 15:30 ` [LTP] [PATCH 2/2] syscalls/statx05: Fix test on ppc64le Cyril Hrubis
2018-09-12 8:33 ` Jan Stancek
2018-09-12 9:52 ` Cyril Hrubis [this message]
2018-09-12 12:28 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180912095247.GA29460@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.