From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-renesas-soc-owner@vger.kernel.org>
Received: from kirsty.vergenet.net ([202.4.237.240]:43294 "EHLO
        kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726672AbeILP3b (ORCPT
        <rfc822;linux-renesas-soc@vger.kernel.org>);
        Wed, 12 Sep 2018 11:29:31 -0400
Date: Wed, 12 Sep 2018 12:25:35 +0200
From: Simon Horman <horms@verge.net.au>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
        Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: renesas: salvator-common: Add GPIO keys
 support
Message-ID: <20180912102534.vrocfv2mdrjuk2ev@verge.net.au>
References: <20180819194455.25096-1-laurent.pinchart+renesas@ideasonboard.com>
 <CAMuHMdW4ium4s97+1iOHkhBGw3LdfPyfxXq4_7ic+VtXzRpE2g@mail.gmail.com>
 <20180906094231.eccvg2asl7kgotu2@verge.net.au>
 <2032675.nQfVxexfDx@avalon>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2032675.nQfVxexfDx@avalon>
Sender: linux-renesas-soc-owner@vger.kernel.org
List-ID: <linux-renesas-soc.vger.kernel.org>

On Thu, Sep 06, 2018 at 12:59:20PM +0300, Laurent Pinchart wrote:
> Hello,
> 
> On Thursday, 6 September 2018 12:42:32 EEST Simon Horman wrote:
> > On Thu, Aug 23, 2018 at 11:58:54AM +0200, Geert Uytterhoeven wrote:
> > > On Sun, Aug 19, 2018 at 9:44 PM Laurent Pinchart wrote:
> > >> The Salvator-X and XS boards have a 4 lines DIP switch and 3 push
> > >> buttons connected to SoC GPIOs, meant to be used as general-purpose test
> > >> keys. Add a corresponding node in DT, mapping (semi-randomly) the DIP
> > >> switch to keys 1-4 and the push buttons to keys A-C.
> > >> 
> > >> Signed-off-by: Laurent Pinchart
> > >> <laurent.pinchart+renesas@ideasonboard.com>
> > > 
> > > Given GP6_1[123] are not just wired to the 3 push buttons, but also to 3
> > > LEDs, I wonder if we shouldn't postpone that part until Linux can handle
> > > GPIOs connected to both?
> > 
> > Laurent, any thoughts on that?
> 
> Right now the GPIOs are not wired in DT, and we're thus without a way to
> interface to both LEDs and push buttons. While I agree that an ideal
> solution would be to support both, I think that moving from nothing to
> support for push buttons would be a step forward already.

I tend to agree. Geert, what are your thoughts?