From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60656) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g04eT-00061N-QS for qemu-devel@nongnu.org; Wed, 12 Sep 2018 08:53:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g04eR-00065D-WD for qemu-devel@nongnu.org; Wed, 12 Sep 2018 08:53:49 -0400 Date: Wed, 12 Sep 2018 08:53:36 -0400 From: Jeff Cody Message-ID: <20180912125336.GV22117@localhost.localdomain> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v4 0/4] block/rbd: enable filename parsing on open List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, qemu-stable@nongnu.org, jsnow@redhat.com, eblake@redhat.com, libvir-list@redhat.com, mreitz@redhat.com, kwolf@redhat.com On Tue, Sep 11, 2018 at 06:32:29PM -0400, Jeff Cody wrote: > Changes from v3: > ================ > > Patch 4: Typo fixed [Eric] > Added examples [Eric] > > Changes from v2: > ================= > > Patch 4: New, document deprecation. [Eric] > Patch 3,2: Add r-b's > > > Changes from v1: > ================= > > Patch 1: Don't pass unused BlockDriverState to helper function > > Patch 2: Do not allow mixed usage; fail if keyvalue is present [Eric] > Add deprecation warning [John] > Pull legacy parsing code into function [John] > Fixed filename leak > > Patch 3: New; iotest 231. [Eric] > > > iotest failure on current master: > > QA output created by 231 > -qemu-img: RBD options encoded in the filename as keyvalue pairs is deprecated. Future versions may cease to parse these options in the future. > -unable to get monitor info from DNS SRV with service name: ceph-mon > -no monitors specified to connect to. > -qemu-img: Could not open 'json:{'file.driver':'rbd','file.filename':'rbd:rbd/bogus:conf=BOGUS_CONF'}': error connecting: No such file or directory > +qemu-img: Could not open 'json:{'file.driver':'rbd','file.filename':'rbd:rbd/bogus:conf=BOGUS_CONF'}': Parameter 'pool' is missing > unable to get monitor info from DNS SRV with service name: ceph-mon > no monitors specified to connect to. > qemu-img: Could not open 'json:{'file.driver':'rbd','file.pool':'rbd','file.image':'bogus','file.conf':'BOGUS_CONF'}': error connecting: No such file or directory > Failures: 231 > Failed 1 of 1 tests > > Jeff Cody (4): > block/rbd: pull out qemu_rbd_convert_options > block/rbd: Attempt to parse legacy filenames > block/rbd: add iotest for rbd legacy keyvalue filename parsing > block/rbd: add deprecation documentation for filename keyvalue pairs > > block/rbd.c | 89 ++++++++++++++++++++++++++++++++------ > qemu-deprecated.texi | 15 +++++++ > tests/qemu-iotests/231 | 62 ++++++++++++++++++++++++++ > tests/qemu-iotests/231.out | 9 ++++ > tests/qemu-iotests/group | 1 + > 5 files changed, 162 insertions(+), 14 deletions(-) > create mode 100755 tests/qemu-iotests/231 > create mode 100644 tests/qemu-iotests/231.out > > -- > 2.17.1 > Thanks, Applied to my block branch: git://github.com/codyprime/qemu-kvm-jtc block -Jeff