diff for duplicates of <20180912130355.GA4009@redhat.com> diff --git a/a/1.txt b/N1/1.txt index 1af6950..81d4531 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -22,3 +22,39 @@ my last reply. Below patch fix userfaultfd bug. I am not posting it as it is on a branch and i am not sure when Andrea plan to post. Andrea feel free to squash that fix. + + +From 35cdb30afa86424c2b9f23c0982afa6731be961c Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse?= <jglisse@redhat.com> +Date: Wed, 12 Sep 2018 08:58:33 -0400 +Subject: [PATCH] userfaultfd: do not set dirty accountable when changing + protection +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +mwriteprotect_range() has nothing to do with the dirty accountable +optimization so do not set it as it opens a door for userspace to +unwrite protect pages in a range that is write protected ie the vma +!(vm_flags & VM_WRITE). + +Signed-off-by: Jérôme Glisse <jglisse@redhat.com> +--- + mm/userfaultfd.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c +index a0379c5ffa7c..59db1ce48fa0 100644 +--- a/mm/userfaultfd.c ++++ b/mm/userfaultfd.c +@@ -632,7 +632,7 @@ int mwriteprotect_range(struct mm_struct *dst_mm, unsigned long start, + newprot = vm_get_page_prot(dst_vma->vm_flags); + + change_protection(dst_vma, start, start + len, newprot, +- !enable_wp, 0); ++ false, 0); + + err = 0; + out_unlock: +-- +2.17.1 diff --git a/a/content_digest b/N1/content_digest index c5b1322..bc1fbcf 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -42,6 +42,42 @@ "\n" "Below patch fix userfaultfd bug. I am not posting it as it is on a\n" "branch and i am not sure when Andrea plan to post. Andrea feel free\n" - to squash that fix. + "to squash that fix.\n" + "\n" + "\n" + "From 35cdb30afa86424c2b9f23c0982afa6731be961c Mon Sep 17 00:00:00 2001\n" + "From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse?= <jglisse@redhat.com>\n" + "Date: Wed, 12 Sep 2018 08:58:33 -0400\n" + "Subject: [PATCH] userfaultfd: do not set dirty accountable when changing\n" + " protection\n" + "MIME-Version: 1.0\n" + "Content-Type: text/plain; charset=UTF-8\n" + "Content-Transfer-Encoding: 8bit\n" + "\n" + "mwriteprotect_range() has nothing to do with the dirty accountable\n" + "optimization so do not set it as it opens a door for userspace to\n" + "unwrite protect pages in a range that is write protected ie the vma\n" + "!(vm_flags & VM_WRITE).\n" + "\n" + "Signed-off-by: J\303\251r\303\264me Glisse <jglisse@redhat.com>\n" + "---\n" + " mm/userfaultfd.c | 2 +-\n" + " 1 file changed, 1 insertion(+), 1 deletion(-)\n" + "\n" + "diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c\n" + "index a0379c5ffa7c..59db1ce48fa0 100644\n" + "--- a/mm/userfaultfd.c\n" + "+++ b/mm/userfaultfd.c\n" + "@@ -632,7 +632,7 @@ int mwriteprotect_range(struct mm_struct *dst_mm, unsigned long start,\n" + " \t\tnewprot = vm_get_page_prot(dst_vma->vm_flags);\n" + " \n" + " \tchange_protection(dst_vma, start, start + len, newprot,\n" + "-\t\t\t\t!enable_wp, 0);\n" + "+\t\t\t\tfalse, 0);\n" + " \n" + " \terr = 0;\n" + " out_unlock:\n" + "-- \n" + 2.17.1 -2907f6edd04f9d4e7b44f546c98d6dca2758c218be0f94bb4d7420937197535d +7ffff5efb206414d086d9cbadc93526a0beda8ed63d607ff1a246c4f0e15a298
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.