From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH] net: dsa: mv88e6xxx: Add MV88E6352 DT compatible Date: Wed, 12 Sep 2018 15:32:22 +0200 Message-ID: <20180912133222.GC24595@lunn.ch> References: <20180911221536.12993-1-marex@denx.de> <20180911231246.GB11474@lunn.ch> <20180911233251.GE11474@lunn.ch> <30900c22-1717-c907-7129-f2dcb90bbc6c@denx.de> <20180912004602.GA14588@lunn.ch> <20180912124738.GA24595@lunn.ch> <2efc9a68-fc8c-2a85-14f8-bc2c72d9957f@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org To: Marek Vasut Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:60359 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727127AbeILSg5 (ORCPT ); Wed, 12 Sep 2018 14:36:57 -0400 Content-Disposition: inline In-Reply-To: <2efc9a68-fc8c-2a85-14f8-bc2c72d9957f@denx.de> Sender: netdev-owner@vger.kernel.org List-ID: > But the DT should correctly describe the hardware, if it doesn't, it's > just broken. It is more subtle than that. It can be broken, yet work, because it contains information which we don't use. I really expect there will be cut/paste errors, meaning the more specific compatible is sometimes wrong. But since at the moment we don't use it, such a broken DT blob will work. Until the day we need to make use of the more specific compatible because there really is broken silicon. At that point, we introduce a regression. All the devices with broke, yet up until now working DT blobs, stop working. Are you really going to argue they where always broken, so we don't care we introduced a regression? Anyway, this is just rehasing an old discussion. Please go read the archive. See if you have anything new to add which was not discussed before. Andrew