From: Tony Lindgren <tony@atomide.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Keerthy <j-keerthy@ti.com>,
mark.rutland@arm.com, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, t-kristo@ti.com
Subject: Re: [PATCH] dt-bindings: power: Introduce suspend states supported properties
Date: Wed, 12 Sep 2018 07:01:02 -0700 [thread overview]
Message-ID: <20180912140102.GJ5662@atomide.com> (raw)
In-Reply-To: <19ae9d20-46aa-25d7-87aa-ea4270f0162b@arm.com>
* Sudeep Holla <sudeep.holla@arm.com> [180912 13:47]:
>
>
> On 12/09/18 14:32, Tony Lindgren wrote:
> > * Sudeep Holla <sudeep.holla@arm.com> [180912 11:41]:
> >> On 12/09/18 12:19, Keerthy wrote:
> >>> suspend to mem and suspend to disk are pretty generic states and i agree
> >>> implementation is platform dependent so why not have properties that
> >>> convey if they are supported?
> >>>
> >>
> >> We already have power domains and idle states for that. If you need to
> >> restrict few states on some platform for whatever reasons, just disable
> >> those states. I don't see the need to add any more bindings for the same.
> >
> > Oh do you mean the "domain-idle-states" property as mentioned in the
> > Documentation/devicetree/bindings/power/power_domain.txt?
> >
>
> Yes, exactly that.
OK
> > Yeah that should do and the DOMAIN_PWR_DN and DOMAIN_RET can be SoC
> > specific and then the board can select which ones to use depending on
> > how things are wired for GPIOs, memory, PMIC and so on.
> >
>
> All the idle-states are platform specific. DOMAIN_RET and DOMAIN_PWR_DN
> are just examples used in the bindings.
>
> > Hmm I don't see any users for this binding though?
> >
>
> It was added specifically to deal with such SoC idles states or
> hierarchical CPU power domains states, no users in upstream yet. But IMO
> it fits what $subject is trying to address.
OK great thanks for confirming that.
Regards,
Tony
prev parent reply other threads:[~2018-09-12 14:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 4:09 [PATCH] dt-bindings: power: Introduce suspend states supported properties Keerthy
2018-09-12 4:09 ` Keerthy
2018-09-12 11:02 ` Sudeep Holla
2018-09-12 11:19 ` Keerthy
2018-09-12 11:19 ` Keerthy
2018-09-12 11:37 ` Sudeep Holla
2018-09-12 13:32 ` Tony Lindgren
2018-09-12 13:42 ` Sudeep Holla
2018-09-12 14:01 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180912140102.GJ5662@atomide.com \
--to=tony@atomide.com \
--cc=devicetree@vger.kernel.org \
--cc=j-keerthy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.