From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: <bhelgaas@google.com>
Cc: <lorenzo.pieralisi@arm.com>, <linux-pci@vger.kernel.org>,
<linuxarm@huawei.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: [PATCH 1/1] pci: Pick up the acpi numa node value if it is specified at the device level.
Date: Wed, 12 Sep 2018 16:21:40 +0100 [thread overview]
Message-ID: <20180912152140.3676-2-Jonathan.Cameron@huawei.com> (raw)
In-Reply-To: <20180912152140.3676-1-Jonathan.Cameron@huawei.com>
The ACPI specification allows you to provide _PXM entries for devices based
on their location on a particular bus. Let us use that if it is provided
rather than just assuming it makes sense to put the device into the proximity
domain of the root.
An example DSDT entry that will supply this is:
Device (PCI2)
{
Name (_HID, "PNP0A08") // PCI Express Root Bridge
Name (_CID, "PNP0A03") // Compatible PCI Root Bridge
Name(_SEG, 2) // Segment of this Root complex
Name(_BBN, 0xF8) // Base Bus Number
Name(_CCA, 1)
Method (_PXM, 0, NotSerialized) {
Return(0x00)
}
...
Device (BRI0) {
Name (_HID, "19E51610")
Name (_ADR, 0)
Name (_BBN, 0xF9)
Device (CAR0) {
Name (_HID, "97109912")
Name (_ADR, 0)
Method (_PXM, 0, NotSerialized) {
Return(0x02)
}
}
}
}
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---
drivers/pci/pci-acpi.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c
index 738e3546abb1..f2f5f0ddd60e 100644
--- a/drivers/pci/pci-acpi.c
+++ b/drivers/pci/pci-acpi.c
@@ -753,10 +753,15 @@ static void pci_acpi_setup(struct device *dev)
{
struct pci_dev *pci_dev = to_pci_dev(dev);
struct acpi_device *adev = ACPI_COMPANION(dev);
+ int node;
if (!adev)
return;
+ node = acpi_get_node(adev->handle);
+ if (node != NUMA_NO_NODE)
+ set_dev_node(dev, node);
+
pci_acpi_optimize_delay(pci_dev, adev->handle);
pci_acpi_add_pm_notifier(adev, pci_dev);
--
2.18.0
next prev parent reply other threads:[~2018-09-12 20:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 15:21 [PATCH 0/1] PCI: support numa node specification on a per device basis Jonathan Cameron
2018-09-12 15:21 ` Jonathan Cameron [this message]
2018-09-12 17:32 ` [PATCH 1/1] pci: Pick up the acpi numa node value if it is specified at the device level Bjorn Helgaas
[not found] ` <e4bd3423-ae2a-262c-1391-f9741ac4fdd0@geanix.com>
2018-11-13 9:24 ` Jonathan Cameron
2018-11-13 9:33 ` Jonathan Cameron
[not found] ` <8a0fd569-fa52-b884-ef0d-18aab1ef8c3f@geanix.com>
2018-11-13 10:23 ` Jonathan Cameron
2018-11-13 10:26 ` Martin Hundebøll
2018-11-13 14:49 ` Jonathan Cameron
[not found] ` <c02e2579-3572-533d-2c14-b7fe35a1057b@geanix.com>
2018-11-14 8:57 ` Jonathan Cameron
2018-11-14 9:31 ` Martin Hundebøll
2018-11-15 10:24 ` Jonathan Cameron
2018-11-15 10:30 ` Martin Hundebøll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180912152140.3676-2-Jonathan.Cameron@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lorenzo.pieralisi@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.