From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Fix a potential integer overflow with framebuffers extending past 4 GiB Date: Wed, 12 Sep 2018 19:05:22 +0300 Message-ID: <20180912160522.GA5565@intel.com> References: <20180911165457.12651-1-ville.syrjala@linux.intel.com> <153673998714.32749.16800681844186338661@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5DAC06E585 for ; Wed, 12 Sep 2018 16:05:26 +0000 (UTC) Content-Disposition: inline In-Reply-To: <153673998714.32749.16800681844186338661@skylake-alporthouse-com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBTZXAgMTIsIDIwMTggYXQgMDk6MTM6MDdBTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFF1b3RpbmcgVmlsbGUgU3lyamFsYSAoMjAxOC0wOS0xMSAxNzo1NDo1NykKPiA+IEZy b206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiAK PiA+IElmIHdlIGhhdmUgZnJhbWVidWZmZXJzIHRoYXQgYXJlID49IDRHaUIgaW4gc2l6ZSB3ZSB3 aWxsIG92ZXJmbG93Cj4gPiB0aGUgZmIgc2l6ZSBjaGVjayBpbiBpbnRlbF9maWxsX2ZiX2luZm8o KS4KPiA+IAo+ID4gQ3VycmVudGx5IHRoYXQgaXMgb25seSBwb3NzaWJsZSB3aXRoIE5WMTIgYW5k IENDUyBhcyBvZmZzZXRzWzFdCj4gPiBtYXkgYmUgYW55dGhpbmcgYmV0d2VlbiAwIGFuZCAweGZm ZmZmZmZmLiBvZnNldHNbMF0gaXMgY3VycmVudGx5Cj4gPiByZXF1aXJlZCB0byBiZSAwIHNvIHdl IGNhbid0IGhpdCB0aGUgb3ZlcmZsb3cgd2l0aCBhbnkgc2luZ2xlCj4gPiBwbGFuZSBmb3JtYXQg KHRoYW5rcyB0byBtYXggZmIgc2l6ZSBvZiA4a3g4ayBhbmQgbWF4IHN0cmlkZSBvZgo+ID4gMzIg S2lCKS4KPiA+IAo+ID4gSW4gdGhlIGZ1dHVyZSB3ZSBtYXkgYWxsb3cgYWxtb3N0IGFueSBmcmFt ZWJ1ZmZlciB0byBleGNlZWQgNEdpQgo+ID4gaW4gc2l6ZSBzbyB3ZSByZWFsbHkgc2hvdWxkIGZp eCB0aGUgb3ZlcmZsb3cuIE5vdCB0aGF0IHRoZSBvdmVyZmxvdwo+ID4gaXMgcGFydGljdWxhcmx5 IGRhbmdlcm91cy4gSXQncyBtb3N0bHkganVzdCBhIHNhbml0eSBjaGVjayBhZ2FpbnN0Cj4gPiBp bnNhbmUgdXNlcnNwYWNlLiBUaGUgZGlzcGxheSBlbmdpbmUgY2FuJ3Qgd3JpdGUgdG8gbWVtb3J5 IGFueXdheQo+ID4gc28gSSBzdXBwb3NlIGluIHRoZSB3b3JzdCBjYXNlIHdlIG1pZ2h0IGFuZ2Vy IHRoZSBodyBieSBhdHRlbXB0aW5nCj4gPiBzY2Fub3V0IHBhc3QgdGhlIGVuZCBvZiB0aGUgZ2d0 dCwgb3Igd2UgbWlnaHQgc2NhbiBvdXQgc29tZSBkYXRhCj4gPiB0aGF0IHdlJ3JlIG5vdCBzdXBw b3NlZCB0byBzZWUgZnJvbSBvdGhlciBwYXJ0cyBvZiB0aGUgZ2d0dC4KPiA+IAo+ID4gTm90ZSB0 aGF0IHRyaWdnZXJpbmcgdGhpcyBvdmVyZmxvdyBkZXBlbmRzIG9uIHRoZSBkcml2ZXIKPiA+IGFs aWduaW5nIHRoZSBmYiBoZWlnaHQgdG8gdGhlIG5leHQgdGlsZSBib3VuZGFyeSB0byBwdXNoIHRo ZQo+ID4gY2FsY3VsYXRlZCBzaXplIGFib3ZlIDRHaUIuIFdpdGggbGluZWFyIGJ1ZmZlcnMgdGhl IGVmZmVjdGl2ZQo+ID4gdGlsZSBoZWlnaHQgaXMgb25lIHNvIHRoYXQgbmV2ZXIgaGFwcGVucywg YW5kIHRoZSBjb3JlIGFscmVhZHkKPiA+IGhhcyBhIGNoZWNrIGZvciAzMmJpdCBvdmVyZmxvdyBv ZiBvZmZzZXRzW10rcGl0Y2hlc1tdKmhlaWdodC4KPiA+IAo+ID4gVGVzdGNhc2U6IGlndC9rbXNf YmlnX2ZiL3gtdGlsZWQtYWRkZmItc2l6ZS1vZmZzZXQtb3ZlcmZsb3cKPiA+IFRlc3RjYXNlOiBp Z3Qva21zX2JpZ19mYi95LXRpbGVkLWFkZGZiLXNpemUtb2Zmc2V0LW92ZXJmbG93Cj4gPiBTaWdu ZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29t Pgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgNyAr KysrLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMo LSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3Bs YXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gaW5kZXggMmI3 N2Q5MzUwYTNhLi4yYjQ3NGQwNDkwNzQgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rpc3BsYXkuYwo+ID4gQEAgLTI2MzYsOSArMjYzNiwxMCBAQCBpbnRlbF9maWxsX2ZiX2luZm8o c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gICAgICAgICAgICAgICAgIG1h eF9zaXplID0gbWF4KG1heF9zaXplLCBvZmZzZXQgKyBzaXplKTsKPiA+ICAgICAgICAgfQo+ID4g IAo+ID4gLSAgICAgICBpZiAobWF4X3NpemUgKiB0aWxlX3NpemUgPiBvYmotPmJhc2Uuc2l6ZSkg ewo+ID4gLSAgICAgICAgICAgICAgIERSTV9ERUJVR19LTVMoImZiIHRvbyBiaWcgZm9yIGJvIChu ZWVkICV1IGJ5dGVzLCBoYXZlICV6dSBieXRlcylcbiIsCj4gPiAtICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBtYXhfc2l6ZSAqIHRpbGVfc2l6ZSwgb2JqLT5iYXNlLnNpemUpOwo+ID4gKyAg ICAgICBpZiAobXVsX3UzMl91MzIobWF4X3NpemUsIHRpbGVfc2l6ZSkgPiBvYmotPmJhc2Uuc2l6 ZSkgewo+ID4gKyAgICAgICAgICAgICAgIERSTV9ERUJVR19LTVMoImZiIHRvbyBiaWcgZm9yIGJv IChuZWVkICVsbHUgYnl0ZXMsIGhhdmUgJXp1IGJ5dGVzKVxuIiwKPiA+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICh1bnNpZ25lZCBsb25nIGxvbmcpIG11bF91MzJfdTMyKG1heF9zaXpl LCB0aWxlX3NpemUpLAo+IAo+IG11bF91MzJfdTMyIHJldHVybnMgdTY0IGkuZS4gdW5zaWduZWQg bG9uZyBsb25nOyAlbGx1IGlzIHRoZSBvbmUgdHJ1ZQo+IGZvcm1hdCBzcGVjaWZpZXIgZm9yIHU2 NCAoTGludXMgZGVjcmVlICMxMDM3ODkpCgpXZWxsIHdoYWRkeWFrbm93LCBzbyBpdCBpcy4gTmV2 ZXIgcmVhbGl6ZWQgdGhhdCBmb3Igc29tZSByZWFzb24uCgo+IAo+IFJldmlld2VkLWJ5OiBDaHJp cyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAtQ2hyaXMKCi0tIApWaWxsZSBT eXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cg==