From: Darren Hart <dvhart@infradead.org>
To: Mario.Limonciello@dell.com
Cc: andy.shevchenko@gmail.com, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/2] platform/x86: dell-smbios-wmi: Correct a memory leak
Date: Wed, 12 Sep 2018 09:06:26 -0700 [thread overview]
Message-ID: <20180912160626.GA24957@wrath> (raw)
In-Reply-To: <d140b6171dfe4e748b7491f4955c07be@ausx13mpc120.AMER.DELL.COM>
On Wed, Sep 12, 2018 at 12:14:34PM +0000, Mario.Limonciello@dell.com wrote:
> Darren,
>
> > -----Original Message-----
> > From: Darren Hart [mailto:dvhart@infradead.org]
> > Sent: Monday, September 10, 2018 3:52 PM
> > To: Limonciello, Mario
> > Cc: Andy Shevchenko; LKML; platform-driver-x86@vger.kernel.org;
> > stable@vger.kernel.org
> > Subject: Re: [PATCH 1/2] platform/x86: dell-smbios-wmi: Correct a memory leak
> >
> > On Mon, Sep 10, 2018 at 01:01:52PM -0500, Mario Limonciello wrote:
> > > ACPI buffers were being allocated but never freed.
> > >
> > > Reported-by: Pinzhen Xu <pinzhen.xu@intel.com>
> > > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
> > > Cc: stable@vger.kernel.org
> >
> > Thanks Mario and Pinzhen, both queued. That's an easy one to miss, the usage not
> > being particularly obvious.
> >
>
> This cropped up and is fixed by that patch:
> https://github.com/dell/libsmbios/issues/63
>
> Given the impact and how small the patch is, I think it might be good if this can come to 4.19-rcX if possible.
> Thoughts?
>
> I suspect this one might be the same issue too:
> https://bugzilla.redhat.com/show_bug.cgi?id=1627609
Happy to pull these into fixes for 4.19-rcX. Queued to Fixes.
--
Darren Hart
VMware Open Source Technology Center
prev parent reply other threads:[~2018-09-12 16:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 18:01 [PATCH 1/2] platform/x86: dell-smbios-wmi: Correct a memory leak Mario Limonciello
2018-09-10 18:01 ` [PATCH 2/2] platform/x86: alienware-wmi: " Mario Limonciello
2018-09-10 20:51 ` [PATCH 1/2] platform/x86: dell-smbios-wmi: " Darren Hart
2018-09-12 12:14 ` Mario.Limonciello
2018-09-12 12:14 ` Mario.Limonciello
2018-09-12 16:06 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180912160626.GA24957@wrath \
--to=dvhart@infradead.org \
--cc=Mario.Limonciello@dell.com \
--cc=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.