From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH v2 03/17] compat_ioctl: use correct compat_ptr() translation in drivers Date: Wed, 12 Sep 2018 20:13:09 +0200 Message-ID: <20180912181309.GA15031@kroah.com> References: <20180912150142.157913-1-arnd@arndb.de> <20180912150142.157913-3-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180912150142.157913-3-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, Frederic Barrat , Andrew Donnellan , Frank Haverkamp , "Guilherme G. Piccoli" , Kashyap Desai , Sumit Saxena , Shivasharan S , "James E.J. Bottomley" , "Martin K. Petersen" , Felipe Balbi , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org List-Id: linux-scsi@vger.kernel.org On Wed, Sep 12, 2018 at 05:01:04PM +0200, Arnd Bergmann wrote: > A handful of drivers all have a trivial wrapper around their ioctl > handler, but don't call the compat_ptr() conversion function at the > moment. In practice this does not matter, since none of them are used > on the s390 architecture and for all other architectures, compat_ptr() > does not do anything, but using the new generic_compat_ioctl_ptrarg > helper makes it more correct in theory, and simplifies the code. > > Signed-off-by: Arnd Bergmann > --- > drivers/misc/cxl/flash.c | 8 +------- > drivers/misc/genwqe/card_dev.c | 23 +---------------------- > drivers/scsi/megaraid/megaraid_mm.c | 28 +--------------------------- > drivers/usb/gadget/function/f_fs.c | 12 +----------- > 4 files changed, 4 insertions(+), 67 deletions(-) Nice cleanup on this series! Acked-by: Greg Kroah-Hartman From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,03/17] compat_ioctl: use correct compat_ptr() translation in drivers From: Greg Kroah-Hartman Message-Id: <20180912181309.GA15031@kroah.com> Date: Wed, 12 Sep 2018 20:13:09 +0200 To: Arnd Bergmann Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, Frederic Barrat , Andrew Donnellan , Frank Haverkamp , "Guilherme G. Piccoli" , Kashyap Desai , Sumit Saxena , Shivasharan S , "James E.J. Bottomley" , "Martin K. Petersen" , Felipe Balbi , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org List-ID: T24gV2VkLCBTZXAgMTIsIDIwMTggYXQgMDU6MDE6MDRQTSArMDIwMCwgQXJuZCBCZXJnbWFubiB3 cm90ZToKPiBBIGhhbmRmdWwgb2YgZHJpdmVycyBhbGwgaGF2ZSBhIHRyaXZpYWwgd3JhcHBlciBh cm91bmQgdGhlaXIgaW9jdGwKPiBoYW5kbGVyLCBidXQgZG9uJ3QgY2FsbCB0aGUgY29tcGF0X3B0 cigpIGNvbnZlcnNpb24gZnVuY3Rpb24gYXQgdGhlCj4gbW9tZW50LiBJbiBwcmFjdGljZSB0aGlz IGRvZXMgbm90IG1hdHRlciwgc2luY2Ugbm9uZSBvZiB0aGVtIGFyZSB1c2VkCj4gb24gdGhlIHMz OTAgYXJjaGl0ZWN0dXJlIGFuZCBmb3IgYWxsIG90aGVyIGFyY2hpdGVjdHVyZXMsIGNvbXBhdF9w dHIoKQo+IGRvZXMgbm90IGRvIGFueXRoaW5nLCBidXQgdXNpbmcgdGhlIG5ldyBnZW5lcmljX2Nv bXBhdF9pb2N0bF9wdHJhcmcKPiBoZWxwZXIgbWFrZXMgaXQgbW9yZSBjb3JyZWN0IGluIHRoZW9y eSwgYW5kIHNpbXBsaWZpZXMgdGhlIGNvZGUuCj4gCj4gU2lnbmVkLW9mZi1ieTogQXJuZCBCZXJn bWFubiA8YXJuZEBhcm5kYi5kZT4KPiAtLS0KPiAgZHJpdmVycy9taXNjL2N4bC9mbGFzaC5jICAg ICAgICAgICAgfCAgOCArLS0tLS0tLQo+ICBkcml2ZXJzL21pc2MvZ2Vud3FlL2NhcmRfZGV2LmMg ICAgICB8IDIzICstLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvc2NzaS9tZWdhcmFp ZC9tZWdhcmFpZF9tbS5jIHwgMjggKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICBkcml2 ZXJzL3VzYi9nYWRnZXQvZnVuY3Rpb24vZl9mcy5jICB8IDEyICstLS0tLS0tLS0tLQo+ICA0IGZp bGVzIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgNjcgZGVsZXRpb25zKC0pCgpOaWNlIGNsZWFu dXAgb24gdGhpcyBzZXJpZXMhCgpBY2tlZC1ieTogR3JlZyBLcm9haC1IYXJ0bWFuIDxncmVna2hA bGludXhmb3VuZGF0aW9uLm9yZz4K