From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48325) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g089w-00080N-5b for qemu-devel@nongnu.org; Wed, 12 Sep 2018 12:38:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g089s-0005GH-HI for qemu-devel@nongnu.org; Wed, 12 Sep 2018 12:38:32 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:45992 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1g089q-0005Bw-DM for qemu-devel@nongnu.org; Wed, 12 Sep 2018 12:38:26 -0400 Date: Wed, 12 Sep 2018 18:38:16 +0200 From: Igor Mammedov Message-ID: <20180912183816.46950f66@redhat.com> In-Reply-To: <1536684589-11718-7-git-send-email-brijesh.singh@amd.com> References: <1536684589-11718-1-git-send-email-brijesh.singh@amd.com> <1536684589-11718-7-git-send-email-brijesh.singh@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 6/6] x86_iommu/amd: Enable Guest virtual APIC support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Brijesh Singh Cc: qemu-devel@nongnu.org, Tom Lendacky , Eduardo Habkost , "Michael S. Tsirkin" , Paolo Bonzini , Suravee Suthikulpanit , Richard Henderson On Tue, 11 Sep 2018 11:49:49 -0500 Brijesh Singh wrote: > Now that amd-iommu support interrupt remapping, enable the GASup in IVRS > table and GASup in extended feature register to indicate that IOMMU > support guest virtual APIC mode. > > Note that the GAMSup is set to zero to indicate that Guest Virtual > APIC does not support advanced interrupt features (i.e virtualized > interrupts using the guest virtual APIC). > > See Table 21 from IOMMU spec for interrupt virtualization controls > > IOMMU spec: https://support.amd.com/TechDocs/48882_IOMMU.pdf Table numbers and URLs tend to change over long time span, pls exact spec title and revision to above info, so one could easily google it. > > Cc: "Michael S. Tsirkin" > Cc: Paolo Bonzini > Cc: Richard Henderson > Cc: Eduardo Habkost > Cc: Marcel Apfelbaum > Cc: Tom Lendacky > Cc: Suravee Suthikulpanit > Signed-off-by: Brijesh Singh > --- > hw/i386/acpi-build.c | 3 ++- > hw/i386/amd_iommu.h | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > index 5c2c638..1cbc8ba 100644 > --- a/hw/i386/acpi-build.c > +++ b/hw/i386/acpi-build.c > @@ -2565,7 +2565,8 @@ build_amd_iommu(GArray *table_data, BIOSLinker *linker) > build_append_int_noprefix(table_data, > (48UL << 30) | /* HATS */ > (48UL << 28) | /* GATS */ > - (1UL << 2), /* GTSup */ > + (1UL << 2) | /* GTSup */ > + (1UL << 6), /* GASup */ > 4); > /* > * Type 1 device entry reporting all devices > diff --git a/hw/i386/amd_iommu.h b/hw/i386/amd_iommu.h > index 1dab974..5defaac 100644 > --- a/hw/i386/amd_iommu.h > +++ b/hw/i386/amd_iommu.h > @@ -177,7 +177,7 @@ > /* extended feature support */ > #define AMDVI_EXT_FEATURES (AMDVI_FEATURE_PREFETCH | AMDVI_FEATURE_PPR | \ > AMDVI_FEATURE_IA | AMDVI_FEATURE_GT | AMDVI_FEATURE_HE | \ > - AMDVI_GATS_MODE | AMDVI_HATS_MODE) > + AMDVI_GATS_MODE | AMDVI_HATS_MODE | AMDVI_FEATURE_GA) > > /* capabilities header */ > #define AMDVI_CAPAB_FEATURES (AMDVI_CAPAB_FLAT_EXT | \