From: Yu Zhao <yuzhao@google.com>
To: Mark Brown <broonie@kernel.org>
Cc: Takashi Iwai <tiwai@suse.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Jie Yang <yang.jie@linux.intel.com>,
Jaroslav Kysela <perex@perex.cz>,
Rakesh Ughreja <rakesh.a.ughreja@intel.com>,
Guneshwor Singh <guneshwor.o.singh@intel.com>,
Naveen Manohar <naveen.m@intel.com>,
Sriram Periyasamy <sriramx.periyasamy@intel.com>,
Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>,
Sanyog Kale <sanyog.r.kale@intel.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] Revert "ASoC: Intel: Skylake: Acquire irq after RIRB allocation"
Date: Wed, 12 Sep 2018 13:32:21 -0600 [thread overview]
Message-ID: <20180912193221.GA194302@google.com> (raw)
In-Reply-To: <20180912102020.GB6062@sirena.org.uk>
On Wed, Sep 12, 2018 at 11:20:20AM +0100, Mark Brown wrote:
> On Tue, Sep 11, 2018 at 03:12:46PM -0600, Yu Zhao wrote:
> > This reverts commit 12eeeb4f4733bbc4481d01df35933fc15beb8b19.
> >
> > The patch doesn't fix accessing memory with null pointer in
> > skl_interrupt().
>
> Please use normal subject lines and so on even for revert patches -
> they're patches just the same as any other.
Well, they seem pretty normal to me, and have been used by many:
commit 82ab86e82911107ead6fc7cd73568f75bc266a57
Author: Mark Brown <broonie@kernel.org>
Date: Mon Oct 30 19:40:25 2017 +0000
Revert "ASoC: rt5651: Enable jack detection on JD* pins"
This reverts commit 60d5a1a47b9a8381c08d2263b11ac9c757c87746.
Signed-off-by: Mark Brown <broonie@kernel.org>
Anyway, I'll update them in v3.
next prev parent reply other threads:[~2018-09-12 19:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 21:17 [PATCH 1/3] Revert "ASoC: Intel: Skylake: Acquire irq after RIRB allocation" Yu Zhao
2018-09-10 21:21 ` [PATCH 2/3] sound: enable interrupt after dma buffer initialization Yu Zhao
2018-09-10 21:23 ` [PATCH 3/3] sound: don't call skl_init_chip() to reset intel skl soc Yu Zhao
2018-09-11 6:17 ` Takashi Iwai
2018-09-11 6:17 ` Takashi Iwai
2018-09-11 6:06 ` [PATCH 2/3] sound: enable interrupt after dma buffer initialization Takashi Iwai
2018-09-11 6:06 ` Takashi Iwai
2018-09-11 20:58 ` Yu Zhao
2018-09-12 4:04 ` Vinod
2018-09-11 6:03 ` [PATCH 1/3] Revert "ASoC: Intel: Skylake: Acquire irq after RIRB allocation" Takashi Iwai
2018-09-11 6:03 ` Takashi Iwai
2018-09-11 16:36 ` Mark Brown
2018-09-11 16:36 ` Mark Brown
2018-09-11 20:44 ` Yu Zhao
2018-09-11 21:12 ` [PATCH v2 " Yu Zhao
2018-09-11 21:14 ` [PATCH v2 2/3] sound: enable interrupt after dma buffer initialization Yu Zhao
2018-09-11 21:15 ` [PATCH v2 3/3] sound: don't call skl_init_chip() to reset intel skl soc Yu Zhao
2018-09-12 10:20 ` [PATCH v2 1/3] Revert "ASoC: Intel: Skylake: Acquire irq after RIRB allocation" Mark Brown
2018-09-12 10:20 ` Mark Brown
2018-09-12 19:32 ` Yu Zhao [this message]
2018-09-13 11:31 ` Mark Brown
2018-09-13 11:31 ` Mark Brown
2018-09-12 19:43 ` [PATCH v3 1/3] ASoC: " Yu Zhao
2018-09-12 19:44 ` [PATCH v3 2/3] ASoC: enable interrupt after dma buffer initialization Yu Zhao
2018-09-12 19:45 ` [PATCH v3 3/3] ASoC: don't call skl_init_chip() to reset intel skl soc Yu Zhao
2018-09-13 11:31 ` [PATCH v3 2/3] ASoC: enable interrupt after dma buffer initialization Mark Brown
2018-09-13 11:31 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180912193221.GA194302@google.com \
--to=yuzhao@google.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=guneshwor.o.singh@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=naveen.m@intel.com \
--cc=pankaj.laxminarayan.bharadiya@intel.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rakesh.a.ughreja@intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=sriramx.periyasamy@intel.com \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.