From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sakari Ailus Subject: [PATCH v3 03/23] v4l: fwnode: The CSI-2 clock is continuous if it's not non-continuous Date: Thu, 13 Sep 2018 00:29:22 +0300 Message-ID: <20180912212942.19641-4-sakari.ailus@linux.intel.com> References: <20180912212942.19641-1-sakari.ailus@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180912212942.19641-1-sakari.ailus@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: linux-media@vger.kernel.org Cc: devicetree@vger.kernel.org, jacopo@jmondi.org, dri-devel@lists.freedesktop.org, slongerbeam@gmail.com, niklas.soderlund@ragnatech.se List-Id: devicetree@vger.kernel.org VGhlIGNvbnRpbnVvdXMgY2xvY2sgZmxhZyB3YXMgb25seSBzZXQgaWYgdGhlcmUgd2FzIGEgY2xv Y2sgb3IgZGF0YSBsYW5lcy4KVGhpcyBpc24ndCBuZWVkZWQgYXMgc3VjaCBhIGNvbmZpZ3VyYXRp b24gaXMgaW52YWxpZCB0byBiZWdpbiB3aXRoLiBBbHdheXMKc2V0IHRoZSBjb250aW51b3VzIGNs b2NrIGZsYWcgaWYgdGhlIG5vbi1jb250aW51b3VzIHByb3BlcnR5IGlzIG5vdCBmb3VuZC4KClNp Z25lZC1vZmYtYnk6IFNha2FyaSBBaWx1cyA8c2FrYXJpLmFpbHVzQGxpbnV4LmludGVsLmNvbT4K VGVzdGVkLWJ5OiBTdGV2ZSBMb25nZXJiZWFtIDxzdGV2ZV9sb25nZXJiZWFtQG1lbnRvci5jb20+ Ci0tLQogZHJpdmVycy9tZWRpYS92NGwyLWNvcmUvdjRsMi1md25vZGUuYyB8IDIgKy0KIDEgZmls ZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL2Ry aXZlcnMvbWVkaWEvdjRsMi1jb3JlL3Y0bDItZndub2RlLmMgYi9kcml2ZXJzL21lZGlhL3Y0bDIt Y29yZS92NGwyLWZ3bm9kZS5jCmluZGV4IGFiNDU3Y2YzNmJhNS4uY2Y5MGRkYjVjNDMwIDEwMDY0 NAotLS0gYS9kcml2ZXJzL21lZGlhL3Y0bDItY29yZS92NGwyLWZ3bm9kZS5jCisrKyBiL2RyaXZl cnMvbWVkaWEvdjRsMi1jb3JlL3Y0bDItZndub2RlLmMKQEAgLTEwNyw3ICsxMDcsNyBAQCBzdGF0 aWMgaW50IHY0bDJfZndub2RlX2VuZHBvaW50X3BhcnNlX2NzaTJfYnVzKHN0cnVjdCBmd25vZGVf aGFuZGxlICpmd25vZGUsCiAJaWYgKGZ3bm9kZV9wcm9wZXJ0eV9wcmVzZW50KGZ3bm9kZSwgImNs b2NrLW5vbmNvbnRpbnVvdXMiKSkgewogCQlmbGFncyB8PSBWNEwyX01CVVNfQ1NJMl9OT05DT05U SU5VT1VTX0NMT0NLOwogCQlwcl9kZWJ1Zygibm9uLWNvbnRpbnVvdXMgY2xvY2tcbiIpOwotCX0g ZWxzZSBpZiAoaGF2ZV9jbGtfbGFuZSB8fCBidXMtPm51bV9kYXRhX2xhbmVzID4gMCkgeworCX0g ZWxzZSB7CiAJCWZsYWdzIHw9IFY0TDJfTUJVU19DU0kyX0NPTlRJTlVPVVNfQ0xPQ0s7CiAJfQog Ci0tIAoyLjExLjAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:40860 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727732AbeIMCgI (ORCPT ); Wed, 12 Sep 2018 22:36:08 -0400 From: Sakari Ailus To: linux-media@vger.kernel.org Cc: devicetree@vger.kernel.org, slongerbeam@gmail.com, niklas.soderlund@ragnatech.se, jacopo@jmondi.org, p.zabel@pengutronix.de, dri-devel@lists.freedesktop.org Subject: [PATCH v3 03/23] v4l: fwnode: The CSI-2 clock is continuous if it's not non-continuous Date: Thu, 13 Sep 2018 00:29:22 +0300 Message-Id: <20180912212942.19641-4-sakari.ailus@linux.intel.com> In-Reply-To: <20180912212942.19641-1-sakari.ailus@linux.intel.com> References: <20180912212942.19641-1-sakari.ailus@linux.intel.com> Sender: linux-media-owner@vger.kernel.org List-ID: The continuous clock flag was only set if there was a clock or data lanes. This isn't needed as such a configuration is invalid to begin with. Always set the continuous clock flag if the non-continuous property is not found. Signed-off-by: Sakari Ailus Tested-by: Steve Longerbeam --- drivers/media/v4l2-core/v4l2-fwnode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c b/drivers/media/v4l2-core/v4l2-fwnode.c index ab457cf36ba5..cf90ddb5c430 100644 --- a/drivers/media/v4l2-core/v4l2-fwnode.c +++ b/drivers/media/v4l2-core/v4l2-fwnode.c @@ -107,7 +107,7 @@ static int v4l2_fwnode_endpoint_parse_csi2_bus(struct fwnode_handle *fwnode, if (fwnode_property_present(fwnode, "clock-noncontinuous")) { flags |= V4L2_MBUS_CSI2_NONCONTINUOUS_CLOCK; pr_debug("non-continuous clock\n"); - } else if (have_clk_lane || bus->num_data_lanes > 0) { + } else { flags |= V4L2_MBUS_CSI2_CONTINUOUS_CLOCK; } -- 2.11.0