Re: [PATCH blktests 0/3] Add NVMeOF multipath tests

[Omar Sandoval <osandov@osandov.com>]

On Thu, Aug 23, 2018 at 05:21:33PM -0700, Omar Sandoval wrote:
> On Thu, Aug 23, 2018 at 01:53:33AM +0000, Bart Van Assche wrote:
> > On Tue, 2018-08-21 at 08:46 +0200, Johannes Thumshirn wrote:
> > > On Mon, Aug 20, 2018 at 03:46:45PM +0000, Bart Van Assche wrote:
> > > > Moving these tests into the nvme directory is possible but will make it
> > > > harder to run the NVMeOF multipath tests separately. Are you fine with this?
> > > 
> > > Both way's have it's up and downsides, I agree.
> > > 
> > > Having two distinct groups requires to run './check nvme nvmeof-mp' to
> > > run full coverage with nvme.
> > > 
> > > Having it all in one group would require to run './check nvme 18 19 20
> > > 21 22 23 24 ...' to get only the dm-mpath ones.
> > > 
> > > Honestly I hate both but your's (the two distinct groups) is probably
> > > easier to handle in the end, I have to admit.
> > 
> > Omar, do you have a preference for one of the two aforementioned approaches?
> > 
> > Thanks,
> > 
> > Bart.
> > 
> 
> Let's keep it in a separate category, since lots of people running nvme
> tests probably aren't interested in testing multipath.
> 
> A bunch of the tests failed with
> 
> modprobe: FATAL: Module nvme is in use.
> 
> Maybe related to my test VM having an nvme device?

Ping, Bart, can you look into this? It'd be nice to get this in.