From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gustavo Padovan Subject: Re: [PATCH] drm/i2c/tda9950.c: set MAX_RETRIES for errors only Date: Thu, 13 Sep 2018 10:26:07 +0100 Message-ID: <20180913092607.GA21564@juma.lan> References: <6109476a-e8fa-6d82-3ed8-3833f0f18615@xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id B0EF96E128 for ; Thu, 13 Sep 2018 09:26:21 +0000 (UTC) Received: by mail-wm0-f65.google.com with SMTP id b19-v6so5344828wme.3 for ; Thu, 13 Sep 2018 02:26:21 -0700 (PDT) Content-Disposition: inline In-Reply-To: <6109476a-e8fa-6d82-3ed8-3833f0f18615@xs4all.nl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Hans Verkuil Cc: Russell King - ARM Linux , "dri-devel@lists.freedesktop.org" , Linux Media Mailing List List-Id: dri-devel@lists.freedesktop.org SGkgSGFucywKClRoYW5rcyBmb3IgdGhlIHBhdGNoLgoKT24gTW9uLCBBdWcgMjcsIDIwMTggYXQg MDI6Mjg6NTBQTSArMDIwMCwgSGFucyBWZXJrdWlsIHdyb3RlOgo+IFRoZSBDRUNfVFhfU1RBVFVT X01BWF9SRVRSSUVTIHNob3VsZCBiZSBzZXQgZm9yIGVycm9ycyBvbmx5IHRvCj4gcHJldmVudCB0 aGUgQ0VDIGZyYW1ld29yayBmcm9tIHJldHJ5aW5nIHRoZSB0cmFuc21pdC4gSWYgdGhlCj4gdHJh bnNtaXQgd2FzIHN1Y2Nlc3NmdWwsIHRoZW4gZG9uJ3Qgc2V0IHRoaXMgZmxhZy4KPiAKPiBGb3Vu ZCBieSBydW5uaW5nICdjZWMtY29tcGxpYW5jZSAtQScgb24gYSBiZWFnbGVib25lIGJveC4KPiAK PiBTaWduZWQtb2ZmLWJ5OiBIYW5zIFZlcmt1aWwgPGhhbnMudmVya3VpbEBjaXNjby5jb20+Cj4g LS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pMmMvdGRhOTk1MC5jIHwgMyArKy0KPiAgMSBmaWxlIGNo YW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+IAo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTJjL3RkYTk5NTAuYyBiL2RyaXZlcnMvZ3B1L2RybS9pMmMvdGRhOTk1 MC5jCj4gaW5kZXggNWQyZjBkNTQ4NDY5Li40YTE0ZmMzYjUwMTEgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2kyYy90ZGE5OTUwLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTJjL3Rk YTk5NTAuYwo+IEBAIC0xOTEsNyArMTkxLDggQEAgc3RhdGljIGlycXJldHVybl90IHRkYTk5NTBf aXJxKGludCBpcnEsIHZvaWQgKmRhdGEpCj4gIAkJCWJyZWFrOwo+ICAJCX0KPiAgCQkvKiBUREE5 OTUwIGV4ZWN1dGVzIGFsbCByZXRyaWVzIGZvciB1cyAqLwo+IC0JCXR4X3N0YXR1cyB8PSBDRUNf VFhfU1RBVFVTX01BWF9SRVRSSUVTOwo+ICsJCWlmICh0eF9zdGF0dXMgIT0gQ0VDX1RYX1NUQVRV U19PSykKPiArCQkJdHhfc3RhdHVzIHw9IENFQ19UWF9TVEFUVVNfTUFYX1JFVFJJRVM7Cj4gIAkJ Y2VjX3RyYW5zbWl0X2RvbmUocHJpdi0+YWRhcCwgdHhfc3RhdHVzLCBhcmJfbG9zdF9jbnQsCj4g IAkJCQkgIG5hY2tfY250LCAwLCBlcnJfY250KTsKPiAgCQlicmVhazsKClJldmlld2VkLWJ5OiBH dXN0YXZvIFBhZG92YW4gPGd1c3Rhdm8ucGFkb3ZhbkBjb2xsYWJvcmEuY29tPgoKPiAtLSAKPiAy LjE4LjAKPiAKPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wm0-f66.google.com ([74.125.82.66]:51870 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726792AbeIMOe7 (ORCPT ); Thu, 13 Sep 2018 10:34:59 -0400 Received: by mail-wm0-f66.google.com with SMTP id y2-v6so5358440wma.1 for ; Thu, 13 Sep 2018 02:26:20 -0700 (PDT) Date: Thu, 13 Sep 2018 10:26:07 +0100 From: Gustavo Padovan To: Hans Verkuil Cc: Linux Media Mailing List , "dri-devel@lists.freedesktop.org" , Russell King - ARM Linux Subject: Re: [PATCH] drm/i2c/tda9950.c: set MAX_RETRIES for errors only Message-ID: <20180913092607.GA21564@juma.lan> References: <6109476a-e8fa-6d82-3ed8-3833f0f18615@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6109476a-e8fa-6d82-3ed8-3833f0f18615@xs4all.nl> Sender: linux-media-owner@vger.kernel.org List-ID: Hi Hans, Thanks for the patch. On Mon, Aug 27, 2018 at 02:28:50PM +0200, Hans Verkuil wrote: > The CEC_TX_STATUS_MAX_RETRIES should be set for errors only to > prevent the CEC framework from retrying the transmit. If the > transmit was successful, then don't set this flag. > > Found by running 'cec-compliance -A' on a beaglebone box. > > Signed-off-by: Hans Verkuil > --- > drivers/gpu/drm/i2c/tda9950.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i2c/tda9950.c b/drivers/gpu/drm/i2c/tda9950.c > index 5d2f0d548469..4a14fc3b5011 100644 > --- a/drivers/gpu/drm/i2c/tda9950.c > +++ b/drivers/gpu/drm/i2c/tda9950.c > @@ -191,7 +191,8 @@ static irqreturn_t tda9950_irq(int irq, void *data) > break; > } > /* TDA9950 executes all retries for us */ > - tx_status |= CEC_TX_STATUS_MAX_RETRIES; > + if (tx_status != CEC_TX_STATUS_OK) > + tx_status |= CEC_TX_STATUS_MAX_RETRIES; > cec_transmit_done(priv->adap, tx_status, arb_lost_cnt, > nack_cnt, 0, err_cnt); > break; Reviewed-by: Gustavo Padovan > -- > 2.18.0 > >