From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Subject: Re: [PATCH 1/5] media: replace ADOBERGB by OPRGB Date: Thu, 13 Sep 2018 11:29:03 -0300 Message-ID: <20180913112903.7275b126@coco.lan> References: <20180913114731.16500-1-hverkuil@xs4all.nl> <20180913114731.16500-2-hverkuil@xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by gabe.freedesktop.org (Postfix) with ESMTPS id 76AF66E1B9 for ; Thu, 13 Sep 2018 14:29:08 +0000 (UTC) In-Reply-To: <20180913114731.16500-2-hverkuil@xs4all.nl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Hans Verkuil Cc: Hans Verkuil , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org RW0gVGh1LCAxMyBTZXAgMjAxOCAxMzo0NzoyNyArMDIwMApIYW5zIFZlcmt1aWwgPGh2ZXJrdWls QHhzNGFsbC5ubD4gZXNjcmV2ZXU6Cgo+IEZyb206IEhhbnMgVmVya3VpbCA8aGFuc3ZlcmtAY2lz Y28uY29tPgo+IAo+IFRoZSBDVEEtODYxIHN0YW5kYXJkcyBoYXZlIGJlZW4gdXBkYXRlZCB0byBy ZWZlciB0byBvcFJHQiBpbnN0ZWFkCj4gb2YgQWRvYmVSR0IuIFRoZSBvZmZpY2lhbCBzdGFuZGFy ZCBpcyBpbiBmYWN0IG5hbWVkIG9wUkdCLCBzbwo+IHN3aXRjaCB0byB0aGF0Lgo+IAo+IFRoZSB0 d28gb2xkIGRlZmluZXMgcmVmZXJyaW5nIHRvIEFET0JFUkdCIGluIHRoZSBwdWJsaWMgQVBJIGFy ZQo+IHB1dCB1bmRlciAjaWZuZGVmIF9fS0VSTkVMX18gYW5kIGEgY29tbWVudCBtZW50aW9ucyB0 aGF0IHRoZXkgYXJlCj4gZGVwcmVjYXRlZC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBIYW5zIFZlcmt1 aWwgPGhhbnN2ZXJrQGNpc2NvLmNvbT4KCgo+IGluZGV4IDE4NGU0ZGJlOGY5Yy4uYzFlMTRhM2I0 NzZlIDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvdWFwaS9saW51eC92aWRlb2RldjIuaAo+ICsrKyBi L2luY2x1ZGUvdWFwaS9saW51eC92aWRlb2RldjIuaAo+IEBAIC0yMjUsOCArMjI1LDEyIEBAIGVu dW0gdjRsMl9jb2xvcnNwYWNlIHsKPiAgCS8qIEZvciBSR0IgY29sb3JzcGFjZXMgc3VjaCBhcyBw cm9kdWNlcyBieSBtb3N0IHdlYmNhbXMuICovCj4gIAlWNEwyX0NPTE9SU1BBQ0VfU1JHQiAgICAg ICAgICA9IDgsCj4gIAo+IC0JLyogQWRvYmVSR0IgY29sb3JzcGFjZSAqLwo+ICsJLyogb3BSR0Ig Y29sb3JzcGFjZSAqLwo+ICsJVjRMMl9DT0xPUlNQQUNFX09QUkdCICAgICAgICAgPSA5LAo+ICsj aWZuZGVmIF9fS0VSTkVMX18KPiArCS8qIERlcHJlY2F0ZWQgYWxpYXMgZm9yIFY0TDJfQ09MT1JT UEFDRV9PUFJHQiAqLwo+ICAJVjRMMl9DT0xPUlNQQUNFX0FET0JFUkdCICAgICAgPSA5LAo+ICsj ZW5kaWYKPiAgCj4gIAkvKiBCVC4yMDIwIGNvbG9yc3BhY2UsIHVzZWQgZm9yIFVIRFRWLiAqLwo+ ICAJVjRMMl9DT0xPUlNQQUNFX0JUMjAyMCAgICAgICAgPSAxMCwKPiBAQCAtMjU4LDcgKzI2Miw3 IEBAIGVudW0gdjRsMl94ZmVyX2Z1bmMgewo+ICAJICoKPiAgCSAqIFY0TDJfQ09MT1JTUEFDRV9T UkdCLCBWNEwyX0NPTE9SU1BBQ0VfSlBFRzogVjRMMl9YRkVSX0ZVTkNfU1JHQgo+ICAJICoKPiAt CSAqIFY0TDJfQ09MT1JTUEFDRV9BRE9CRVJHQjogVjRMMl9YRkVSX0ZVTkNfQURPQkVSR0IKPiAr CSAqIFY0TDJfQ09MT1JTUEFDRV9PUFJHQjogVjRMMl9YRkVSX0ZVTkNfT1BSR0IKPiAgCSAqCj4g IAkgKiBWNEwyX0NPTE9SU1BBQ0VfU01QVEUyNDBNOiBWNEwyX1hGRVJfRlVOQ19TTVBURTI0ME0K PiAgCSAqCj4gQEAgLTI2OSw3ICsyNzMsMTEgQEAgZW51bSB2NGwyX3hmZXJfZnVuYyB7Cj4gIAlW NEwyX1hGRVJfRlVOQ19ERUZBVUxUICAgICA9IDAsCj4gIAlWNEwyX1hGRVJfRlVOQ183MDkgICAg ICAgICA9IDEsCj4gIAlWNEwyX1hGRVJfRlVOQ19TUkdCICAgICAgICA9IDIsCj4gKwlWNEwyX1hG RVJfRlVOQ19PUFJHQiAgICAgICA9IDMsCj4gKyNpZm5kZWYgX19LRVJORUxfXwo+ICsJLyogRGVw cmVjYXRlZCBhbGlhcyBmb3IgVjRMMl9YRkVSX0ZVTkNfT1BSR0IgKi8KPiAgCVY0TDJfWEZFUl9G VU5DX0FET0JFUkdCICAgID0gMywKPiArI2VuZGlmCj4gIAlWNEwyX1hGRVJfRlVOQ19TTVBURTI0 ME0gICA9IDQsCj4gIAlWNEwyX1hGRVJfRlVOQ19OT05FICAgICAgICA9IDUsCj4gIAlWNEwyX1hG RVJfRlVOQ19EQ0lfUDMgICAgICA9IDYsCgpOaXRwaWNrOiBpbnN0ZWFkIG9mIGhhdmluZyAjaWZu ZGVmIGluc2lkZSB0aGUgZW51bSwgSSB3b3VsZCBpbnN0ZWFkCnBsYWNlIGJvdGggVjRMMl9DT0xP UlNQQUNFX0FET0JFUkdCIGFuZCBWNEwyX1hGRVJfRlVOQ19BRE9CRVJHQiBvbgphIHNlcGFyYXRl ICNkZWZpbmUsIGUuIGc6CgovKgogKiBEZXByZWNhdGVkIG5hbWVzIGZvciBPcHRpb25hbCBSR0Ig Y29sb3JzcGFjZSAoSUVDIDYxOTY2LTIpCiAqCiAqIFdBUk5JTkc6IFBsZWFzZSBkb24ndCB1c2Ug aXQgb24geW91ciBjb2RlLCBhcyB0aG9zZSBjYW4gYmUgcmVtb3ZlZAogKiBmcm9tIEtlcm5lbHNw YWNlIGluIHRoZSBmdXR1cmUuCiAqLwojaWZuZGVmIF9fS0VSTkVMX18KIyBkZWZpbmUgVjRMMl9D T0xPUlNQQUNFX0FET0JFUkdCIFY0TDJfQ09MT1JTUEFDRV9PUFJHQgojIGRlZmluZSBWNEwyX1hG RVJfRlVOQ19BRE9CRVJHQiAgVjRMMl9YRkVSX0ZVTkNfT1BSR0IKI2VuZGlmCgpUaGVyZSBhcmUg dHdvIHJlYXNvbnMgZm9yIHRoYXQ6CgoxKSBieSBhZGRpbmcgdGhlbSBpbnNpZGUgZW51bXMgYW5k IG5vdCBkb2N1bWVudGluZywgeW91IG1heQogICBlbmQgYnkgaGF2aW5nIHdhcm5pbmdzOwoKMikg YXMgeW91IG1lbnRpb25lZCBvbiBwYXRjaCAwLzUsIG9uZSBvZiB0aGUgZ29hbHMgaXMgdG8KICAg ImF2b2lkIHBvc3NpYmxlIGZ1dHVyZSB0cmFkZW1hcmsgY29tcGxhaW50cy4iCgpTbywgYmV0dGVy IHRvIGFkZCBhIGNsZWFyIHdhcm5pbmcgYXQgdGhlIEtlcm5lbCB0aGF0IHdlIG1heSBuZWVkCnRv IHJlbW92ZSBpdCBpbiB0aGUgZnV0dXJlLgoKVGhhbmtzLApNYXVybwpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from bombadil.infradead.org ([198.137.202.133]:38712 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727534AbeIMTix (ORCPT ); Thu, 13 Sep 2018 15:38:53 -0400 Date: Thu, 13 Sep 2018 11:29:03 -0300 From: Mauro Carvalho Chehab To: Hans Verkuil Cc: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, Hans Verkuil Subject: Re: [PATCH 1/5] media: replace ADOBERGB by OPRGB Message-ID: <20180913112903.7275b126@coco.lan> In-Reply-To: <20180913114731.16500-2-hverkuil@xs4all.nl> References: <20180913114731.16500-1-hverkuil@xs4all.nl> <20180913114731.16500-2-hverkuil@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em Thu, 13 Sep 2018 13:47:27 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > The CTA-861 standards have been updated to refer to opRGB instead > of AdobeRGB. The official standard is in fact named opRGB, so > switch to that. > > The two old defines referring to ADOBERGB in the public API are > put under #ifndef __KERNEL__ and a comment mentions that they are > deprecated. > > Signed-off-by: Hans Verkuil > index 184e4dbe8f9c..c1e14a3b476e 100644 > --- a/include/uapi/linux/videodev2.h > +++ b/include/uapi/linux/videodev2.h > @@ -225,8 +225,12 @@ enum v4l2_colorspace { > /* For RGB colorspaces such as produces by most webcams. */ > V4L2_COLORSPACE_SRGB = 8, > > - /* AdobeRGB colorspace */ > + /* opRGB colorspace */ > + V4L2_COLORSPACE_OPRGB = 9, > +#ifndef __KERNEL__ > + /* Deprecated alias for V4L2_COLORSPACE_OPRGB */ > V4L2_COLORSPACE_ADOBERGB = 9, > +#endif > > /* BT.2020 colorspace, used for UHDTV. */ > V4L2_COLORSPACE_BT2020 = 10, > @@ -258,7 +262,7 @@ enum v4l2_xfer_func { > * > * V4L2_COLORSPACE_SRGB, V4L2_COLORSPACE_JPEG: V4L2_XFER_FUNC_SRGB > * > - * V4L2_COLORSPACE_ADOBERGB: V4L2_XFER_FUNC_ADOBERGB > + * V4L2_COLORSPACE_OPRGB: V4L2_XFER_FUNC_OPRGB > * > * V4L2_COLORSPACE_SMPTE240M: V4L2_XFER_FUNC_SMPTE240M > * > @@ -269,7 +273,11 @@ enum v4l2_xfer_func { > V4L2_XFER_FUNC_DEFAULT = 0, > V4L2_XFER_FUNC_709 = 1, > V4L2_XFER_FUNC_SRGB = 2, > + V4L2_XFER_FUNC_OPRGB = 3, > +#ifndef __KERNEL__ > + /* Deprecated alias for V4L2_XFER_FUNC_OPRGB */ > V4L2_XFER_FUNC_ADOBERGB = 3, > +#endif > V4L2_XFER_FUNC_SMPTE240M = 4, > V4L2_XFER_FUNC_NONE = 5, > V4L2_XFER_FUNC_DCI_P3 = 6, Nitpick: instead of having #ifndef inside the enum, I would instead place both V4L2_COLORSPACE_ADOBERGB and V4L2_XFER_FUNC_ADOBERGB on a separate #define, e. g: /* * Deprecated names for Optional RGB colorspace (IEC 61966-2) * * WARNING: Please don't use it on your code, as those can be removed * from Kernelspace in the future. */ #ifndef __KERNEL__ # define V4L2_COLORSPACE_ADOBERGB V4L2_COLORSPACE_OPRGB # define V4L2_XFER_FUNC_ADOBERGB V4L2_XFER_FUNC_OPRGB #endif There are two reasons for that: 1) by adding them inside enums and not documenting, you may end by having warnings; 2) as you mentioned on patch 0/5, one of the goals is to "avoid possible future trademark complaints." So, better to add a clear warning at the Kernel that we may need to remove it in the future. Thanks, Mauro