From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ming Lei Subject: Re: [PATCH RFC] scsi: ufs: Disable blk-mq for now Date: Thu, 13 Sep 2018 20:05:00 +0800 Message-ID: <20180913120459.GA4965@ming.t460p> References: <20180913112848.7807-1-adrian.hunter@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180913112848.7807-1-adrian.hunter@intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Adrian Hunter Cc: "Martin K . Petersen" , "James E . J . Bottomley" , Jens Axboe , Christoph Hellwig , Johannes Thumshirn , Bart Van Assche , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Stanislav Nijnikov , Evan Green , Vinayak Holikatti , Janek Kotas , Vivek Gautam , Asutosh Das , Subhash Jadavani , Sayali Lokhande , Li Wei , Bjorn Andersson , Jaegeuk Kim List-Id: linux-scsi@vger.kernel.org On Thu, Sep 13, 2018 at 02:28:48PM +0300, Adrian Hunter wrote: > blk-mq does not support runtime pm, so disable blk-mq support for now. So could you describe a bit what the issue you are trying to fix? This is host level runtime PM you are trying to address, and if blk-mq runtime isn't enabled, I guess the host won't be runtime suspended at all because some of its descendant are always active. So seems we need to do nothing for preventing the host controller from entering runtime suspend. Thanks, Ming From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92438C04ABB for ; Thu, 13 Sep 2018 12:05:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 38A5720839 for ; Thu, 13 Sep 2018 12:05:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38A5720839 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727941AbeIMROg (ORCPT ); Thu, 13 Sep 2018 13:14:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40620 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727300AbeIMROg (ORCPT ); Thu, 13 Sep 2018 13:14:36 -0400 Received: from smtp.corp.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 55291C025D21; Thu, 13 Sep 2018 12:05:26 +0000 (UTC) Received: from ming.t460p (ovpn-8-34.pek2.redhat.com [10.72.8.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C28733091323; Thu, 13 Sep 2018 12:05:05 +0000 (UTC) Date: Thu, 13 Sep 2018 20:05:00 +0800 From: Ming Lei To: Adrian Hunter Cc: "Martin K . Petersen" , "James E . J . Bottomley" , Jens Axboe , Christoph Hellwig , Johannes Thumshirn , Bart Van Assche , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Stanislav Nijnikov , Evan Green , Vinayak Holikatti , Janek Kotas , Vivek Gautam , Asutosh Das , Subhash Jadavani , Sayali Lokhande , Li Wei , Bjorn Andersson , Jaegeuk Kim , Alim Akhtar , Alex Lemberg Subject: Re: [PATCH RFC] scsi: ufs: Disable blk-mq for now Message-ID: <20180913120459.GA4965@ming.t460p> References: <20180913112848.7807-1-adrian.hunter@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180913112848.7807-1-adrian.hunter@intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 13 Sep 2018 12:05:26 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 13, 2018 at 02:28:48PM +0300, Adrian Hunter wrote: > blk-mq does not support runtime pm, so disable blk-mq support for now. So could you describe a bit what the issue you are trying to fix? This is host level runtime PM you are trying to address, and if blk-mq runtime isn't enabled, I guess the host won't be runtime suspended at all because some of its descendant are always active. So seems we need to do nothing for preventing the host controller from entering runtime suspend. Thanks, Ming