diff for duplicates of <20180913155703.GA22605@roeck-us.net> diff --git a/a/1.txt b/N1/1.txt index f98f899..c783871 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,17 +1,17 @@ -On Thu, Sep 13, 2018 at 05:48:59PM +0200, C?dric Le Goater wrote: +On Thu, Sep 13, 2018 at 05:48:59PM +0200, Cédric Le Goater wrote: > On 09/13/2018 03:33 PM, Guenter Roeck wrote: [ ... ] -> >>> ? /* -> >>> ?? * The state machine needs some refinement. It is only used to track -> >>> ?? * invalid STOP commands for the moment. +> >>> /* +> >>> * The state machine needs some refinement. It is only used to track +> >>> * invalid STOP commands for the moment. > >>> @@ -188,7 +215,7 @@ static void aspeed_i2c_bus_handle_cmd(AspeedI2CBus *bus, uint64_t value) -> >>> ? { -> >>> ????? bus->cmd &= ~0xFFFF; -> >>> ????? bus->cmd |= value & 0xFFFF; -> >>> -??? bus->intr_status = 0;> +??? bus->intr_status &= I2CD_INTR_RX_DONE; +> >>> { +> >>> bus->cmd &= ~0xFFFF; +> >>> bus->cmd |= value & 0xFFFF; +> >>> - bus->intr_status = 0;> + bus->intr_status &= I2CD_INTR_RX_DONE; > >> > >> it deserves a comment to understand which scenario we are trying to handle. -> >> ?? +> >> > > > > Ok. FWIW, I wonder if intr_status should be touched here in the first place, > > but I neither have the hardware nor a datasheet, so I don't know if any bits diff --git a/a/content_digest b/N1/content_digest index 4f73eed..a6d715c 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -9,25 +9,36 @@ "ref\03f86e75f-1502-eae8-0633-d087937111c8@roeck-us.net\0" "ref\0f47b3050-3abd-caa4-cc71-4b13ef60e2c0@kaod.org\0" "From\0Guenter Roeck <linux@roeck-us.net>\0" - "Subject\0[PATCH i2c-next v6] i2c: aspeed: Handle master/slave combined irq events properly\0" + "Subject\0Re: [PATCH i2c-next v6] i2c: aspeed: Handle master/slave combined irq events properly\0" "Date\0Thu, 13 Sep 2018 08:57:03 -0700\0" - "To\0linux-aspeed@lists.ozlabs.org\0" + "To\0C\303\251dric Le Goater <clg@kaod.org>\0" + "Cc\0Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>" + Joel Stanley <joel@jms.id.au> + linux-aspeed@lists.ozlabs.org + Vernon Mauery <vernon.mauery@linux.intel.com> + OpenBMC Maillist <openbmc@lists.ozlabs.org> + Brendan Higgins <brendanhiggins@google.com> + Linux Kernel Mailing List <linux-kernel@vger.kernel.org> + linux-i2c@vger.kernel.org + jarkko.nikula@linux.intel.com + Linux ARM <linux-arm-kernel@lists.infradead.org> + " James Feist <james.feist@linux.intel.com>\0" "\00:1\0" "b\0" - "On Thu, Sep 13, 2018 at 05:48:59PM +0200, C?dric Le Goater wrote:\n" + "On Thu, Sep 13, 2018 at 05:48:59PM +0200, C\303\251dric Le Goater wrote:\n" "> On 09/13/2018 03:33 PM, Guenter Roeck wrote:\n" "[ ... ]\n" - "> >>> ? /*\n" - "> >>> ?? * The state machine needs some refinement. It is only used to track\n" - "> >>> ?? * invalid STOP commands for the moment.\n" + "> >>> \302\240 /*\n" + "> >>> \302\240\302\240 * The state machine needs some refinement. It is only used to track\n" + "> >>> \302\240\302\240 * invalid STOP commands for the moment.\n" "> >>> @@ -188,7 +215,7 @@ static void aspeed_i2c_bus_handle_cmd(AspeedI2CBus *bus, uint64_t value)\n" - "> >>> ? {\n" - "> >>> ????? bus->cmd &= ~0xFFFF;\n" - "> >>> ????? bus->cmd |= value & 0xFFFF;\n" - "> >>> -??? bus->intr_status = 0;> +??? bus->intr_status &= I2CD_INTR_RX_DONE;\n" + "> >>> \302\240 {\n" + "> >>> \302\240\302\240\302\240\302\240\302\240 bus->cmd &= ~0xFFFF;\n" + "> >>> \302\240\302\240\302\240\302\240\302\240 bus->cmd |= value & 0xFFFF;\n" + "> >>> -\302\240\302\240\302\240 bus->intr_status = 0;> +\302\240\302\240\302\240 bus->intr_status &= I2CD_INTR_RX_DONE;\n" "> >>\n" "> >> it deserves a comment to understand which scenario we are trying to handle.\n" - "> >> ?? \n" + "> >> \302\240\302\240 \n" "> > \n" "> > Ok. FWIW, I wonder if intr_status should be touched here in the first place,\n" "> > but I neither have the hardware nor a datasheet, so I don't know if any bits\n" @@ -44,4 +55,4 @@ "Thanks,\n" Guenter -230e7da2e35949b7e5f30431b5b1da29289d2ba1d4d9c78368da134ad151d725 +ebd57d6a5688f5b7df948e622814c26487f7fabda5901e865f95487b18a7af3f
diff --git a/a/content_digest b/N2/content_digest index 4f73eed..87f796f 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -8,10 +8,10 @@ "ref\0fb185839-3ae0-01dc-09e8-f22db55ecb04@kaod.org\0" "ref\03f86e75f-1502-eae8-0633-d087937111c8@roeck-us.net\0" "ref\0f47b3050-3abd-caa4-cc71-4b13ef60e2c0@kaod.org\0" - "From\0Guenter Roeck <linux@roeck-us.net>\0" + "From\0linux@roeck-us.net (Guenter Roeck)\0" "Subject\0[PATCH i2c-next v6] i2c: aspeed: Handle master/slave combined irq events properly\0" "Date\0Thu, 13 Sep 2018 08:57:03 -0700\0" - "To\0linux-aspeed@lists.ozlabs.org\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Thu, Sep 13, 2018 at 05:48:59PM +0200, C?dric Le Goater wrote:\n" @@ -44,4 +44,4 @@ "Thanks,\n" Guenter -230e7da2e35949b7e5f30431b5b1da29289d2ba1d4d9c78368da134ad151d725 +bddeee482a3ac0c8ed1fc367ee7b68d15e7021d79e92966bf360f98147915978
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.