From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] zeromq: fix static build with libatomic
Date: Thu, 13 Sep 2018 20:59:23 +0200 [thread overview]
Message-ID: <20180913205923.3e9fc4d3@windsurf> (raw)
In-Reply-To: <20180913182419.5720-1-fontaine.fabrice@gmail.com>
Hello,
On Thu, 13 Sep 2018 20:24:19 +0200, Fabrice Fontaine wrote:
> Second patch added support to link with -latomic if needed however using
> LDFLAGS doesn't work when statically linking because LDFLAGS is added
> before LIBS
>
> Detection of atomic fails with:
>
> configure:23230: /accts/mlweber1/instance-2/output/host/bin/sparc-linux-g++ -o conftest -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -static -static -pedantic -Werror -Wall -D_GNU_SOURCE -D_REENTRANT -D_THREAD_SAFE -Wno-long-long -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -static -latomic conftest.cpp -lrt -lpthread -lstdc++ >&5
> /tmp/ccgrvVTg.o: In function `main':
> conftest.cpp:(.text.startup+0x10): undefined reference to `__atomic_fetch_add_4'
> collect2: error: ld returned 1 exit status
>
> So use LIBS instead of LDFLAGS
>
> As second patch was already merged upstream, a new PR was sent:
> https://github.com/zeromq/libzmq/pull/3250
>
> Fixes:
> - http://autobuild.buildroot.net/results/c471d6b1061a8516f7772735e471db68a32965aa
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> ...cinclude.m4-check-if-latomic-is-needed.patch | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-09-13 18:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 18:24 [Buildroot] [PATCH 1/1] zeromq: fix static build with libatomic Fabrice Fontaine
2018-09-13 18:59 ` Thomas Petazzoni [this message]
2018-10-01 19:32 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180913205923.3e9fc4d3@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.