From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/4] drm/i915/fbdev: Use i915/drm_i915_private consistently
Date: Thu, 13 Sep 2018 14:37:59 -0700 [thread overview]
Message-ID: <20180913213759.GH24668@intel.com> (raw)
In-Reply-To: <153687427814.26051.4135537478285107445@skylake-alporthouse-com>
On Thu, Sep 13, 2018 at 10:31:18PM +0100, Chris Wilson wrote:
> Quoting Rodrigo Vivi (2018-09-13 22:11:11)
> > On Thu, Sep 13, 2018 at 02:16:27PM +0100, Chris Wilson wrote:
> > > Convert the interface (except for the drm core callback) to accept
> > > drm_i915_private as that is our native type of the majority of
> > > operations.
> >
> > this message just tells about s/dev/dev_priv...
>
> What is dev_priv? To me, it talks about i915.
well, 2 separated things:
1. when I wrote this I was just referring to that info_fbdev change...
that is not reflected here on this message I'm afraid and that
could be a separated patch...
----
2. about the other comment related to dev_priv vs i915
your patch has this:
- ret = intel_fbdev_init(dev);
+ ret = intel_fbdev_init(dev_priv);
so, why not just i915 here as well?
> -Chris
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-09-13 21:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 13:16 [PATCH 1/4] drm/i915: Mark up a couple of KMS debug messages as such Chris Wilson
2018-09-13 13:16 ` [PATCH 2/4] drm/i915/fbdev: Use i915/drm_i915_private consistently Chris Wilson
2018-09-13 21:11 ` Rodrigo Vivi
2018-09-13 21:31 ` Chris Wilson
2018-09-13 21:37 ` Rodrigo Vivi [this message]
2018-09-13 13:16 ` [PATCH 3/4] drm/i915: Disable displays at the user's request Chris Wilson
2018-09-13 13:19 ` Chris Wilson
2018-09-13 13:16 ` [PATCH 4/4] HAX: force i915.disable_display=1 Chris Wilson
2018-09-13 13:35 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915: Mark up a couple of KMS debug messages as such Patchwork
2018-09-13 13:37 ` ✗ Fi.CI.SPARSE: " Patchwork
2018-09-13 13:53 ` ✗ Fi.CI.BAT: failure " Patchwork
2018-09-13 21:04 ` [PATCH 1/4] " Rodrigo Vivi
-- strict thread matches above, loose matches on Subject: below --
2018-10-15 11:17 [PATCH 1/4] drm/i915/fbdev: Use an ordinary worker to avoid async deadlock Chris Wilson
2018-10-15 11:17 ` [PATCH 2/4] drm/i915/fbdev: Use i915/drm_i915_private consistently Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180913213759.GH24668@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.