Re: [PATCH v2 0/7] TVP5150 fixes and new features

[Mauro Carvalho Chehab <mchehab+samsung@kernel.org>]

Em Fri, 14 Sep 2018 10:43:03 +0200
Marco Felsch <m.felsch@pengutronix.de> escreveu:

> Hi,
> 
> since I sent this series I only got feedback from Rob.

I'm doing some tests on it. If everything gets ok, I'll likely merge
it today.

> 
> Regards,
> Marco
> 
> On 18-08-13 11:25, Marco Felsch wrote:
> > Hi,
> > 
> > this is my v2 with the integrated reviews from my v1 [1]. Since Mauro
> > applied the most patches from my v1 to his experimental/tvp5150-3
> > branch [2], this series only contains those which aren't applied.
> > 
> > Patches I changed contain a changelog, so I will omit these here.
> > 
> > Patch ('[media] tvp5150: add FORMAT_TRY support for get/set selection
> > handlers') throws a compile error. Therefore I added two v4l2-subdev.h
> > patches which should fix the error in a common way.
> > 
> > Patch ('[media] tvp5150: add s_power callback') is new too. I forget
> > them in my v1. This patch address the interrupt enable/disable handling.
> > Now it is possible to pause streaming and keep the interrupts on.
> > 
> > The changes I made in the ('[media] tvp5150: add input source selection
> > of_graph support') patch are based on the the RFC [3] and discussion [4].
> > I dropped patch ('[media] tvp5150: Change default input source selection
> > behaviour') since the default input source selectopn is setup during the
> > .registered() callback now.
> > 
> > I've tested this series on a customer dt-based board. Unfortunately I
> > haven't a device which use the em28xx driver. So other tester a welcome :)
> > 
> > [1] https://www.spinics.net/lists/devicetree/msg236650.html
> > [2] https://git.linuxtv.org/mchehab/experimental.git/log/?h=tvp5150-3
> > [3] https://www.spinics.net/lists/devicetree/msg243181.html
> > [4] https://www.spinics.net/lists/devicetree/msg243840.html
> > 
> > Regards,
> > Marco
> > 
> > Marco Felsch (6):
> >   [media] tvp5150: add input source selection of_graph support
> >   [media] dt-bindings: tvp5150: Add input port connectors DT bindings
> >   [media] v4l2-subdev: add stubs for v4l2_subdev_get_try_*
> >   [media] v4l2-subdev: fix v4l2_subdev_get_try_* dependency
> >   [media] tvp5150: add FORMAT_TRY support for get/set selection handlers
> >   [media] tvp5150: add s_power callback
> > 
> > Michael Tretter (1):
> >   [media] tvp5150: initialize subdev before parsing device tree
> > 
> >  .../devicetree/bindings/media/i2c/tvp5150.txt | 191 +++++-
> >  drivers/media/i2c/tvp5150.c                   | 611 +++++++++++++++---
> >  include/media/v4l2-subdev.h                   | 111 ++--
> >  3 files changed, 776 insertions(+), 137 deletions(-)
> > 
> > -- 
> > 2.18.0
> > 
> >   



Thanks,
Mauro