From: Christoph Hellwig <hch@lst.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: akpm@linux-foundation.org, "Christoph Hellwig" <hch@lst.de>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Logan Gunthorpe" <logang@deltatee.com>,
alexander.h.duyck@intel.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 5/7] mm, hmm: Use devm semantics for hmm_devmem_{add, remove}
Date: Fri, 14 Sep 2018 15:18:38 +0200 [thread overview]
Message-ID: <20180914131838.GF27141@lst.de> (raw)
In-Reply-To: <153680534781.453305.3660438915028111950.stgit@dwillia2-desk3.amr.corp.intel.com>
On Wed, Sep 12, 2018 at 07:22:27PM -0700, Dan Williams wrote:
> devm semantics arrange for resources to be torn down when
> device-driver-probe fails or when device-driver-release completes.
> Similar to devm_memremap_pages() there is no need to support an explicit
> remove operation when the users properly adhere to devm semantics.
>
> Note that devm_kzalloc() automatically handles allocating node-local
> memory.
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Given that we have no single user of these function I still think we
should just remove them.
next prev parent reply other threads:[~2018-09-14 13:18 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 2:22 [PATCH v5 0/7] mm: Merge hmm into devm_memremap_pages, mark GPL-only Dan Williams
2018-09-13 2:22 ` [PATCH v5 1/7] mm, devm_memremap_pages: Mark devm_memremap_pages() EXPORT_SYMBOL_GPL Dan Williams
2018-09-13 2:22 ` Dan Williams
2018-09-13 16:25 ` Logan Gunthorpe
2018-09-13 16:25 ` Logan Gunthorpe
2018-09-13 2:22 ` [PATCH v5 2/7] mm, devm_memremap_pages: Kill mapping "System RAM" support Dan Williams
2018-09-13 2:22 ` Dan Williams
2018-09-13 16:10 ` Logan Gunthorpe
2018-09-13 16:10 ` Logan Gunthorpe
2018-09-14 13:14 ` Christoph Hellwig
2018-09-14 17:40 ` Dan Williams
2018-09-18 20:28 ` Jerome Glisse
2018-09-18 20:28 ` Jerome Glisse
2018-09-13 2:22 ` [PATCH v5 3/7] mm, devm_memremap_pages: Fix shutdown handling Dan Williams
2018-09-13 2:22 ` Dan Williams
2018-09-14 13:16 ` Christoph Hellwig
2018-09-14 17:25 ` Dan Williams
2018-09-18 20:28 ` Jerome Glisse
2018-09-18 20:28 ` Jerome Glisse
2018-09-18 20:28 ` Jerome Glisse
2018-09-13 2:22 ` [PATCH v5 4/7] mm, devm_memremap_pages: Add MEMORY_DEVICE_PRIVATE support Dan Williams
2018-09-13 2:22 ` Dan Williams
2018-09-14 13:18 ` Christoph Hellwig
2018-09-18 20:34 ` Jerome Glisse
2018-09-18 20:34 ` Jerome Glisse
2018-09-13 2:22 ` [PATCH v5 5/7] mm, hmm: Use devm semantics for hmm_devmem_{add, remove} Dan Williams
2018-09-13 2:22 ` Dan Williams
2018-09-14 13:18 ` Christoph Hellwig [this message]
2018-09-14 14:16 ` Jerome Glisse
2018-09-14 14:16 ` Jerome Glisse
2018-09-18 20:34 ` Jerome Glisse
2018-09-18 20:34 ` Jerome Glisse
2018-09-13 2:22 ` [PATCH v5 6/7] mm, hmm: Replace hmm_devmem_pages_create() with devm_memremap_pages() Dan Williams
2018-09-13 2:22 ` Dan Williams
2018-09-18 20:35 ` Jerome Glisse
2018-09-18 20:35 ` Jerome Glisse
2018-09-19 1:24 ` Balbir Singh
2018-09-19 1:24 ` Balbir Singh
2018-09-13 2:22 ` [PATCH v5 7/7] mm, hmm: Mark hmm_devmem_{add, add_resource} EXPORT_SYMBOL_GPL Dan Williams
2018-09-13 2:22 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180914131838.GF27141@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@intel.com \
--cc=dan.j.williams@intel.com \
--cc=jglisse@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=logang@deltatee.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.