From: Christoph Hellwig <hch@lst.de>
To: Carlos Maiolino <cmaiolino@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, hch@lst.de, sandeen@redhat.com,
david@fromorbit.com
Subject: Re: [PATCH 1/3] fs: Enable bmap() function to properly return errors
Date: Fri, 14 Sep 2018 15:23:13 +0200 [thread overview]
Message-ID: <20180914132313.GA27382@lst.de> (raw)
In-Reply-To: <20180912122536.31977-2-cmaiolino@redhat.com>
On Wed, Sep 12, 2018 at 02:25:34PM +0200, Carlos Maiolino wrote:
> attach_page_buffers(page, bh);
> - block = index << (PAGE_SHIFT - inode->i_blkbits);
> + blk_cur = index << (PAGE_SHIFT - inode->i_blkbits);
> while (bh) {
> + block = blk_cur;
> +
> if (count == 0)
> bh->b_blocknr = 0;
> else {
> - bh->b_blocknr = bmap(inode, block);
> - if (bh->b_blocknr == 0) {
> - /* Cannot use this file! */
> + ret = bmap(inode, &block);
> + if (ret || !block) {
> ret = -EINVAL;
> + bh->b_blocknr = 0;
> goto out;
This conversion look good, but the code you are starting with is
completely broken. It really needs to switch to use normal read/write_iter
interfaces ASAP.
Otherwise looks fine:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2018-09-14 18:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 12:25 [PATCH 0/3] Replace direct ->bmap calls by bmap() with error support Carlos Maiolino
2018-09-12 12:25 ` [PATCH 1/3] fs: Enable bmap() function to properly return errors Carlos Maiolino
2018-09-14 13:23 ` Christoph Hellwig [this message]
2018-09-14 18:48 ` Carlos Maiolino
2018-09-17 20:55 ` Darrick J. Wong
2018-09-18 6:00 ` Carlos Maiolino
2018-09-12 12:25 ` [PATCH 2/3] cachefiles: drop direct usage of ->bmap method Carlos Maiolino
2018-09-14 13:23 ` Christoph Hellwig
2018-09-14 18:56 ` Carlos Maiolino
2018-09-12 12:25 ` [PATCH 3/3] ecryptfs: drop direct calls to ->bmap Carlos Maiolino
2018-09-14 13:26 ` Christoph Hellwig
2018-09-14 18:47 ` Carlos Maiolino
2018-09-17 11:04 ` [PATCH 3/3 V2] " Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180914132313.GA27382@lst.de \
--to=hch@lst.de \
--cc=cmaiolino@redhat.com \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.