From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: re-enable FIBMAP on reflink; disable for swap
Date: Fri, 14 Sep 2018 06:46:07 -0700 [thread overview]
Message-ID: <20180914134607.GA6334@infradead.org> (raw)
In-Reply-To: <bf6e7f18-25fa-2b41-9532-78bffe33a241@sandeen.net>
On Wed, Sep 12, 2018 at 08:55:35PM -0500, Eric Sandeen wrote:
> The commit:
>
> db1327b1 xfs: report shared extent mappings to userspace correctly
>
> disabled FIBMAP on reflinked files, with this very clear rationale
> regarding swapfiles:
>
> "Have xfs_vm_bmap return zero for reflinked files because the
> bmap-based swap code requires static block mappings, which is
> incompatible with copy on write."
>
> However, this broke the FIBMAP interface for existing userspace
> apps, including bootloaders.
It didn't break any interface because the reflink flag has been
experimental and a mkfs-time opt in.
So NAK for this patch.
next prev parent reply other threads:[~2018-09-14 19:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 1:55 [PATCH] xfs: re-enable FIBMAP on reflink; disable for swap Eric Sandeen
2018-09-14 13:46 ` Christoph Hellwig [this message]
2018-09-14 13:53 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180914134607.GA6334@infradead.org \
--to=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.