From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH, for-4.19] dma-mapping: add the missing ARCH_HAS_SYNC_DMA_FOR_CPU_ALL declaration Date: Fri, 14 Sep 2018 17:51:50 +0200 Message-ID: <20180914155150.GA30438@lst.de> References: <20180911090049.10747-1-hch@lst.de> <20180914100842.GA23696@lst.de> <00257a79-72cf-15aa-fed9-d75923eed51e@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <00257a79-72cf-15aa-fed9-d75923eed51e-5wv7dgnIgG8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Robin Murphy Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, paul.burton-8NJIiSa5LzA@public.gmane.org, Christoph Hellwig List-Id: iommu@lists.linux-foundation.org On Fri, Sep 14, 2018 at 04:44:15PM +0100, Robin Murphy wrote: > On 14/09/18 11:08, Christoph Hellwig wrote: >> Aby chance to get a review for this? > > So without this, the select does nothing, > CONFIG_ARCH_HAS_SYNC_DMA_FOR_CPU_ALL is never defined, and BMIPS gets the > static inline stub and never flushes the RAC when it should? Exactly! From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 14 Sep 2018 17:51:49 +0200 (CEST) Received: from verein.lst.de ([213.95.11.211]:48231 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23992066AbeINPvqnzSv6 (ORCPT ); Fri, 14 Sep 2018 17:51:46 +0200 Received: by newverein.lst.de (Postfix, from userid 2407) id EBE0A67358; Fri, 14 Sep 2018 17:51:50 +0200 (CEST) Date: Fri, 14 Sep 2018 17:51:50 +0200 From: Christoph Hellwig To: Robin Murphy Cc: Christoph Hellwig , iommu@lists.linux-foundation.org, linux-mips@linux-mips.org, paul.burton@mips.com Subject: Re: [PATCH, for-4.19] dma-mapping: add the missing ARCH_HAS_SYNC_DMA_FOR_CPU_ALL declaration Message-ID: <20180914155150.GA30438@lst.de> References: <20180911090049.10747-1-hch@lst.de> <20180914100842.GA23696@lst.de> <00257a79-72cf-15aa-fed9-d75923eed51e@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <00257a79-72cf-15aa-fed9-d75923eed51e@arm.com> User-Agent: Mutt/1.5.17 (2007-11-01) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 66297 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: hch@lst.de Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Fri, Sep 14, 2018 at 04:44:15PM +0100, Robin Murphy wrote: > On 14/09/18 11:08, Christoph Hellwig wrote: >> Aby chance to get a review for this? > > So without this, the select does nothing, > CONFIG_ARCH_HAS_SYNC_DMA_FOR_CPU_ALL is never defined, and BMIPS gets the > static inline stub and never flushes the RAC when it should? Exactly!