From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [RFC 1/3] drm/i915/icl: Restructure ICL DPLL enable
 functionality
Date: Fri, 14 Sep 2018 19:06:55 +0300
Message-ID: <20180914160655.GJ5565@intel.com>
References: <1536908054-2176-1-git-send-email-vandita.kulkarni@intel.com>
 <1536908054-2176-2-git-send-email-vandita.kulkarni@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by gabe.freedesktop.org (Postfix) with ESMTPS id B941E6E93B
 for <intel-gfx@lists.freedesktop.org>; Fri, 14 Sep 2018 16:08:05 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <1536908054-2176-2-git-send-email-vandita.kulkarni@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Vandita Kulkarni <vandita.kulkarni@intel.com>
Cc: jani.nikula@intel.com, intel-gfx@lists.freedesktop.org, paulo.r.zanoni@intel.com
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBTZXAgMTQsIDIwMTggYXQgMTI6MjQ6MTJQTSArMDUzMCwgVmFuZGl0YSBLdWxrYXJu
aSB3cm90ZToKPiBGcm9tOiBNYWRoYXYgQ2hhdWhhbiA8bWFkaGF2LmNoYXVoYW5AaW50ZWwuY29t
Pgo+IAo+IEluIEdlbjExLCBEUExMIDAgYW5kIDEgYXJlIHNoYXJlZCBiZXR3ZWVuIERESSBhbmQg
RFNJLgo+IE1vc3Qgb2YgdGhlIHN0ZXBzIGZvciBlbmFibGluZyBEUExMIGFyZSBjb21tb24gYWNy
b3NzIERESQo+IGFuZCBEU0kuIFRoaXMgcGF0Y2ggbWFrZXMgaWNsX2RwbGxfZW5hYmxlKCkgZ2Vu
ZXJpYyB3aGljaAo+IHdpbGwgYmUgdXNlZCBieSBhbGwgdGhlIGVuY29kZXJzLgo+IAo+IFNpZ25l
ZC1vZmYtYnk6IE1hZGhhdiBDaGF1aGFuIDxtYWRoYXYuY2hhdWhhbkBpbnRlbC5jb20+Cj4gU2ln
bmVkLW9mZi1ieTogVmFuZGl0YSBLdWxrYXJuaSA8dmFuZGl0YS5rdWxrYXJuaUBpbnRlbC5jb20+
Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jICAgICAgfCAxMiArKysr
KysrKysrKysKPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYyB8IDE5ICsr
LS0tLS0tLS0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3Iu
aCB8ICAyICstCj4gIDMgZmlsZXMgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgMTggZGVsZXRp
b25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5j
IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiBpbmRleCBjZDAxYTA5Li4yOTQy
YTI0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gKysr
IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiBAQCAtMjgxMCw2ICsyODEwLDE4
IEBAIHN0YXRpYyB2b2lkIGludGVsX2RkaV9jbGtfc2VsZWN0KHN0cnVjdCBpbnRlbF9lbmNvZGVy
ICplbmNvZGVyLAo+ICAJbXV0ZXhfbG9jaygmZGV2X3ByaXYtPmRwbGxfbG9jayk7Cj4gIAo+ICAJ
aWYgKElTX0lDRUxBS0UoZGV2X3ByaXYpKSB7Cj4gKwkJZW51bSBpbnRlbF9kcGxsX2lkIGlkID0g
cGxsLT5pbmZvLT5pZDsKPiArCQlpOTE1X3JlZ190IGVuYWJsZV9yZWcgPSBpY2xfcGxsX2lkX3Rv
X2VuYWJsZV9yZWcoaWQpOwo+ICsKPiArCQl2YWwgPSBJOTE1X1JFQUQoZW5hYmxlX3JlZyk7Cj4g
KwkJdmFsIHw9IFBMTF9FTkFCTEU7Cj4gKwkJSTkxNV9XUklURShlbmFibGVfcmVnLCB2YWwpOwo+
ICsKPiArCQkvKiBUT0RPOiB3YWl0IHRpbWVzIG1pc3NpbmcgZnJvbSB0aGUgc3BlYy4gKi8KPiAr
CQlpZiAoaW50ZWxfd2FpdF9mb3JfcmVnaXN0ZXIoZGV2X3ByaXYsIGVuYWJsZV9yZWcsIFBMTF9M
T0NLLAo+ICsJCQkJCSAgICBQTExfTE9DSywgNSkpCj4gKwkJCURSTV9FUlJPUigiUExMICVkIG5v
dCBsb2NrZWRcbiIsIGlkKTsKPiArCgpJIGRvbid0IHJlYWxseSBzZWUgd2h5IHRoaXMgY2FuJ3Qg
c3RheSBpbiB0aGUgZHBsbCBtZ3IuCgo+ICAJCWlmIChwb3J0ID49IFBPUlRfQykKPiAgCQkJSTkx
NV9XUklURShERElfQ0xLX1NFTChwb3J0KSwKPiAgCQkJCSAgIGljbF9wbGxfdG9fZGRpX3BsbF9z
ZWwoZW5jb2RlciwgcGxsKSk7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu
dGVsX2RwbGxfbWdyLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jCj4g
aW5kZXggZTZjYWM5Mi4uMzZlZDE1NSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkx
NS9pbnRlbF9kcGxsX21nci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBs
bF9tZ3IuYwo+IEBAIC0yOTMwLDcgKzI5MzAsNyBAQCBzdGF0aWMgYm9vbCBpY2xfY2FsY19tZ19w
bGxfc3RhdGUoc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUsCj4gIAlyZXR1cm4g
cGxsOwo+ICB9Cj4gIAo+IC1zdGF0aWMgaTkxNV9yZWdfdCBpY2xfcGxsX2lkX3RvX2VuYWJsZV9y
ZWcoZW51bSBpbnRlbF9kcGxsX2lkIGlkKQo+ICtpOTE1X3JlZ190IGljbF9wbGxfaWRfdG9fZW5h
YmxlX3JlZyhlbnVtIGludGVsX2RwbGxfaWQgaWQpCj4gIHsKPiAgCXN3aXRjaCAoaWQpIHsKPiAg
CWRlZmF1bHQ6Cj4gQEAgLTMxMTksMjIgKzMxMTksNyBAQCBzdGF0aWMgdm9pZCBpY2xfcGxsX2Vu
YWJsZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAlkZWZhdWx0Ogo+ICAJ
CU1JU1NJTkdfQ0FTRShpZCk7Cj4gIAl9Cj4gLQo+IC0JLyoKPiAtCSAqIERWRlMgcHJlIHNlcXVl
bmNlIHdvdWxkIGJlIGhlcmUsIGJ1dCBpbiBvdXIgZHJpdmVyIHRoZSBjZGNsayBjb2RlCj4gLQkg
KiBwYXRocyBzaG91bGQgYWxyZWFkeSBiZSBzZXR0aW5nIHRoZSBhcHByb3ByaWF0ZSB2b2x0YWdl
LCBoZW5jZSB3ZSBkbwo+IC0JICogbm90aGlnbiBoZXJlLgo+IC0JICovCj4gLQo+IC0JdmFsID0g
STkxNV9SRUFEKGVuYWJsZV9yZWcpOwo+IC0JdmFsIHw9IFBMTF9FTkFCTEU7Cj4gLQlJOTE1X1dS
SVRFKGVuYWJsZV9yZWcsIHZhbCk7Cj4gLQo+IC0JaWYgKGludGVsX3dhaXRfZm9yX3JlZ2lzdGVy
KGRldl9wcml2LCBlbmFibGVfcmVnLCBQTExfTE9DSywgUExMX0xPQ0ssCj4gLQkJCQkgICAgMSkp
IC8qIDYwMHVzIGFjdHVhbGx5LiAqLwo+IC0JCURSTV9FUlJPUigiUExMICVkIG5vdCBsb2NrZWRc
biIsIGlkKTsKPiAtCj4gLQkvKiBEVkZTIHBvc3Qgc2VxdWVuY2Ugd291bGQgYmUgaGVyZS4gU2Vl
IHRoZSBjb21tZW50IGFib3ZlLiAqLwo+ICsJLyogRW5jb2RlciBzcGVjaWZpYyBQTEwgZW5hYmxl
IHN0ZXBzIGFyZSBhZGRlZCBpbiBlbmNvZGVyIGZpbGUgKi8KPiAgfQo+ICAKPiAgc3RhdGljIHZv
aWQgaWNsX3BsbF9kaXNhYmxlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiBk
aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuaCBiL2RyaXZl
cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmgKPiBpbmRleCBiZjBkZThhLi45ZTg5MjY1
IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmgKPiAr
KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5oCj4gQEAgLTM0NSw1ICsz
NDUsNSBAQCB2b2lkIGludGVsX2RwbGxfZHVtcF9od19zdGF0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJp
dmF0ZSAqZGV2X3ByaXYsCj4gIGludCBpY2xfY2FsY19kcF9jb21ib19wbGxfbGluayhzdHJ1Y3Qg
ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJCSAgICAgICB1aW50MzJfdCBwbGxfaWQp
Owo+ICBpbnQgY25sX2hkbWlfcGxsX3JlZl9jbG9jayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq
ZGV2X3ByaXYpOwo+IC0KPiAraTkxNV9yZWdfdCBpY2xfcGxsX2lkX3RvX2VuYWJsZV9yZWcoZW51
bSBpbnRlbF9kcGxsX2lkIGlkKTsKPiAgI2VuZGlmIC8qIF9JTlRFTF9EUExMX01HUl9IXyAqLwo+
IC0tIAo+IDEuOS4xCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk
ZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu
Zm8vaW50ZWwtZ2Z4CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50
ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y
Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=