From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [PATH RFC net-next 3/8] net: phy: Add helper to convert MII ADV register to a linkmode
Date: Sat, 15 Sep 2018 01:23:20 +0200 [thread overview]
Message-ID: <20180914232320.GA30993@lunn.ch> (raw)
In-Reply-To: <8c8fd712-d7bd-59b3-6ef9-187f45ba62b8@gmail.com>
On Fri, Sep 14, 2018 at 03:23:14PM -0700, Florian Fainelli wrote:
> On 09/14/2018 02:38 PM, Andrew Lunn wrote:
> > The phy_mii_ioctl can be used to write a value into the MII_ADVERTISE
> > register in the PHY. Since this changes the state of the PHY, we need
> > to make the same change to phydev->advertising. Add a helper which can
> > convert the register value to a linkmode.
>
> It would have been nice if we could eliminate the duplication between
> mii_adv_to_ethtool_adv_t() and mii_adv_to_linkmode_adv_t() but I don't
> really see how without changing the former function's signature.
Some of these functions are also used by non-phylib MAC drivers. So
the ethtool version cannot be eliminated.
And the UAPI for EEE still uses a u32 for which modes EEE is
advertised :-(
Andrew
next prev parent reply other threads:[~2018-09-15 4:39 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 21:38 [PATH RFC net-next 0/8] Continue towards using linkmode in phylib Andrew Lunn
2018-09-14 21:38 ` [PATH RFC net-next 1/8] net: phy: Move linkmode helpers to somewhere public Andrew Lunn
2018-09-14 22:08 ` Florian Fainelli
2018-09-16 19:18 ` Andrew Lunn
2018-09-17 9:48 ` Maxime Chevallier
2018-09-14 21:38 ` [PATH RFC net-next 2/8] net: phy: Add phydev_warn() Andrew Lunn
2018-09-14 22:10 ` Florian Fainelli
2018-09-14 23:26 ` Andrew Lunn
2018-09-17 9:49 ` Maxime Chevallier
2018-09-14 21:38 ` [PATH RFC net-next 3/8] net: phy: Add helper to convert MII ADV register to a linkmode Andrew Lunn
2018-09-14 22:23 ` Florian Fainelli
2018-09-14 23:23 ` Andrew Lunn [this message]
2018-09-17 9:50 ` Maxime Chevallier
2018-09-14 21:38 ` [PATH RFC net-next 4/8] net: phy: Add helper for advertise to lcl value Andrew Lunn
2018-09-15 0:27 ` Florian Fainelli
2018-09-17 9:51 ` Maxime Chevallier
2018-09-14 21:38 ` [PATH RFC net-next 5/8] net: phy: Add limkmode equivalents to some of the MII ethtool helpers Andrew Lunn
2018-09-15 0:28 ` Florian Fainelli
2018-09-17 9:53 ` Maxime Chevallier
2018-09-14 21:38 ` [PATH RFC net-next 6/8] net: ethernet xgbe expand PHY_GBIT_FEAUTRES Andrew Lunn
2018-09-15 10:01 ` Sergei Shtylyov
2018-09-14 21:38 ` [PATH RFC net-next 7/8] net: phy: Replace phy driver features u32 with link_mode bitmap Andrew Lunn
2018-09-15 21:31 ` Florian Fainelli
2018-09-15 22:30 ` Andrew Lunn
2018-09-16 16:20 ` Florian Fainelli
2018-09-16 17:59 ` Andrew Lunn
2018-09-14 21:38 ` [PATH RFC net-next 8/8] net: phy: Add build warning if assumptions get broken Andrew Lunn
2018-09-15 21:31 ` Florian Fainelli
2018-09-17 10:01 ` [PATH RFC net-next 0/8] Continue towards using linkmode in phylib Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180914232320.GA30993@lunn.ch \
--to=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.