From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-5.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 9A1C77D581 for ; Sat, 15 Sep 2018 17:54:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727225AbeIOXOf convert rfc822-to-8bit (ORCPT ); Sat, 15 Sep 2018 19:14:35 -0400 Received: from mail.bootlin.com ([62.4.15.54]:36705 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727171AbeIOXOf (ORCPT ); Sat, 15 Sep 2018 19:14:35 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id E5697207A8; Sat, 15 Sep 2018 19:54:44 +0200 (CEST) Received: from xps13 (84-112-184-8.cable.dynamic.surfer.at [84.112.184.8]) by mail.bootlin.com (Postfix) with ESMTPSA id 2FED12071D; Sat, 15 Sep 2018 19:54:43 +0200 (CEST) Date: Sat, 15 Sep 2018 19:54:40 +0200 From: Miquel Raynal To: Boris Brezillon Cc: Richard Weinberger , linux-mtd@lists.infradead.org, David Woodhouse , Brian Norris , Marek Vasut , Jonathan Corbet , linux-doc@vger.kernel.org, Hartley Sweeten , Ryan Mallon , Alexander Shiyan , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , Imre Kaloz , Krzysztof Halasa , Tony Lindgren , linux-omap@vger.kernel.org, Alexander Clouter , Thomas Petazzoni , Gregory CLEMENT , Jason Cooper , Sebastian Hesselbarth , Andrew Lunn , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Ralf Baechle , linux-mips@linux-mips.org, Yoshinori Sato , Rich Felker , linux-sh@vger.kernel.org, Greg Kroah-Hartman , devel@driverdev.osuosl.org Subject: Re: [PATCH 00/19] mtd: rawnand: API cleanup (2nd batch) Message-ID: <20180915195440.251fea18@xps13> In-Reply-To: <20180906223851.6964-1-boris.brezillon@bootlin.com> References: <20180906223851.6964-1-boris.brezillon@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Hi Boris, Boris Brezillon wrote on Fri, 7 Sep 2018 00:38:32 +0200: > Hello, > > This is the 2nd batch of API cleanup patches. This time we move > deprecated hooks/fields to the nand_legacy struct, and then move some > of the code found in nand_base.c into separate source/header files. > > With this new organization, new comers should more easily identify the > bits they can use in their NAND controller drivers and those that are > only meant for core code. It also shrink a bit nand_base.c which was > over 6000 lines of code. > > Note that existing coding style issues (reported by checkpatch) in arch > or driver code are intentionally not fixed to keep the series focused > on the API/core cleanup. > > Regards, > > Boris > > Boris Brezillon (19): > mtd: rawnand: Leave chip->IO_ADDR_{R,W} to NULL when unused > mtd: rawnand: Create a legacy struct and move ->IO_ADDR_{R,W} there > mtd: rawnand: Deprecate ->{read,write}_{byte,buf}() hooks > mtd: rawnand: Deprecate ->cmd_ctrl() and ->cmdfunc() > mtd: rawnand: Deprecate ->dev_ready() and ->waitfunc() > mtd: rawnand: Deprecate ->block_{bad,markbad}() hooks > mtd: rawnand: Deprecate ->erase() > mtd: rawnand: Deprecate ->{set,get}_features() hooks > mtd: rawnand: Deprecate ->chip_delay > mtd: rawnand: Move function prototypes after struct declarations > mtd: rawnand: Get rid of nand_flash_dev forward declation > mtd: rawnand: Get rid of the duplicate nand_chip forward declaration > mtd: rawnand: Get rid of a few unused definitions > mtd: rawnand: Move platform_nand_xxx definitions out of rawnand.h > mtd: rawnand: Inline onfi_get_async_timing_mode() > mtd: rawnand: Keep all internal stuff private > mtd: rawnand: Move legacy code to nand_legacy.c > mtd: rawnand: Move ONFI code to nand_onfi.c > mtd: rawnand: Move JEDEC code to nand_jedec.c > > Documentation/driver-api/mtdnand.rst | 30 +- > arch/arm/mach-ep93xx/snappercl15.c | 8 +- > arch/arm/mach-ep93xx/ts72xx.c | 9 +- > arch/arm/mach-imx/mach-qong.c | 6 +- > arch/arm/mach-ixp4xx/ixdp425-setup.c | 2 +- > arch/arm/mach-omap1/board-fsample.c | 3 +- > arch/arm/mach-omap1/board-h2.c | 3 +- > arch/arm/mach-omap1/board-h3.c | 2 +- > arch/arm/mach-omap1/board-nand.c | 2 +- > arch/arm/mach-omap1/board-perseus2.c | 3 +- > arch/arm/mach-orion5x/ts78xx-setup.c | 9 +- > arch/arm/mach-pxa/balloon3.c | 5 +- > arch/arm/mach-pxa/em-x270.c | 9 +- > arch/arm/mach-pxa/palmtx.c | 5 +- > arch/mips/alchemy/devboards/db1200.c | 9 +- > arch/mips/alchemy/devboards/db1300.c | 9 +- > arch/mips/alchemy/devboards/db1550.c | 9 +- > arch/mips/netlogic/xlr/platform-flash.c | 3 +- > arch/mips/pnx833x/common/platform.c | 5 +- > arch/mips/rb532/devices.c | 5 +- > arch/sh/boards/mach-migor/setup.c | 8 +- > drivers/mtd/nand/raw/Makefile | 4 +- > drivers/mtd/nand/raw/ams-delta.c | 22 +- > drivers/mtd/nand/raw/atmel/nand-controller.c | 22 +- > drivers/mtd/nand/raw/au1550nd.c | 43 +- > drivers/mtd/nand/raw/bcm47xxnflash/ops_bcm4706.c | 22 +- > drivers/mtd/nand/raw/brcmnand/brcmnand.c | 15 +- > drivers/mtd/nand/raw/cafe_nand.c | 22 +- > drivers/mtd/nand/raw/cmx270_nand.c | 28 +- > drivers/mtd/nand/raw/cs553x_nand.c | 42 +- > drivers/mtd/nand/raw/davinci_nand.c | 34 +- > drivers/mtd/nand/raw/denali.c | 23 +- > drivers/mtd/nand/raw/diskonchip.c | 50 +- > drivers/mtd/nand/raw/fsl_elbc_nand.c | 18 +- > drivers/mtd/nand/raw/fsl_ifc_nand.c | 24 +- > drivers/mtd/nand/raw/fsl_upm.c | 30 +- > drivers/mtd/nand/raw/fsmc_nand.c | 1 - > drivers/mtd/nand/raw/gpio.c | 16 +- > drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 22 +- > drivers/mtd/nand/raw/hisi504_nand.c | 18 +- > drivers/mtd/nand/raw/internals.h | 114 ++ > drivers/mtd/nand/raw/jz4740_nand.c | 14 +- > drivers/mtd/nand/raw/jz4780_nand.c | 10 +- > drivers/mtd/nand/raw/lpc32xx_mlc.c | 12 +- > drivers/mtd/nand/raw/lpc32xx_slc.c | 26 +- > drivers/mtd/nand/raw/mpc5121_nfc.c | 14 +- > drivers/mtd/nand/raw/mtk_nand.c | 12 +- > drivers/mtd/nand/raw/mxc_nand.c | 20 +- > drivers/mtd/nand/raw/nand_amd.c | 2 +- > drivers/mtd/nand/raw/nand_base.c | 1260 +++------------------- > drivers/mtd/nand/raw/nand_bbt.c | 5 +- > drivers/mtd/nand/raw/nand_hynix.c | 9 +- > drivers/mtd/nand/raw/nand_ids.c | 4 +- > drivers/mtd/nand/raw/nand_jedec.c | 113 ++ > drivers/mtd/nand/raw/nand_legacy.c | 642 +++++++++++ > drivers/mtd/nand/raw/nand_macronix.c | 2 +- > drivers/mtd/nand/raw/nand_micron.c | 3 +- > drivers/mtd/nand/raw/nand_onfi.c | 305 ++++++ > drivers/mtd/nand/raw/nand_samsung.c | 2 +- > drivers/mtd/nand/raw/nand_timings.c | 18 +- > drivers/mtd/nand/raw/nand_toshiba.c | 2 +- > drivers/mtd/nand/raw/nandsim.c | 14 +- > drivers/mtd/nand/raw/ndfc.c | 14 +- > drivers/mtd/nand/raw/nuc900_nand.c | 22 +- > drivers/mtd/nand/raw/omap2.c | 62 +- > drivers/mtd/nand/raw/orion_nand.c | 12 +- > drivers/mtd/nand/raw/oxnas_nand.c | 10 +- > drivers/mtd/nand/raw/pasemi_nand.c | 32 +- > drivers/mtd/nand/raw/plat_nand.c | 17 +- > drivers/mtd/nand/raw/qcom_nandc.c | 39 +- > drivers/mtd/nand/raw/r852.c | 14 +- > drivers/mtd/nand/raw/s3c2410.c | 34 +- > drivers/mtd/nand/raw/sh_flctl.c | 18 +- > drivers/mtd/nand/raw/sharpsl.c | 12 +- > drivers/mtd/nand/raw/sm_common.c | 2 +- > drivers/mtd/nand/raw/socrates_nand.c | 16 +- > drivers/mtd/nand/raw/sunxi_nand.c | 14 +- > drivers/mtd/nand/raw/tango_nand.c | 12 +- > drivers/mtd/nand/raw/tmio_nand.c | 20 +- > drivers/mtd/nand/raw/txx9ndfmc.c | 12 +- > drivers/mtd/nand/raw/xway_nand.c | 12 +- > drivers/staging/mt29f_spinand/mt29f_spinand.c | 16 +- > include/linux/mtd/jedec.h | 91 ++ > include/linux/mtd/onfi.h | 178 +++ > include/linux/mtd/platnand.h | 74 ++ > include/linux/mtd/rawnand.h | 555 ++-------- > 86 files changed, 2300 insertions(+), 2191 deletions(-) > create mode 100644 drivers/mtd/nand/raw/internals.h > create mode 100644 drivers/mtd/nand/raw/nand_jedec.c > create mode 100644 drivers/mtd/nand/raw/nand_legacy.c > create mode 100644 drivers/mtd/nand/raw/nand_onfi.c > create mode 100644 include/linux/mtd/jedec.h > create mode 100644 include/linux/mtd/onfi.h > create mode 100644 include/linux/mtd/platnand.h > Series reviewed, there is one typo in patch 2/19 and 16/19 and a s/ONFI/JEDEC/ in patch 19/19, otherwise I like the cleanup very much! Can I modify when applying or you plan to do more/other changes? Thanks, Miquèl From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Subject: Re: [PATCH 00/19] mtd: rawnand: API cleanup (2nd batch) Date: Sat, 15 Sep 2018 19:54:40 +0200 Message-ID: <20180915195440.251fea18@xps13> References: <20180906223851.6964-1-boris.brezillon@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180906223851.6964-1-boris.brezillon@bootlin.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Boris Brezillon Cc: Andrew Lunn , Rich Felker , linux-doc@vger.kernel.org, Tony Lindgren , linux-mips@linux-mips.org, linux-mtd@lists.infradead.org, Thomas Petazzoni , Robert Jarzmik , Alexander Clouter , devel@driverdev.osuosl.org, Alexander Shiyan , Jonathan Corbet , Richard Weinberger , Gregory CLEMENT , linux-sh@vger.kernel.org, Yoshinori Sato , Marek Vasut , NXP Linux Team , Sebastian Hesselbarth , Jason Cooper , Haojian Zhuang , Krzysztof Halasa , linux-omap@vger.kernel.org, Brian Norris List-Id: linux-omap@vger.kernel.org SGkgQm9yaXMsCgpCb3JpcyBCcmV6aWxsb24gPGJvcmlzLmJyZXppbGxvbkBib290bGluLmNvbT4g d3JvdGUgb24gRnJpLCAgNyBTZXAgMjAxOAowMDozODozMiArMDIwMDoKCj4gSGVsbG8sCj4gCj4g VGhpcyBpcyB0aGUgMm5kIGJhdGNoIG9mIEFQSSBjbGVhbnVwIHBhdGNoZXMuIFRoaXMgdGltZSB3 ZSBtb3ZlCj4gZGVwcmVjYXRlZCBob29rcy9maWVsZHMgdG8gdGhlIG5hbmRfbGVnYWN5IHN0cnVj dCwgYW5kIHRoZW4gbW92ZSBzb21lCj4gb2YgdGhlIGNvZGUgZm91bmQgaW4gbmFuZF9iYXNlLmMg aW50byBzZXBhcmF0ZSBzb3VyY2UvaGVhZGVyIGZpbGVzLgo+IAo+IFdpdGggdGhpcyBuZXcgb3Jn YW5pemF0aW9uLCBuZXcgY29tZXJzIHNob3VsZCBtb3JlIGVhc2lseSBpZGVudGlmeSB0aGUKPiBi aXRzIHRoZXkgY2FuIHVzZSBpbiB0aGVpciBOQU5EIGNvbnRyb2xsZXIgZHJpdmVycyBhbmQgdGhv c2UgdGhhdCBhcmUKPiBvbmx5IG1lYW50IGZvciBjb3JlIGNvZGUuIEl0IGFsc28gc2hyaW5rIGEg Yml0IG5hbmRfYmFzZS5jIHdoaWNoIHdhcwo+IG92ZXIgNjAwMCBsaW5lcyBvZiBjb2RlLgo+IAo+ IE5vdGUgdGhhdCBleGlzdGluZyBjb2Rpbmcgc3R5bGUgaXNzdWVzIChyZXBvcnRlZCBieSBjaGVj a3BhdGNoKSBpbiBhcmNoCj4gb3IgZHJpdmVyIGNvZGUgYXJlIGludGVudGlvbmFsbHkgbm90IGZp eGVkIHRvIGtlZXAgdGhlIHNlcmllcyBmb2N1c2VkCj4gb24gdGhlIEFQSS9jb3JlIGNsZWFudXAu Cj4gCj4gUmVnYXJkcywKPiAKPiBCb3Jpcwo+IAo+IEJvcmlzIEJyZXppbGxvbiAoMTkpOgo+ICAg bXRkOiByYXduYW5kOiBMZWF2ZSBjaGlwLT5JT19BRERSX3tSLFd9IHRvIE5VTEwgd2hlbiB1bnVz ZWQKPiAgIG10ZDogcmF3bmFuZDogQ3JlYXRlIGEgbGVnYWN5IHN0cnVjdCBhbmQgbW92ZSAtPklP X0FERFJfe1IsV30gdGhlcmUKPiAgIG10ZDogcmF3bmFuZDogRGVwcmVjYXRlIC0+e3JlYWQsd3Jp dGV9X3tieXRlLGJ1Zn0oKSBob29rcwo+ICAgbXRkOiByYXduYW5kOiBEZXByZWNhdGUgLT5jbWRf Y3RybCgpIGFuZCAtPmNtZGZ1bmMoKQo+ICAgbXRkOiByYXduYW5kOiBEZXByZWNhdGUgLT5kZXZf cmVhZHkoKSBhbmQgLT53YWl0ZnVuYygpCj4gICBtdGQ6IHJhd25hbmQ6IERlcHJlY2F0ZSAtPmJs b2NrX3tiYWQsbWFya2JhZH0oKSBob29rcwo+ICAgbXRkOiByYXduYW5kOiBEZXByZWNhdGUgLT5l cmFzZSgpCj4gICBtdGQ6IHJhd25hbmQ6IERlcHJlY2F0ZSAtPntzZXQsZ2V0fV9mZWF0dXJlcygp IGhvb2tzCj4gICBtdGQ6IHJhd25hbmQ6IERlcHJlY2F0ZSAtPmNoaXBfZGVsYXkKPiAgIG10ZDog cmF3bmFuZDogTW92ZSBmdW5jdGlvbiBwcm90b3R5cGVzIGFmdGVyIHN0cnVjdCBkZWNsYXJhdGlv bnMKPiAgIG10ZDogcmF3bmFuZDogR2V0IHJpZCBvZiBuYW5kX2ZsYXNoX2RldiBmb3J3YXJkIGRl Y2xhdGlvbgo+ICAgbXRkOiByYXduYW5kOiBHZXQgcmlkIG9mIHRoZSBkdXBsaWNhdGUgbmFuZF9j aGlwIGZvcndhcmQgZGVjbGFyYXRpb24KPiAgIG10ZDogcmF3bmFuZDogR2V0IHJpZCBvZiBhIGZl dyB1bnVzZWQgZGVmaW5pdGlvbnMKPiAgIG10ZDogcmF3bmFuZDogTW92ZSBwbGF0Zm9ybV9uYW5k X3h4eCBkZWZpbml0aW9ucyBvdXQgb2YgcmF3bmFuZC5oCj4gICBtdGQ6IHJhd25hbmQ6IElubGlu ZSBvbmZpX2dldF9hc3luY190aW1pbmdfbW9kZSgpCj4gICBtdGQ6IHJhd25hbmQ6IEtlZXAgYWxs IGludGVybmFsIHN0dWZmIHByaXZhdGUKPiAgIG10ZDogcmF3bmFuZDogTW92ZSBsZWdhY3kgY29k ZSB0byBuYW5kX2xlZ2FjeS5jCj4gICBtdGQ6IHJhd25hbmQ6IE1vdmUgT05GSSBjb2RlIHRvIG5h bmRfb25maS5jCj4gICBtdGQ6IHJhd25hbmQ6IE1vdmUgSkVERUMgY29kZSB0byBuYW5kX2plZGVj LmMKPiAKPiAgRG9jdW1lbnRhdGlvbi9kcml2ZXItYXBpL210ZG5hbmQucnN0ICAgICAgICAgICAg IHwgICAzMCArLQo+ICBhcmNoL2FybS9tYWNoLWVwOTN4eC9zbmFwcGVyY2wxNS5jICAgICAgICAg ICAgICAgfCAgICA4ICstCj4gIGFyY2gvYXJtL21hY2gtZXA5M3h4L3RzNzJ4eC5jICAgICAgICAg ICAgICAgICAgICB8ICAgIDkgKy0KPiAgYXJjaC9hcm0vbWFjaC1pbXgvbWFjaC1xb25nLmMgICAg ICAgICAgICAgICAgICAgIHwgICAgNiArLQo+ICBhcmNoL2FybS9tYWNoLWl4cDR4eC9peGRwNDI1 LXNldHVwLmMgICAgICAgICAgICAgfCAgICAyICstCj4gIGFyY2gvYXJtL21hY2gtb21hcDEvYm9h cmQtZnNhbXBsZS5jICAgICAgICAgICAgICB8ICAgIDMgKy0KPiAgYXJjaC9hcm0vbWFjaC1vbWFw MS9ib2FyZC1oMi5jICAgICAgICAgICAgICAgICAgIHwgICAgMyArLQo+ICBhcmNoL2FybS9tYWNo LW9tYXAxL2JvYXJkLWgzLmMgICAgICAgICAgICAgICAgICAgfCAgICAyICstCj4gIGFyY2gvYXJt L21hY2gtb21hcDEvYm9hcmQtbmFuZC5jICAgICAgICAgICAgICAgICB8ICAgIDIgKy0KPiAgYXJj aC9hcm0vbWFjaC1vbWFwMS9ib2FyZC1wZXJzZXVzMi5jICAgICAgICAgICAgIHwgICAgMyArLQo+ ICBhcmNoL2FybS9tYWNoLW9yaW9uNXgvdHM3OHh4LXNldHVwLmMgICAgICAgICAgICAgfCAgICA5 ICstCj4gIGFyY2gvYXJtL21hY2gtcHhhL2JhbGxvb24zLmMgICAgICAgICAgICAgICAgICAgICB8 ICAgIDUgKy0KPiAgYXJjaC9hcm0vbWFjaC1weGEvZW0teDI3MC5jICAgICAgICAgICAgICAgICAg ICAgIHwgICAgOSArLQo+ICBhcmNoL2FybS9tYWNoLXB4YS9wYWxtdHguYyAgICAgICAgICAgICAg ICAgICAgICAgfCAgICA1ICstCj4gIGFyY2gvbWlwcy9hbGNoZW15L2RldmJvYXJkcy9kYjEyMDAu YyAgICAgICAgICAgICB8ICAgIDkgKy0KPiAgYXJjaC9taXBzL2FsY2hlbXkvZGV2Ym9hcmRzL2Ri MTMwMC5jICAgICAgICAgICAgIHwgICAgOSArLQo+ICBhcmNoL21pcHMvYWxjaGVteS9kZXZib2Fy ZHMvZGIxNTUwLmMgICAgICAgICAgICAgfCAgICA5ICstCj4gIGFyY2gvbWlwcy9uZXRsb2dpYy94 bHIvcGxhdGZvcm0tZmxhc2guYyAgICAgICAgICB8ICAgIDMgKy0KPiAgYXJjaC9taXBzL3BueDgz M3gvY29tbW9uL3BsYXRmb3JtLmMgICAgICAgICAgICAgIHwgICAgNSArLQo+ICBhcmNoL21pcHMv cmI1MzIvZGV2aWNlcy5jICAgICAgICAgICAgICAgICAgICAgICAgfCAgICA1ICstCj4gIGFyY2gv c2gvYm9hcmRzL21hY2gtbWlnb3Ivc2V0dXAuYyAgICAgICAgICAgICAgICB8ICAgIDggKy0KPiAg ZHJpdmVycy9tdGQvbmFuZC9yYXcvTWFrZWZpbGUgICAgICAgICAgICAgICAgICAgIHwgICAgNCAr LQo+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9hbXMtZGVsdGEuYyAgICAgICAgICAgICAgICAgfCAg IDIyICstCj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L2F0bWVsL25hbmQtY29udHJvbGxlci5jICAg ICB8ICAgMjIgKy0KPiAgZHJpdmVycy9tdGQvbmFuZC9yYXcvYXUxNTUwbmQuYyAgICAgICAgICAg ICAgICAgIHwgICA0MyArLQo+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9iY200N3h4bmZsYXNoL29w c19iY200NzA2LmMgfCAgIDIyICstCj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L2JyY21uYW5kL2Jy Y21uYW5kLmMgICAgICAgICB8ICAgMTUgKy0KPiAgZHJpdmVycy9tdGQvbmFuZC9yYXcvY2FmZV9u YW5kLmMgICAgICAgICAgICAgICAgIHwgICAyMiArLQo+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9j bXgyNzBfbmFuZC5jICAgICAgICAgICAgICAgfCAgIDI4ICstCj4gIGRyaXZlcnMvbXRkL25hbmQv cmF3L2NzNTUzeF9uYW5kLmMgICAgICAgICAgICAgICB8ICAgNDIgKy0KPiAgZHJpdmVycy9tdGQv bmFuZC9yYXcvZGF2aW5jaV9uYW5kLmMgICAgICAgICAgICAgIHwgICAzNCArLQo+ICBkcml2ZXJz L210ZC9uYW5kL3Jhdy9kZW5hbGkuYyAgICAgICAgICAgICAgICAgICAgfCAgIDIzICstCj4gIGRy aXZlcnMvbXRkL25hbmQvcmF3L2Rpc2tvbmNoaXAuYyAgICAgICAgICAgICAgICB8ICAgNTAgKy0K PiAgZHJpdmVycy9tdGQvbmFuZC9yYXcvZnNsX2VsYmNfbmFuZC5jICAgICAgICAgICAgIHwgICAx OCArLQo+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9mc2xfaWZjX25hbmQuYyAgICAgICAgICAgICAg fCAgIDI0ICstCj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L2ZzbF91cG0uYyAgICAgICAgICAgICAg ICAgICB8ICAgMzAgKy0KPiAgZHJpdmVycy9tdGQvbmFuZC9yYXcvZnNtY19uYW5kLmMgICAgICAg ICAgICAgICAgIHwgICAgMSAtCj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L2dwaW8uYyAgICAgICAg ICAgICAgICAgICAgICB8ICAgMTYgKy0KPiAgZHJpdmVycy9tdGQvbmFuZC9yYXcvZ3BtaS1uYW5k L2dwbWktbmFuZC5jICAgICAgIHwgICAyMiArLQo+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9oaXNp NTA0X25hbmQuYyAgICAgICAgICAgICAgfCAgIDE4ICstCj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3 L2ludGVybmFscy5oICAgICAgICAgICAgICAgICB8ICAxMTQgKysKPiAgZHJpdmVycy9tdGQvbmFu ZC9yYXcvano0NzQwX25hbmQuYyAgICAgICAgICAgICAgIHwgICAxNCArLQo+ICBkcml2ZXJzL210 ZC9uYW5kL3Jhdy9qejQ3ODBfbmFuZC5jICAgICAgICAgICAgICAgfCAgIDEwICstCj4gIGRyaXZl cnMvbXRkL25hbmQvcmF3L2xwYzMyeHhfbWxjLmMgICAgICAgICAgICAgICB8ICAgMTIgKy0KPiAg ZHJpdmVycy9tdGQvbmFuZC9yYXcvbHBjMzJ4eF9zbGMuYyAgICAgICAgICAgICAgIHwgICAyNiAr LQo+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9tcGM1MTIxX25mYy5jICAgICAgICAgICAgICAgfCAg IDE0ICstCj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L210a19uYW5kLmMgICAgICAgICAgICAgICAg ICB8ICAgMTIgKy0KPiAgZHJpdmVycy9tdGQvbmFuZC9yYXcvbXhjX25hbmQuYyAgICAgICAgICAg ICAgICAgIHwgICAyMCArLQo+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9uYW5kX2FtZC5jICAgICAg ICAgICAgICAgICAgfCAgICAyICstCj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L25hbmRfYmFzZS5j ICAgICAgICAgICAgICAgICB8IDEyNjAgKysrLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICBkcml2ZXJz L210ZC9uYW5kL3Jhdy9uYW5kX2JidC5jICAgICAgICAgICAgICAgICAgfCAgICA1ICstCj4gIGRy aXZlcnMvbXRkL25hbmQvcmF3L25hbmRfaHluaXguYyAgICAgICAgICAgICAgICB8ICAgIDkgKy0K PiAgZHJpdmVycy9tdGQvbmFuZC9yYXcvbmFuZF9pZHMuYyAgICAgICAgICAgICAgICAgIHwgICAg NCArLQo+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9uYW5kX2plZGVjLmMgICAgICAgICAgICAgICAg fCAgMTEzICsrCj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L25hbmRfbGVnYWN5LmMgICAgICAgICAg ICAgICB8ICA2NDIgKysrKysrKysrKysKPiAgZHJpdmVycy9tdGQvbmFuZC9yYXcvbmFuZF9tYWNy b25peC5jICAgICAgICAgICAgIHwgICAgMiArLQo+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9uYW5k X21pY3Jvbi5jICAgICAgICAgICAgICAgfCAgICAzICstCj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3 L25hbmRfb25maS5jICAgICAgICAgICAgICAgICB8ICAzMDUgKysrKysrCj4gIGRyaXZlcnMvbXRk L25hbmQvcmF3L25hbmRfc2Ftc3VuZy5jICAgICAgICAgICAgICB8ICAgIDIgKy0KPiAgZHJpdmVy cy9tdGQvbmFuZC9yYXcvbmFuZF90aW1pbmdzLmMgICAgICAgICAgICAgIHwgICAxOCArLQo+ICBk cml2ZXJzL210ZC9uYW5kL3Jhdy9uYW5kX3Rvc2hpYmEuYyAgICAgICAgICAgICAgfCAgICAyICst Cj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L25hbmRzaW0uYyAgICAgICAgICAgICAgICAgICB8ICAg MTQgKy0KPiAgZHJpdmVycy9tdGQvbmFuZC9yYXcvbmRmYy5jICAgICAgICAgICAgICAgICAgICAg IHwgICAxNCArLQo+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9udWM5MDBfbmFuZC5jICAgICAgICAg ICAgICAgfCAgIDIyICstCj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L29tYXAyLmMgICAgICAgICAg ICAgICAgICAgICB8ICAgNjIgKy0KPiAgZHJpdmVycy9tdGQvbmFuZC9yYXcvb3Jpb25fbmFuZC5j ICAgICAgICAgICAgICAgIHwgICAxMiArLQo+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9veG5hc19u YW5kLmMgICAgICAgICAgICAgICAgfCAgIDEwICstCj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L3Bh c2VtaV9uYW5kLmMgICAgICAgICAgICAgICB8ICAgMzIgKy0KPiAgZHJpdmVycy9tdGQvbmFuZC9y YXcvcGxhdF9uYW5kLmMgICAgICAgICAgICAgICAgIHwgICAxNyArLQo+ICBkcml2ZXJzL210ZC9u YW5kL3Jhdy9xY29tX25hbmRjLmMgICAgICAgICAgICAgICAgfCAgIDM5ICstCj4gIGRyaXZlcnMv bXRkL25hbmQvcmF3L3I4NTIuYyAgICAgICAgICAgICAgICAgICAgICB8ICAgMTQgKy0KPiAgZHJp dmVycy9tdGQvbmFuZC9yYXcvczNjMjQxMC5jICAgICAgICAgICAgICAgICAgIHwgICAzNCArLQo+ ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9zaF9mbGN0bC5jICAgICAgICAgICAgICAgICAgfCAgIDE4 ICstCj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L3NoYXJwc2wuYyAgICAgICAgICAgICAgICAgICB8 ICAgMTIgKy0KPiAgZHJpdmVycy9tdGQvbmFuZC9yYXcvc21fY29tbW9uLmMgICAgICAgICAgICAg ICAgIHwgICAgMiArLQo+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy9zb2NyYXRlc19uYW5kLmMgICAg ICAgICAgICAgfCAgIDE2ICstCj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3L3N1bnhpX25hbmQuYyAg ICAgICAgICAgICAgICB8ICAgMTQgKy0KPiAgZHJpdmVycy9tdGQvbmFuZC9yYXcvdGFuZ29fbmFu ZC5jICAgICAgICAgICAgICAgIHwgICAxMiArLQo+ICBkcml2ZXJzL210ZC9uYW5kL3Jhdy90bWlv X25hbmQuYyAgICAgICAgICAgICAgICAgfCAgIDIwICstCj4gIGRyaXZlcnMvbXRkL25hbmQvcmF3 L3R4eDluZGZtYy5jICAgICAgICAgICAgICAgICB8ICAgMTIgKy0KPiAgZHJpdmVycy9tdGQvbmFu ZC9yYXcveHdheV9uYW5kLmMgICAgICAgICAgICAgICAgIHwgICAxMiArLQo+ICBkcml2ZXJzL3N0 YWdpbmcvbXQyOWZfc3BpbmFuZC9tdDI5Zl9zcGluYW5kLmMgICAgfCAgIDE2ICstCj4gIGluY2x1 ZGUvbGludXgvbXRkL2plZGVjLmggICAgICAgICAgICAgICAgICAgICAgICB8ICAgOTEgKysKPiAg aW5jbHVkZS9saW51eC9tdGQvb25maS5oICAgICAgICAgICAgICAgICAgICAgICAgIHwgIDE3OCAr KysKPiAgaW5jbHVkZS9saW51eC9tdGQvcGxhdG5hbmQuaCAgICAgICAgICAgICAgICAgICAgIHwg ICA3NCArKwo+ICBpbmNsdWRlL2xpbnV4L210ZC9yYXduYW5kLmggICAgICAgICAgICAgICAgICAg ICAgfCAgNTU1ICsrLS0tLS0tLS0KPiAgODYgZmlsZXMgY2hhbmdlZCwgMjMwMCBpbnNlcnRpb25z KCspLCAyMTkxIGRlbGV0aW9ucygtKQo+ICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9tdGQv bmFuZC9yYXcvaW50ZXJuYWxzLmgKPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvbXRkL25h bmQvcmF3L25hbmRfamVkZWMuYwo+ICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9tdGQvbmFu ZC9yYXcvbmFuZF9sZWdhY3kuYwo+ICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9tdGQvbmFu ZC9yYXcvbmFuZF9vbmZpLmMKPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGluY2x1ZGUvbGludXgvbXRk L2plZGVjLmgKPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGluY2x1ZGUvbGludXgvbXRkL29uZmkuaAo+ ICBjcmVhdGUgbW9kZSAxMDA2NDQgaW5jbHVkZS9saW51eC9tdGQvcGxhdG5hbmQuaAo+IAoKU2Vy aWVzIHJldmlld2VkLCB0aGVyZSBpcyBvbmUgdHlwbyBpbiBwYXRjaCAyLzE5IGFuZCAxNi8xOSBh bmQgYQpzL09ORkkvSkVERUMvIGluIHBhdGNoIDE5LzE5LCBvdGhlcndpc2UgSSBsaWtlIHRoZSBj bGVhbnVwIHZlcnkgbXVjaCEKQ2FuIEkgbW9kaWZ5IHdoZW4gYXBwbHlpbmcgb3IgeW91IHBsYW4g dG8gZG8gbW9yZS9vdGhlciBjaGFuZ2VzPwoKClRoYW5rcywKTWlxdcOobApfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkZXZlbCBtYWlsaW5nIGxpc3QKZGV2 ZWxAbGludXhkcml2ZXJwcm9qZWN0Lm9yZwpodHRwOi8vZHJpdmVyZGV2LmxpbnV4ZHJpdmVycHJv amVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcml2ZXJkZXYtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Date: Sat, 15 Sep 2018 17:54:40 +0000 Subject: Re: [PATCH 00/19] mtd: rawnand: API cleanup (2nd batch) Message-Id: <20180915195440.251fea18@xps13> List-Id: References: <20180906223851.6964-1-boris.brezillon@bootlin.com> In-Reply-To: <20180906223851.6964-1-boris.brezillon@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Boris Brezillon Cc: Richard Weinberger , linux-mtd@lists.infradead.org, David Woodhouse , Brian Norris , Marek Vasut , Jonathan Corbet , linux-doc@vger.kernel.org, Hartley Sweeten , Ryan Mallon , Alexander Shiyan , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , Imre Kaloz , Krzysztof Halasa , Tony Lindgren , linux-omap@vger.kernel.org, Alexander Clouter , Thomas Petazzoni , Gregory CLEMENT , Jason Cooper , Sebastian Hesselbarth , Andrew Lunn , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Ralf Baechle , linux-mips@linux-mips.org, Yoshinori Sato , Rich Felker , linux-sh@vger.kernel.org, Greg Kroah-Hartman , devel@driverdev.osuosl.org Hi Boris, Boris Brezillon wrote on Fri, 7 Sep 2018 00:38:32 +0200: > Hello, >=20 > This is the 2nd batch of API cleanup patches. This time we move > deprecated hooks/fields to the nand_legacy struct, and then move some > of the code found in nand_base.c into separate source/header files. >=20 > With this new organization, new comers should more easily identify the > bits they can use in their NAND controller drivers and those that are > only meant for core code. It also shrink a bit nand_base.c which was > over 6000 lines of code. >=20 > Note that existing coding style issues (reported by checkpatch) in arch > or driver code are intentionally not fixed to keep the series focused > on the API/core cleanup. >=20 > Regards, >=20 > Boris >=20 > Boris Brezillon (19): > mtd: rawnand: Leave chip->IO_ADDR_{R,W} to NULL when unused > mtd: rawnand: Create a legacy struct and move ->IO_ADDR_{R,W} there > mtd: rawnand: Deprecate ->{read,write}_{byte,buf}() hooks > mtd: rawnand: Deprecate ->cmd_ctrl() and ->cmdfunc() > mtd: rawnand: Deprecate ->dev_ready() and ->waitfunc() > mtd: rawnand: Deprecate ->block_{bad,markbad}() hooks > mtd: rawnand: Deprecate ->erase() > mtd: rawnand: Deprecate ->{set,get}_features() hooks > mtd: rawnand: Deprecate ->chip_delay > mtd: rawnand: Move function prototypes after struct declarations > mtd: rawnand: Get rid of nand_flash_dev forward declation > mtd: rawnand: Get rid of the duplicate nand_chip forward declaration > mtd: rawnand: Get rid of a few unused definitions > mtd: rawnand: Move platform_nand_xxx definitions out of rawnand.h > mtd: rawnand: Inline onfi_get_async_timing_mode() > mtd: rawnand: Keep all internal stuff private > mtd: rawnand: Move legacy code to nand_legacy.c > mtd: rawnand: Move ONFI code to nand_onfi.c > mtd: rawnand: Move JEDEC code to nand_jedec.c >=20 > Documentation/driver-api/mtdnand.rst | 30 +- > arch/arm/mach-ep93xx/snappercl15.c | 8 +- > arch/arm/mach-ep93xx/ts72xx.c | 9 +- > arch/arm/mach-imx/mach-qong.c | 6 +- > arch/arm/mach-ixp4xx/ixdp425-setup.c | 2 +- > arch/arm/mach-omap1/board-fsample.c | 3 +- > arch/arm/mach-omap1/board-h2.c | 3 +- > arch/arm/mach-omap1/board-h3.c | 2 +- > arch/arm/mach-omap1/board-nand.c | 2 +- > arch/arm/mach-omap1/board-perseus2.c | 3 +- > arch/arm/mach-orion5x/ts78xx-setup.c | 9 +- > arch/arm/mach-pxa/balloon3.c | 5 +- > arch/arm/mach-pxa/em-x270.c | 9 +- > arch/arm/mach-pxa/palmtx.c | 5 +- > arch/mips/alchemy/devboards/db1200.c | 9 +- > arch/mips/alchemy/devboards/db1300.c | 9 +- > arch/mips/alchemy/devboards/db1550.c | 9 +- > arch/mips/netlogic/xlr/platform-flash.c | 3 +- > arch/mips/pnx833x/common/platform.c | 5 +- > arch/mips/rb532/devices.c | 5 +- > arch/sh/boards/mach-migor/setup.c | 8 +- > drivers/mtd/nand/raw/Makefile | 4 +- > drivers/mtd/nand/raw/ams-delta.c | 22 +- > drivers/mtd/nand/raw/atmel/nand-controller.c | 22 +- > drivers/mtd/nand/raw/au1550nd.c | 43 +- > drivers/mtd/nand/raw/bcm47xxnflash/ops_bcm4706.c | 22 +- > drivers/mtd/nand/raw/brcmnand/brcmnand.c | 15 +- > drivers/mtd/nand/raw/cafe_nand.c | 22 +- > drivers/mtd/nand/raw/cmx270_nand.c | 28 +- > drivers/mtd/nand/raw/cs553x_nand.c | 42 +- > drivers/mtd/nand/raw/davinci_nand.c | 34 +- > drivers/mtd/nand/raw/denali.c | 23 +- > drivers/mtd/nand/raw/diskonchip.c | 50 +- > drivers/mtd/nand/raw/fsl_elbc_nand.c | 18 +- > drivers/mtd/nand/raw/fsl_ifc_nand.c | 24 +- > drivers/mtd/nand/raw/fsl_upm.c | 30 +- > drivers/mtd/nand/raw/fsmc_nand.c | 1 - > drivers/mtd/nand/raw/gpio.c | 16 +- > drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 22 +- > drivers/mtd/nand/raw/hisi504_nand.c | 18 +- > drivers/mtd/nand/raw/internals.h | 114 ++ > drivers/mtd/nand/raw/jz4740_nand.c | 14 +- > drivers/mtd/nand/raw/jz4780_nand.c | 10 +- > drivers/mtd/nand/raw/lpc32xx_mlc.c | 12 +- > drivers/mtd/nand/raw/lpc32xx_slc.c | 26 +- > drivers/mtd/nand/raw/mpc5121_nfc.c | 14 +- > drivers/mtd/nand/raw/mtk_nand.c | 12 +- > drivers/mtd/nand/raw/mxc_nand.c | 20 +- > drivers/mtd/nand/raw/nand_amd.c | 2 +- > drivers/mtd/nand/raw/nand_base.c | 1260 +++-------------= ------ > drivers/mtd/nand/raw/nand_bbt.c | 5 +- > drivers/mtd/nand/raw/nand_hynix.c | 9 +- > drivers/mtd/nand/raw/nand_ids.c | 4 +- > drivers/mtd/nand/raw/nand_jedec.c | 113 ++ > drivers/mtd/nand/raw/nand_legacy.c | 642 +++++++++++ > drivers/mtd/nand/raw/nand_macronix.c | 2 +- > drivers/mtd/nand/raw/nand_micron.c | 3 +- > drivers/mtd/nand/raw/nand_onfi.c | 305 ++++++ > drivers/mtd/nand/raw/nand_samsung.c | 2 +- > drivers/mtd/nand/raw/nand_timings.c | 18 +- > drivers/mtd/nand/raw/nand_toshiba.c | 2 +- > drivers/mtd/nand/raw/nandsim.c | 14 +- > drivers/mtd/nand/raw/ndfc.c | 14 +- > drivers/mtd/nand/raw/nuc900_nand.c | 22 +- > drivers/mtd/nand/raw/omap2.c | 62 +- > drivers/mtd/nand/raw/orion_nand.c | 12 +- > drivers/mtd/nand/raw/oxnas_nand.c | 10 +- > drivers/mtd/nand/raw/pasemi_nand.c | 32 +- > drivers/mtd/nand/raw/plat_nand.c | 17 +- > drivers/mtd/nand/raw/qcom_nandc.c | 39 +- > drivers/mtd/nand/raw/r852.c | 14 +- > drivers/mtd/nand/raw/s3c2410.c | 34 +- > drivers/mtd/nand/raw/sh_flctl.c | 18 +- > drivers/mtd/nand/raw/sharpsl.c | 12 +- > drivers/mtd/nand/raw/sm_common.c | 2 +- > drivers/mtd/nand/raw/socrates_nand.c | 16 +- > drivers/mtd/nand/raw/sunxi_nand.c | 14 +- > drivers/mtd/nand/raw/tango_nand.c | 12 +- > drivers/mtd/nand/raw/tmio_nand.c | 20 +- > drivers/mtd/nand/raw/txx9ndfmc.c | 12 +- > drivers/mtd/nand/raw/xway_nand.c | 12 +- > drivers/staging/mt29f_spinand/mt29f_spinand.c | 16 +- > include/linux/mtd/jedec.h | 91 ++ > include/linux/mtd/onfi.h | 178 +++ > include/linux/mtd/platnand.h | 74 ++ > include/linux/mtd/rawnand.h | 555 ++-------- > 86 files changed, 2300 insertions(+), 2191 deletions(-) > create mode 100644 drivers/mtd/nand/raw/internals.h > create mode 100644 drivers/mtd/nand/raw/nand_jedec.c > create mode 100644 drivers/mtd/nand/raw/nand_legacy.c > create mode 100644 drivers/mtd/nand/raw/nand_onfi.c > create mode 100644 include/linux/mtd/jedec.h > create mode 100644 include/linux/mtd/onfi.h > create mode 100644 include/linux/mtd/platnand.h >=20 Series reviewed, there is one typo in patch 2/19 and 16/19 and a s/ONFI/JEDEC/ in patch 19/19, otherwise I like the cleanup very much! Can I modify when applying or you plan to do more/other changes? Thanks, Miqu=C3=A8l