From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com ([192.55.52.136]:40174 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728438AbeIQAbq (ORCPT ); Sun, 16 Sep 2018 20:31:46 -0400 Date: Sun, 16 Sep 2018 22:07:24 +0300 From: Jarkko Sakkinen To: Arnd Bergmann Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, Sudip Mukherjee , Greg Kroah-Hartman , Peter Huewe , Jason Gunthorpe , Stefan Richter , Jiri Kosina , Benjamin Tissoires , Alexander Shishkin , Tomas Winkler , Artem Bityutskiy , Marek Vasut , "David S. Miller" , Alex Williamson , OGAWA Hirofumi , linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, linux1394-devel@lists.sourceforge.net, linux-usb@vger.kernel.org, linux-input@vger.kernel.org, linux-mtd@lists.infradead.org, netdev@vger.kernel.org, devel@driverdev.osuosl.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v2 02/17] compat_ioctl: move drivers to generic_compat_ioctl_ptrarg Message-ID: <20180916190724.GA7473@linux.intel.com> References: <20180912150142.157913-1-arnd@arndb.de> <20180912150142.157913-2-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180912150142.157913-2-arnd@arndb.de> Sender: linux-integrity-owner@vger.kernel.org List-ID: On Wed, Sep 12, 2018 at 05:01:03PM +0200, Arnd Bergmann wrote: > diff --git a/drivers/char/tpm/tpm_vtpm_proxy.c b/drivers/char/tpm/tpm_vtpm_proxy.c > index 87a0ce47f201..a170f5ca7416 100644 > --- a/drivers/char/tpm/tpm_vtpm_proxy.c > +++ b/drivers/char/tpm/tpm_vtpm_proxy.c > @@ -678,20 +678,10 @@ static long vtpmx_fops_ioctl(struct file *f, unsigned int ioctl, > } > } > > -#ifdef CONFIG_COMPAT > -static long vtpmx_fops_compat_ioctl(struct file *f, unsigned int ioctl, > - unsigned long arg) > -{ > - return vtpmx_fops_ioctl(f, ioctl, (unsigned long)compat_ptr(arg)); > -} > -#endif > - > static const struct file_operations vtpmx_fops = { > .owner = THIS_MODULE, > .unlocked_ioctl = vtpmx_fops_ioctl, > -#ifdef CONFIG_COMPAT > - .compat_ioctl = vtpmx_fops_compat_ioctl, > -#endif > + .compat_ioctl = generic_compat_ioctl_ptrarg, > .llseek = noop_llseek, > }; Reviewed-by: Jarkko Sakkinen /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH v2 02/17] compat_ioctl: move drivers to generic_compat_ioctl_ptrarg Date: Sun, 16 Sep 2018 22:07:24 +0300 Message-ID: <20180916190724.GA7473@linux.intel.com> References: <20180912150142.157913-1-arnd@arndb.de> <20180912150142.157913-2-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20180912150142.157913-2-arnd@arndb.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Arnd Bergmann Cc: kvm@vger.kernel.org, Alexander Shishkin , virtualization@lists.linux-foundation.org, Benjamin Tissoires , linux-mtd@lists.infradead.org, Peter Huewe , linux1394-devel@lists.sourceforge.net, devel@driverdev.osuosl.org, Jason Gunthorpe , Marek Vasut , linux-input@vger.kernel.org, Tomas Winkler , Jiri Kosina , Alex Williamson , viro@zeniv.linux.org.uk, OGAWA Hirofumi , Artem Bityutskiy , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Sudip Mukherjee , Stefan Richter , netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org List-Id: linux-input@vger.kernel.org On Wed, Sep 12, 2018 at 05:01:03PM +0200, Arnd Bergmann wrote: > diff --git a/drivers/char/tpm/tpm_vtpm_proxy.c b/drivers/char/tpm/tpm_vtpm_proxy.c > index 87a0ce47f201..a170f5ca7416 100644 > --- a/drivers/char/tpm/tpm_vtpm_proxy.c > +++ b/drivers/char/tpm/tpm_vtpm_proxy.c > @@ -678,20 +678,10 @@ static long vtpmx_fops_ioctl(struct file *f, unsigned int ioctl, > } > } > > -#ifdef CONFIG_COMPAT > -static long vtpmx_fops_compat_ioctl(struct file *f, unsigned int ioctl, > - unsigned long arg) > -{ > - return vtpmx_fops_ioctl(f, ioctl, (unsigned long)compat_ptr(arg)); > -} > -#endif > - > static const struct file_operations vtpmx_fops = { > .owner = THIS_MODULE, > .unlocked_ioctl = vtpmx_fops_ioctl, > -#ifdef CONFIG_COMPAT > - .compat_ioctl = vtpmx_fops_compat_ioctl, > -#endif > + .compat_ioctl = generic_compat_ioctl_ptrarg, > .llseek = noop_llseek, > }; Reviewed-by: Jarkko Sakkinen /Jarkko From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,02/17] compat_ioctl: move drivers to generic_compat_ioctl_ptrarg From: Jarkko Sakkinen Message-Id: <20180916190724.GA7473@linux.intel.com> Date: Sun, 16 Sep 2018 22:07:24 +0300 To: Arnd Bergmann Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, Sudip Mukherjee , Greg Kroah-Hartman , Peter Huewe , Jason Gunthorpe , Stefan Richter , Jiri Kosina , Benjamin Tissoires , Alexander Shishkin , Tomas Winkler , Artem Bityutskiy , Marek Vasut , "David S. Miller" , Alex Williamson , OGAWA Hirofumi , linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, linux1394-devel@lists.sourceforge.net, linux-usb@vger.kernel.org, linux-input@vger.kernel.org, linux-mtd@lists.infradead.org, netdev@vger.kernel.org, devel@driverdev.osuosl.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org List-ID: T24gV2VkLCBTZXAgMTIsIDIwMTggYXQgMDU6MDE6MDNQTSArMDIwMCwgQXJuZCBCZXJnbWFubiB3 cm90ZToKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9jaGFyL3RwbS90cG1fdnRwbV9wcm94eS5jIGIv ZHJpdmVycy9jaGFyL3RwbS90cG1fdnRwbV9wcm94eS5jCj4gaW5kZXggODdhMGNlNDdmMjAxLi5h MTcwZjVjYTc0MTYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9jaGFyL3RwbS90cG1fdnRwbV9wcm94 eS5jCj4gKysrIGIvZHJpdmVycy9jaGFyL3RwbS90cG1fdnRwbV9wcm94eS5jCj4gQEAgLTY3OCwy MCArNjc4LDEwIEBAIHN0YXRpYyBsb25nIHZ0cG14X2ZvcHNfaW9jdGwoc3RydWN0IGZpbGUgKmYs IHVuc2lnbmVkIGludCBpb2N0bCwKPiAgCX0KPiAgfQo+ICAKPiAtI2lmZGVmIENPTkZJR19DT01Q QVQKPiAtc3RhdGljIGxvbmcgdnRwbXhfZm9wc19jb21wYXRfaW9jdGwoc3RydWN0IGZpbGUgKmYs IHVuc2lnbmVkIGludCBpb2N0bCwKPiAtCQkJCQkgIHVuc2lnbmVkIGxvbmcgYXJnKQo+IC17Cj4g LQlyZXR1cm4gdnRwbXhfZm9wc19pb2N0bChmLCBpb2N0bCwgKHVuc2lnbmVkIGxvbmcpY29tcGF0 X3B0cihhcmcpKTsKPiAtfQo+IC0jZW5kaWYKPiAtCj4gIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZmls ZV9vcGVyYXRpb25zIHZ0cG14X2ZvcHMgPSB7Cj4gIAkub3duZXIgPSBUSElTX01PRFVMRSwKPiAg CS51bmxvY2tlZF9pb2N0bCA9IHZ0cG14X2ZvcHNfaW9jdGwsCj4gLSNpZmRlZiBDT05GSUdfQ09N UEFUCj4gLQkuY29tcGF0X2lvY3RsID0gdnRwbXhfZm9wc19jb21wYXRfaW9jdGwsCj4gLSNlbmRp Zgo+ICsJLmNvbXBhdF9pb2N0bCA9IGdlbmVyaWNfY29tcGF0X2lvY3RsX3B0cmFyZywKPiAgCS5s bHNlZWsgPSBub29wX2xsc2VlaywKPiAgfTsKClJldmlld2VkLWJ5OiBKYXJra28gU2Fra2luZW4g PGphcmtrby5zYWtraW5lbkBsaW51eC5pbnRlbC5jb20+CgovSmFya2tvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH v2 02/17] compat_ioctl: move drivers to generic_compat_ioctl_ptrarg Date: Sun, 16 Sep 2018 22:07:24 +0300 Message-ID: <20180916190724.GA7473@linux.intel.com> References: <20180912150142.157913-1-arnd@arndb.de> <20180912150142.157913-2-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Alexander Shishkin , virtualization@lists.linux-foundation.org, Benjamin Tissoires , linux-mtd@lists.infradead.org, Peter Huewe , linux1394-devel@lists.sourceforge.net, devel@driverdev.osuosl.org, Jason Gunthorpe , Marek Vasut , linux-input@vger.kernel.org, Tomas Winkler , Jiri Kosina , Alex Williamson , viro@zeniv.linux.org.uk, OGAWA Hirofumi , Artem Bityutskiy , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Sudip Mukherjee , Stefan Richter , netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, To: Arnd Bergmann Return-path: Content-Disposition: inline In-Reply-To: <20180912150142.157913-2-arnd@arndb.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" List-Id: kvm.vger.kernel.org On Wed, Sep 12, 2018 at 05:01:03PM +0200, Arnd Bergmann wrote: > diff --git a/drivers/char/tpm/tpm_vtpm_proxy.c b/drivers/char/tpm/tpm_vtpm_proxy.c > index 87a0ce47f201..a170f5ca7416 100644 > --- a/drivers/char/tpm/tpm_vtpm_proxy.c > +++ b/drivers/char/tpm/tpm_vtpm_proxy.c > @@ -678,20 +678,10 @@ static long vtpmx_fops_ioctl(struct file *f, unsigned int ioctl, > } > } > > -#ifdef CONFIG_COMPAT > -static long vtpmx_fops_compat_ioctl(struct file *f, unsigned int ioctl, > - unsigned long arg) > -{ > - return vtpmx_fops_ioctl(f, ioctl, (unsigned long)compat_ptr(arg)); > -} > -#endif > - > static const struct file_operations vtpmx_fops = { > .owner = THIS_MODULE, > .unlocked_ioctl = vtpmx_fops_ioctl, > -#ifdef CONFIG_COMPAT > - .compat_ioctl = vtpmx_fops_compat_ioctl, > -#endif > + .compat_ioctl = generic_compat_ioctl_ptrarg, > .llseek = noop_llseek, > }; Reviewed-by: Jarkko Sakkinen /Jarkko