All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] monkey: add option for SSL/TLS plugin compilation
Date: Mon, 17 Sep 2018 12:01:55 +0200	[thread overview]
Message-ID: <20180917120155.617afb89@windsurf> (raw)
In-Reply-To: <2120fe96-83cd-3d1e-0bfb-e085dafaad36@smile.fr>

Hello David,

Thanks for your contribution!

On Mon, 17 Sep 2018 12:09:01 +0200, Pierret David wrote:
> This commit add an option to enable SSL/TLS plugin compilation who is 
> not build
> by default.
> If mbedtls library is selected, she will be used instead of build-in one.

We always want to use external libraries instead of bundled libraries.

> +config BR2_PACKAGE_MONKEY_SSL
> +        bool "enable SSL/TLS"
> +        help
> +          Enable build of the SSL/TLS plugin.

Please use one tab to indent bool and help, and one tab + two spaces to
indent the help text.

Make sure to run "make check-package" after your changes to verify that
you do not introduce coding style issues such as those ones.

> +ifeq ($(BR2_PACKAGE_MONKEY_SSL), y)

No space before "y".

> +MONKEY_CONF_OPTS += --enable-plugins=tls
> +# If we already have TLS/SSL library, use it.
> +ifeq ($(BR2_PACKAGE_MBEDTLS), y)
> +MONKEY_CONF_OPTS += --mbedtls-shared
> +endif
> +endif

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-09-17 10:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-17 10:09 [Buildroot] [PATCH 2/2] monkey: add option for SSL/TLS plugin compilation Pierret David
2018-09-17 10:01 ` Thomas Petazzoni [this message]
2018-09-17 11:29   ` Pierret David
2018-09-17 11:30     ` Pierret David
2018-09-17 11:50       ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180917120155.617afb89@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.